[IGNITE-21569] Introduce Spotbugs checks

• Type: Improvement
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 3.0
• Labels: ignite-3 spotbugs
• Ignite Flags: Docs Required, Release Notes Required
• Assignee: Viacheslav Blinov
• Reporter: Viacheslav Blinov
• Created: 20/Feb/24 09:14
• Updated: 04/Sep/24 16:08
• Resolved: 13/Mar/24 13:04

Description

Spotbugs can bring additional value to static code analysis of ignite:

1. Remove modernizer plugin and migrate its rules with Spotbugs rule DM_DEFAULT_ENCODING
2. Escape analysis for unclosed Closable instances (OS_OPEN_STREAM, OS_OPEN_STREAM_EXCEPTION_PATH)
3. Checks for misusages of InputStream.read and skip (RR_NOT_CHECKED, SR_NOT_CHECKED)

There are other reasonable rules Ignite could also benefit from.

Issue Links

• blocks: IGNITE-21687 Modify TC jobs to run Spotbugs checks
• relates to: IGNITE-21467 Improve PMD and Checkstyle rulesets
• relates to: IGNITE-21752 Generated CLI code is reported by SpotBugs
• split to: IGNITE-21690 ConfigurationNode has inconsistent synchronized access to fields `invalid` and `val`
• split to: IGNITE-21691 BasicMetricExporter has inconsistent synchronized access to field `configuration`
• split to: IGNITE-21694 HeapLockManager/HeapUnboundedLockManager makes inefficient use of keySet iterator instead of entrySet iterator
• split to: IGNITE-21701 Sql. IgniteSender compares unrelated types
• split to: IGNITE-21695 PageHandler: useless control flow
• split to: IGNITE-21699 Sql. DistributionFunction compares strings by reference
• split to: IGNITE-21702 AbstractNode field `inBufSize` is unused
• split to: IGNITE-21703 Sql. IgniteSqlFunctions.octetLength relies on default encoding
• split to: IGNITE-21704 ConfigurationListenerHolder uses weird equals implementation
• split to: IGNITE-21705 CheckpointWorkflow uses weird equals implementation
• split to: IGNITE-21706 RandomLruPageReplacementPolicy has dead conditions
• split to: IGNITE-21693 TxManagerImpl increments/decrements volatile field `inflights`
• split to: IGNITE-21700 IgniteSort: result of RelOptCost.plus is ignored but it doesn't have side-effects
• split to: IGNITE-21696 LazyStripedExecutor performs synchronization on AtomicReferenceArray
• split to: IGNITE-21692 AbstractFreeList has unused private method `initReusedPage`
• split to: IGNITE-21698 LocalConfigurationStorage reboxes unboxed value
• split to: IGNITE-21697 ConnectionManager ignores exceptional return value of ExecutorService.submit
• links to: GitHub Pull Request #3373