[IGNITE-21690] ConfigurationNode has inconsistent synchronized access to fields `invalid` and `val`

• Type: Bug
• Status: Open
• Priority: Major
• Resolution: Unresolved
• Labels: ignite-3 spotbugs
• Ignite Flags: Docs Required, Release Notes Required
• Assignee: Unassigned
• Reporter: Viacheslav Blinov
• Created: 06/Mar/24 15:32
• Updated: 12/Mar/24 12:11

Description

Issue detected by SpotBugs but is also highlighted by Idea inspection. Specifically the warning reported is:

M M IS2_INCONSISTENT_SYNC IS: Inconsistent synchronization of org.apache.ignite.internal.configuration.ConfigurationNode.invalid; locked 66% of time  Unsynchronized access at ConfigurationNode.java:[line 138]

M M IS2_INCONSISTENT_SYNC IS: Inconsistent synchronization of org.apache.ignite.internal.configuration.ConfigurationNode.val; locked 60% of time  Unsynchronized access at ConfigurationNode.java:[line 145]

Fields `val` and `invalid` are accessed in both synchronized and unsynchronized fashion. This can be a source of hard to catch bug.
Investigate whenever this is a false-positive and we should suppress it, or we should make a proper fix.
At the result of investigation corresponding TODO should be removed in spotbugs-excludes.xml

Issue Links

• split from: IGNITE-21569 Introduce Spotbugs checks