Uploaded image for project: 'Ignite'
  1. Ignite
  2. IGNITE-21700

IgniteSort: result of RelOptCost.plus is ignored but it doesn't have side-effects

    XMLWordPrintableJSON

Details

    • Bug
    • Status: Resolved
    • Major
    • Resolution: Fixed
    • None
    • 3.0
    • sql

    Description

      Issue detected by SpotBugs. Specifically the warning reported is:

      H D RV_RETURN_VALUE_IGNORED_NO_SIDE_EFFECT RV: Return value of org.apache.calcite.plan.RelOptCost.plus(RelOptCost) ignored, but method has no side effect  At IgniteSort.java:[line 169] 

      It looks like RelOptCost.plus is side-effect free and it's return result should be used, but it is ignored! It looks like a bug!

      Investigate whenever this is a false-positive and we should suppress it, or make a proper fix.

      At the result of investigation corresponding TODO should be removed in spotbugs-excludes.xml

      Attachments

        Issue Links

          Activity

            People

              Unassigned Unassigned
              vblinov Viacheslav Blinov
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: