[IGNITE-21697] ConnectionManager ignores exceptional return value of ExecutorService.submit

• Type: Task
• Status: Resolved
• Priority: Minor
• Resolution: Duplicate
• Labels: ignite-3 spotbugs
• Ignite Flags: Docs Required, Release Notes Required
• Assignee: Unassigned
• Reporter: Viacheslav Blinov
• Created: 06/Mar/24 16:00
• Updated: 18/Mar/24 06:33
• Resolved: 18/Mar/24 06:32

Description

Issue detected by SpotBugs. Specifically the warning reported is:

M B RV_RETURN_VALUE_IGNORED_BAD_PRACTICE RV: Exceptional return value of java.util.concurrent.ExecutorService.submit(Callable) ignored in org.apache.ignite.internal.network.netty.ConnectionManager.handleNodeLeft(String)  At ConnectionManager.java:[line 603]

If you don't check the result, you won't notice if the method invocation signals unexpected behavior by returning an atypical return value.

Investigate whenever this is a false-positive and we should suppress it, or we should make a proper fix.

At the result of investigation corresponding TODO should be removed in spotbugs-excludes.xml

Issue Links

• duplicates: IGNITE-21696 LazyStripedExecutor performs synchronization on AtomicReferenceArray
• is fixed by: IGNITE-21696 LazyStripedExecutor performs synchronization on AtomicReferenceArray
• split from: IGNITE-21569 Introduce Spotbugs checks