[IGNITE-21699] Sql. DistributionFunction compares strings by reference

• Type: Bug
• Status: Open
• Priority: Minor
• Resolution: Unresolved
• Component/s: sql
• Labels: ignite-3 spotbugs
• Ignite Flags: Docs Required, Release Notes Required
• Assignee: Unassigned
• Reporter: Viacheslav Blinov
• Created: 06/Mar/24 16:08
• Updated: 12/Mar/24 12:12

Description

Issue detected by SpotBugs. Specifically the warning reported is:

M B ES_COMPARING_STRINGS_WITH_EQ ES: Comparison of String objects using == or != in org.apache.ignite.internal.sql.engine.trait.DistributionFunction.equals(Object)  At DistributionFunction.java:[line 76]
M B ES_COMPARING_STRINGS_WITH_EQ ES: Comparison of String objects using == or != in org.apache.ignite.internal.sql.engine.trait.DistributionFunction.satisfy(DistributionFunction, DistributionFunction)  At DistributionFunction.java:[line 117]

This might be wrong.

Investigate whenever this is a false-positive and we should suppress it, or make a proper fix.

At the result of investigation corresponding TODO should be removed in spotbugs-excludes.xml

Issue Links

• split from: IGNITE-21569 Introduce Spotbugs checks