[IGNITE-21706] RandomLruPageReplacementPolicy has dead conditions

• Type: Bug
• Status: Open
• Priority: Minor
• Resolution: Unresolved
• Labels: ignite-3 spotbugs
• Ignite Flags: Docs Required, Release Notes Required
• Assignee: Unassigned
• Reporter: Viacheslav Blinov
• Created: 06/Mar/24 16:19
• Updated: 12/Mar/24 12:13

Description

Issue detected by SpotBugs. Specifically the warning reported is:

H D UC_USELESS_CONDITION UC: Useless condition: it's known that dirty == false at this point  At RandomLruPageReplacementPolicy.java:[line 134] 

I tried to unfold it and ended up removing quite a few lines of dead code and useless conditions which are constant. I'm not sure if this is right and there is no missing implementation there.

Investigate whenever this is a false-positive and we should suppress it, or make a proper fix.

At the result of investigation corresponding TODO should be removed in spotbugs-excludes.xml

Issue Links

• split from: IGNITE-21569 Introduce Spotbugs checks