[IGNITE-21704] ConfigurationListenerHolder uses weird equals implementation

• Type: Bug
• Status: Open
• Priority: Minor
• Resolution: Unresolved
• Labels: ignite-3 spotbugs
• Ignite Flags: Docs Required, Release Notes Required
• Assignee: Unassigned
• Reporter: Viacheslav Blinov
• Created: 06/Mar/24 16:16
• Updated: 12/Mar/24 12:13

Description

Issue detected by SpotBugs. Specifically the warning reported is:

M B BC_EQUALS_METHOD_SHOULD_WORK_FOR_ALL_OBJECTS BC: Equals method for org.apache.ignite.internal.configuration.ConfigurationListenerHolder$1 assumes the argument is of type ConfigurationListenerHolder$1  At ConfigurationListenerHolder.java:[line 56] 
M B NP_EQUALS_SHOULD_HANDLE_NULL_ARGUMENT NP: org.apache.ignite.internal.configuration.ConfigurationListenerHolder$1.equals(Object) does not check for null argument  At ConfigurationListenerHolder.java:[line 56]

Investigate whenever this is a false-positive and we should suppress it, or make a proper fix.

At the result of investigation corresponding TODO should be removed in spotbugs-excludes.xml

Issue Links

• is related to: IGNITE-21705 CheckpointWorkflow uses weird equals implementation
• split from: IGNITE-21569 Introduce Spotbugs checks