[ZOOKEEPER-1198] Refactorings and Cleanups

• Type: Improvement
• Status: Open
• Priority: Major
• Resolution: Unresolved
• Tags: cleanup, cleancode
• Assignee: Thomas Koch
• Reporter: Thomas Koch
• Created: 22/Sep/11 09:00
• Updated: 27/Oct/11 06:41

Description

Umbrella issue for refactorings. I'll post individual refactoring steps as sub-issues. I'll also use this umbrella issue to submit previews of the full refactoring for testing by Jenkins or to ReviewBoard.

Sub-Tasks

• Make OpCode an enum: Open
• Remove obsolete DataTreeBuilder: Resolved
• Clean SaslServerCallbackHandler.java: Closed
• Shorten calls to ZooTrace: Open
• Fix more eclipse compiler warnings, also in Tests: Resolved
• Remove unnecessary MissingSessionException in ZooKeeperServer: Patch Available
• Provide accessors for Request.{hdr|txn}: Resolved
• extract version check in separate method in PrepRequestProcessor: Resolved
• Cleanup SessionTracker: Open
• Cleanup FileTxnLog: Open
• refactor int constants in o.a.z.s.q.Leader to enum: Open
• throw RuntimeExceptions for Exceptions that "should never happen": Open
• basic cleanup in LearnerHandler: Open
• store KeeperException messages in the Code enum: Patch Available
• resolve remaining compiler warnings: Open
• fix compiler warnings in contrib loggraph: Open
• Dead code in PrepRequestProcessor catch Exception block: Closed
• dead code in PrepRequestProcessor.pRequest multi case: Resolved
• multi transaction sets request.exception without reason: Open
• trigger jenkins dummy issue: Resolved
• call checkSession at begin of PrepRequestProcessor.pRequest: Patch Available
• remove unused method o.a.z.test.AxyncTest.restart(): Resolved
• return value of DataTree.createNode is never used: Resolved
• unused fields in DataTree.ProcessTxnResult: Open
• Rename MultiTransactionRecord to MultiRequest: Open
• Move MultiResponse creation out of FinalRequestProcessor: Patch Available
• central mapping from type to txn record class: Open
• "request.getHdr() != null" and "isQuorum" are identical: Open
• closeSession flag in finalRequestProcessor is superfluous: Resolved
• ZKDatabase should not hold reference to FileTxnSnapLog: Open
• Only SessionTracker should hold reference to sessionsWithTimeouts: Open
• Cleanup minor PrepRequestProcessor issues: Patch Available
• QuorumPeer contains unused constructor: Open
• Always log sessionId and zxid as hexadecimals: Open