[ZOOKEEPER-1266] "request.getHdr() != null" and "isQuorum" are identical

• Type: Sub-task
• Status: Open
• Priority: Minor
• Resolution: Unresolved
• Assignee: Thomas Koch
• Reporter: Thomas Koch
• Created: 28/Oct/11 13:58
• Updated: 28/Oct/11 16:52

Description

FinalRequestProcessor has this code block:

            if (request.getHdr() != null) {
               ... SNIP ...
            }
            // do not add non quorum packets to the queue.
            if (request.isQuorum()) {
                zks.getZKDatabase().addCommittedProposal(request);
            }

Both conditions are equivalent so the two if blocks could actually be merged to one block.