Uploaded image for project: 'ZooKeeper'
  1. ZooKeeper
  2. ZOOKEEPER-1198

Refactorings and Cleanups

          Details

          • Type: Improvement
          • Status: Open
          • Priority: Major
          • Resolution: Unresolved
          • Affects Version/s: None
          • Fix Version/s: None
          • Component/s: None
          • Labels:
            None
          • Tags:
            cleanup, cleancode

            Description

            Umbrella issue for refactorings. I'll post individual refactoring steps as sub-issues. I'll also use this umbrella issue to submit previews of the full refactoring for testing by Jenkins or to ReviewBoard.

              Attachments

              1.
              		 Make OpCode an enum Sub-task Open Thomas Koch
              2.
              		 Remove obsolete DataTreeBuilder Sub-task Resolved Thomas Koch
              3.
              		 Clean SaslServerCallbackHandler.java Sub-task Closed Thomas Koch
              4.
              		 Shorten calls to ZooTrace Sub-task Open Thomas Koch
              5.
              		 Fix more eclipse compiler warnings, also in Tests Sub-task Resolved Thomas Koch
              6.
              		 Remove unnecessary MissingSessionException in ZooKeeperServer Sub-task Patch Available Thomas Koch
              7.
              		 Provide accessors for Request.{hdr|txn} Sub-task Resolved Thomas Koch
              8.
              		 extract version check in separate method in PrepRequestProcessor Sub-task Resolved Thomas Koch
              9.
              		 Cleanup SessionTracker Sub-task Open Unassigned
              10.
              		 Cleanup FileTxnLog Sub-task Open Unassigned
              11.
              		 refactor int constants in o.a.z.s.q.Leader to enum Sub-task Open Thomas Koch
              12.
              		 throw RuntimeExceptions for Exceptions that "should never happen" Sub-task Open Unassigned
              13.
              		 basic cleanup in LearnerHandler Sub-task Open Thomas Koch
              14.
              		 store KeeperException messages in the Code enum Sub-task Patch Available Thomas Koch
              15.
              		 resolve remaining compiler warnings Sub-task Open Unassigned
              16.
              		 fix compiler warnings in contrib loggraph Sub-task Open Unassigned
              17.
              		 Dead code in PrepRequestProcessor catch Exception block Sub-task Closed Camille Fournier
              18.
              		 dead code in PrepRequestProcessor.pRequest multi case Sub-task Resolved Thomas Koch
              19.
              		 multi transaction sets request.exception without reason Sub-task Open Thomas Koch
              20.
              		 trigger jenkins dummy issue Sub-task Resolved Thomas Koch
              21.
              		 call checkSession at begin of PrepRequestProcessor.pRequest Sub-task Patch Available Thomas Koch
              22.
              		 remove unused method o.a.z.test.AxyncTest.restart() Sub-task Resolved Thomas Koch
              23.
              		 return value of DataTree.createNode is never used Sub-task Resolved Thomas Koch
              24.
              		 unused fields in DataTree.ProcessTxnResult Sub-task Open Thomas Koch
              25.
              		 Rename MultiTransactionRecord to MultiRequest Sub-task Open Thomas Koch
              26.
              		 Move MultiResponse creation out of FinalRequestProcessor Sub-task Patch Available Thomas Koch
              27.
              		 central mapping from type to txn record class Sub-task Open Thomas Koch
              28.
              		 "request.getHdr() != null" and "isQuorum" are identical Sub-task Open Thomas Koch
              29.
              		 closeSession flag in finalRequestProcessor is superfluous Sub-task Resolved Thomas Koch
              30.
              		 ZKDatabase should not hold reference to FileTxnSnapLog Sub-task Open Thomas Koch
              31.
              		 Only SessionTracker should hold reference to sessionsWithTimeouts Sub-task Open Thomas Koch
              32.
              		 Cleanup minor PrepRequestProcessor issues Sub-task Patch Available Thomas Koch
              33.
              		 QuorumPeer contains unused constructor Sub-task Open Thomas Koch
              34.
              		 Always log sessionId and zxid as hexadecimals Sub-task Open Unassigned

                Activity

                  People

                  • Assignee:
                    thkoch Thomas Koch
                    Reporter:
                    thkoch Thomas Koch
                  • Votes:
                    0 Vote for this issue
                    Watchers:
                    1 Start watching this issue

                    Dates

                    • Created:
                      Updated: