[ZOOKEEPER-1228] Cleanup SessionTracker

• Type: Sub-task
• Status: Open
• Priority: Major
• Resolution: Unresolved
• Assignee: Unassigned
• Reporter: Thomas Koch
• Created: 14/Oct/11 15:10
• Updated: 02/May/13 02:29

Description

• fix ordering of class members
• Remove Interface Session and rename inner class SessionImpl to Session
• make properties private final where possible
• rename SessionTrackerImpl to LeaderSessionTracker. There's a LearnerSessionTracker, so it makes sense.
• make the following code clearer, what does the bitshifting do?

      public static long initializeNextSession(long id) {
          long nextSid = 0;
          nextSid = (System.currentTimeMillis() << 24) >> 8;
          nextSid =  nextSid | (id <<56);
          return nextSid;
      }
  

• replace the inner class SessionSet by a normal Set
• make SessionTrackerImpl an instance of Runnable

Issue Links

• is depended upon by: ZOOKEEPER-1285 make DataTree immutable