Uploaded image for project: 'ZooKeeper'
  1. ZooKeeper
  2. ZOOKEEPER-1198 Refactorings and Cleanups
  3. ZOOKEEPER-1255

unused fields in DataTree.ProcessTxnResult

    XMLWordPrintableJSON

Details

    • Sub-task
    • Status: Open
    • Minor
    • Resolution: Unresolved
    • None
    • None
    • None
    • None

    Description

      The fields zxid, cxid and clientId in ProcessTxnResult are never used. cxid and clientId are used in equals() and hashCode() but the class is never ever used as a key or compared.

      Keeping equals() and hashCode() "just in case" is a bad idea:
      http://www.infoq.com/news/2011/05/less-code-is-better

      Attachments

        1. ZOOKEEPER-1255.patch
          3 kB
          Thomas Koch

        Issue Links

          is depended upon by

          Improvement - An improvement or enhancement to an existing feature or task. ZOOKEEPER-1285 make DataTree immutable

          • Major - Major loss of function.
          • Open

          Activity

            People

              thkoch Thomas Koch
              thkoch Thomas Koch
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

                Created:
                Updated: