Details

    • Type: Bug
    • Status: Open
    • Priority: Major
    • Resolution: Unresolved
    • Affects Version/s: None
    • Fix Version/s: None
    • Component/s: None
    • Labels:
      None

      Description

      -1 overall. Here are the results of testing the latest attachment 
      http://issues.apache.org/jira/secure/attachment/12696401/TAJO-1260_3.patch
      against master revision release-0.9.0-rc0-167-gae7862b.
      +1 @author. The patch does not contain any @author tags.
      +1 tests included. The patch appears to include 12 new or modified test files.
      +1 javac. The applied patch does not increase the total number of javac compiler warnings.
      +1 javadoc. The applied patch does not increase the total number of javadoc warnings.
      +1 checkstyle. The patch generated 0 code style errors.
      -1 findbugs. The patch appears to introduce 212 new Findbugs (version 2.0.3) warnings.
      -1 release audit. The applied patch generated 373 release audit warnings.
      +1 core tests. The patch passed unit tests in tajo-algebra tajo-core tajo-plan.
      Test results: https://builds.apache.org/job/PreCommit-TAJO-Build/584//testReport/
      Release audit warnings: https://builds.apache.org/job/PreCommit-TAJO-Build/584//artifact/incubator-tajo/patchprocess/patchReleaseAuditProblems.txt
      Findbugs warnings: https://builds.apache.org/job/PreCommit-TAJO-Build/584//artifact/incubator-tajo/patchprocess/newPatchFindbugsWarningstajo-plan.html
      Findbugs warnings: https://builds.apache.org/job/PreCommit-TAJO-Build/584//artifact/incubator-tajo/patchprocess/newPatchFindbugsWarningstajo-core.html
      Console output: https://builds.apache.org/job/PreCommit-TAJO-Build/584//console
      This message is automatically generated.
      

      So far, we haven't made much effort to fix findbug errors after we adopt findbugs. Now is the time to concern the quality of source code too.

      This work may take a long time because the number of find bug warnings is more than 200. We need to make sub tasks or new jira for them.

        Attachments

          Issue Links

            Activity

              People

              • Assignee:
                Unassigned
                Reporter:
                hyunsik Hyunsik Choi
              • Votes:
                0 Vote for this issue
                Watchers:
                1 Start watching this issue

                Dates

                • Created:
                  Updated: