Details

    • Type: Sub-task
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.11.0
    • Component/s: SQL Shell
    • Labels:
      None

      Description

      See the title.

      1. TAJO-1393.patch
        5 kB
        Dongjoon Hyun

        Activity

        Hide
        hudson Hudson added a comment -

        SUCCESS: Integrated in Tajo-master-build #622 (See https://builds.apache.org/job/Tajo-master-build/622/)
        TAJO-1393: Resolve findbug warnings on Tajo Cli Module (hyunsik: rev e15ac7e5596ad03aedc1168e422099e1d0ee9a1d)

        • tajo-cli/src/main/java/org/apache/tajo/cli/tools/TajoHAAdmin.java
        • tajo-cli/src/main/java/org/apache/tajo/cli/tsql/DefaultTajoCliOutputFormatter.java
        • tajo-cli/src/main/java/org/apache/tajo/cli/tools/TajoAdmin.java
        • tajo-cli/src/main/java/org/apache/tajo/cli/tsql/TajoCli.java
        • tajo-cli/src/main/java/org/apache/tajo/cli/tsql/SimpleParser.java
        • tajo-cli/src/main/java/org/apache/tajo/cli/tools/TajoGetConf.java
        • CHANGES
        Show
        hudson Hudson added a comment - SUCCESS: Integrated in Tajo-master-build #622 (See https://builds.apache.org/job/Tajo-master-build/622/ ) TAJO-1393 : Resolve findbug warnings on Tajo Cli Module (hyunsik: rev e15ac7e5596ad03aedc1168e422099e1d0ee9a1d) tajo-cli/src/main/java/org/apache/tajo/cli/tools/TajoHAAdmin.java tajo-cli/src/main/java/org/apache/tajo/cli/tsql/DefaultTajoCliOutputFormatter.java tajo-cli/src/main/java/org/apache/tajo/cli/tools/TajoAdmin.java tajo-cli/src/main/java/org/apache/tajo/cli/tsql/TajoCli.java tajo-cli/src/main/java/org/apache/tajo/cli/tsql/SimpleParser.java tajo-cli/src/main/java/org/apache/tajo/cli/tools/TajoGetConf.java CHANGES
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Tajo-master-CODEGEN-build #259 (See https://builds.apache.org/job/Tajo-master-CODEGEN-build/259/)
        TAJO-1393: Resolve findbug warnings on Tajo Cli Module (hyunsik: rev e15ac7e5596ad03aedc1168e422099e1d0ee9a1d)

        • CHANGES
        • tajo-cli/src/main/java/org/apache/tajo/cli/tsql/DefaultTajoCliOutputFormatter.java
        • tajo-cli/src/main/java/org/apache/tajo/cli/tsql/TajoCli.java
        • tajo-cli/src/main/java/org/apache/tajo/cli/tools/TajoGetConf.java
        • tajo-cli/src/main/java/org/apache/tajo/cli/tools/TajoAdmin.java
        • tajo-cli/src/main/java/org/apache/tajo/cli/tsql/SimpleParser.java
        • tajo-cli/src/main/java/org/apache/tajo/cli/tools/TajoHAAdmin.java
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Tajo-master-CODEGEN-build #259 (See https://builds.apache.org/job/Tajo-master-CODEGEN-build/259/ ) TAJO-1393 : Resolve findbug warnings on Tajo Cli Module (hyunsik: rev e15ac7e5596ad03aedc1168e422099e1d0ee9a1d) CHANGES tajo-cli/src/main/java/org/apache/tajo/cli/tsql/DefaultTajoCliOutputFormatter.java tajo-cli/src/main/java/org/apache/tajo/cli/tsql/TajoCli.java tajo-cli/src/main/java/org/apache/tajo/cli/tools/TajoGetConf.java tajo-cli/src/main/java/org/apache/tajo/cli/tools/TajoAdmin.java tajo-cli/src/main/java/org/apache/tajo/cli/tsql/SimpleParser.java tajo-cli/src/main/java/org/apache/tajo/cli/tools/TajoHAAdmin.java
        Hide
        githubbot ASF GitHub Bot added a comment -

        Github user dongjoon-hyun commented on the pull request:

        https://github.com/apache/tajo/pull/417#issuecomment-83855849

        Thanks, @hyunsik

        Show
        githubbot ASF GitHub Bot added a comment - Github user dongjoon-hyun commented on the pull request: https://github.com/apache/tajo/pull/417#issuecomment-83855849 Thanks, @hyunsik
        Hide
        hyunsik Hyunsik Choi added a comment -

        committed.

        Show
        hyunsik Hyunsik Choi added a comment - committed.
        Hide
        githubbot ASF GitHub Bot added a comment -

        Github user asfgit closed the pull request at:

        https://github.com/apache/tajo/pull/417

        Show
        githubbot ASF GitHub Bot added a comment - Github user asfgit closed the pull request at: https://github.com/apache/tajo/pull/417
        Hide
        githubbot ASF GitHub Bot added a comment -

        Github user hyunsik commented on the pull request:

        https://github.com/apache/tajo/pull/417#issuecomment-83797421

        The patch looks good to me. I'll finish the review when CI is completed.

        Show
        githubbot ASF GitHub Bot added a comment - Github user hyunsik commented on the pull request: https://github.com/apache/tajo/pull/417#issuecomment-83797421 The patch looks good to me. I'll finish the review when CI is completed.
        Hide
        githubbot ASF GitHub Bot added a comment -

        Github user dongjoon-hyun commented on the pull request:

        https://github.com/apache/tajo/pull/417#issuecomment-83574760

        I've done and the followings are passed.
        cd tajo-cli; mvn compile findbugs:findbugs
        mvn clean install -Pparallel-test,hcatalog-0.12.0 -DLOG_LEVEL=ERROR -Dmaven.fork.count=2

        Show
        githubbot ASF GitHub Bot added a comment - Github user dongjoon-hyun commented on the pull request: https://github.com/apache/tajo/pull/417#issuecomment-83574760 I've done and the followings are passed. cd tajo-cli; mvn compile findbugs:findbugs mvn clean install -Pparallel-test,hcatalog-0.12.0 -DLOG_LEVEL=ERROR -Dmaven.fork.count=2
        Hide
        githubbot ASF GitHub Bot added a comment -

        Github user dongjoon-hyun commented on the pull request:

        https://github.com/apache/tajo/pull/417#issuecomment-83557106

        Thank you. I will rebase and remove them.

        Show
        githubbot ASF GitHub Bot added a comment - Github user dongjoon-hyun commented on the pull request: https://github.com/apache/tajo/pull/417#issuecomment-83557106 Thank you. I will rebase and remove them.
        Hide
        githubbot ASF GitHub Bot added a comment -

        Github user hyunsik commented on the pull request:

        https://github.com/apache/tajo/pull/417#issuecomment-83442056

        I leave some comments. TajoHAAdmin seems to need refactoring. Its code is somewhat messy.

        Show
        githubbot ASF GitHub Bot added a comment - Github user hyunsik commented on the pull request: https://github.com/apache/tajo/pull/417#issuecomment-83442056 I leave some comments. TajoHAAdmin seems to need refactoring. Its code is somewhat messy.
        Hide
        githubbot ASF GitHub Bot added a comment -

        Github user hyunsik commented on a diff in the pull request:

        https://github.com/apache/tajo/pull/417#discussion_r26739002

        — Diff: tajo-cli/src/main/java/org/apache/tajo/cli/tools/TajoHAAdmin.java —
        @@ -131,6 +131,9 @@ public void runCommand(String[] args) throws Exception {
        } else if (hostName == null && port == null)

        { tajoClient = new TajoClientImpl(ServiceTrackerFactory.get(tajoConf)); }

        + if (!tajoClient.isConnected()) {
        — End diff –

        I think that this class also does not require TajoClient connection. Removing TajoClient would be a better solution to fix 'unused field' warning.

        Show
        githubbot ASF GitHub Bot added a comment - Github user hyunsik commented on a diff in the pull request: https://github.com/apache/tajo/pull/417#discussion_r26739002 — Diff: tajo-cli/src/main/java/org/apache/tajo/cli/tools/TajoHAAdmin.java — @@ -131,6 +131,9 @@ public void runCommand(String[] args) throws Exception { } else if (hostName == null && port == null) { tajoClient = new TajoClientImpl(ServiceTrackerFactory.get(tajoConf)); } + if (!tajoClient.isConnected()) { — End diff – I think that this class also does not require TajoClient connection. Removing TajoClient would be a better solution to fix 'unused field' warning.
        Hide
        githubbot ASF GitHub Bot added a comment -

        Github user hyunsik commented on a diff in the pull request:

        https://github.com/apache/tajo/pull/417#discussion_r26738649

        — Diff: tajo-cli/src/main/java/org/apache/tajo/cli/tools/TajoGetConf.java —
        @@ -119,6 +119,9 @@ public void runCommand(String[] args, boolean tsqlMode) throws Exception {
        } else if (hostName == null && port == null)

        { tajoClient = new TajoClientImpl(ServiceTrackerFactory.get(tajoConf)); }

        + if (!tajoClient.isConnected()) {
        — End diff –

        Actually, this class does not need TajoClient. I think that removing tajoClient is a better solution. So, you don't need the below ``System.out.print`` statement.

        Show
        githubbot ASF GitHub Bot added a comment - Github user hyunsik commented on a diff in the pull request: https://github.com/apache/tajo/pull/417#discussion_r26738649 — Diff: tajo-cli/src/main/java/org/apache/tajo/cli/tools/TajoGetConf.java — @@ -119,6 +119,9 @@ public void runCommand(String[] args, boolean tsqlMode) throws Exception { } else if (hostName == null && port == null) { tajoClient = new TajoClientImpl(ServiceTrackerFactory.get(tajoConf)); } + if (!tajoClient.isConnected()) { — End diff – Actually, this class does not need TajoClient. I think that removing tajoClient is a better solution. So, you don't need the below ``System.out.print`` statement.
        Hide
        githubbot ASF GitHub Bot added a comment -

        Github user dongjoon-hyun commented on the pull request:

        https://github.com/apache/tajo/pull/417#issuecomment-83228997

        Hi, Travis CI build is done~

        Show
        githubbot ASF GitHub Bot added a comment - Github user dongjoon-hyun commented on the pull request: https://github.com/apache/tajo/pull/417#issuecomment-83228997 Hi, Travis CI build is done~
        Hide
        hyunsik Hyunsik Choi added a comment -

        Of course, I will. BTW, Nested schema issue will take much time to clean up and refactor some changes.

        Thanks,
        Hyunsik

        Show
        hyunsik Hyunsik Choi added a comment - Of course, I will. BTW, Nested schema issue will take much time to clean up and refactor some changes. Thanks, Hyunsik
        Hide
        dongjoon Dongjoon Hyun added a comment -

        Hi, Hyunsik Choi, I know you are very busy due to nested schema issue recently. I think that will cause a huge change in many files.

        Could you sqeeze this issue in before that change? This is very trivial patch with 13 insertions, 9 deletions to remove findbugs warnings.

        By the way, a few minutes ago, I tested again by merging current master branch and it merged without any problem. If there is anything to do more, please let me know.

        Best regards,
        Dongjoon

        Show
        dongjoon Dongjoon Hyun added a comment - Hi, Hyunsik Choi , I know you are very busy due to nested schema issue recently. I think that will cause a huge change in many files. Could you sqeeze this issue in before that change? This is very trivial patch with 13 insertions , 9 deletions to remove findbugs warnings. By the way, a few minutes ago, I tested again by merging current master branch and it merged without any problem. If there is anything to do more, please let me know. Best regards, Dongjoon
        Hide
        tajoqa Tajo QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12704329/TAJO-1393.patch
        against master revision release-0.9.0-rc0-200-gf48d4bd.

        +1 @author. The patch does not contain any @author tags.

        -1 tests included. The patch doesn't appear to include any new or modified tests.
        Please justify why no new tests are needed for this patch.
        Also please list what manual steps were performed to verify this patch.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 javadoc. The applied patch does not increase the total number of javadoc warnings.

        +1 checkstyle. The patch generated 0 code style errors.

        +1 findbugs. The patch does not introduce any new Findbugs (version 2.0.3) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 core tests. The patch passed unit tests in tajo-cli.

        Test results: https://builds.apache.org/job/PreCommit-TAJO-Build/612//testReport/
        Console output: https://builds.apache.org/job/PreCommit-TAJO-Build/612//console

        This message is automatically generated.

        Show
        tajoqa Tajo QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12704329/TAJO-1393.patch against master revision release-0.9.0-rc0-200-gf48d4bd. +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 javadoc. The applied patch does not increase the total number of javadoc warnings. +1 checkstyle. The patch generated 0 code style errors. +1 findbugs. The patch does not introduce any new Findbugs (version 2.0.3) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed unit tests in tajo-cli. Test results: https://builds.apache.org/job/PreCommit-TAJO-Build/612//testReport/ Console output: https://builds.apache.org/job/PreCommit-TAJO-Build/612//console This message is automatically generated.
        Hide
        githubbot ASF GitHub Bot added a comment -

        GitHub user dongjoon-hyun opened a pull request:

        https://github.com/apache/tajo/pull/417

        TAJO-1393: Resolve findbug warnings on Tajo Cli Module

        Pass the following two steps.

        • cd tajo-cli; mvn compile findbugs:findbugs
        • mvn clean install -Pdist -Dtar -Dhadoop.version2.6.0

        You can merge this pull request into a Git repository by running:

        $ git pull https://github.com/dongjoon-hyun/tajo TAJO-1393

        Alternatively you can review and apply these changes as the patch at:

        https://github.com/apache/tajo/pull/417.patch

        To close this pull request, make a commit to your master/trunk branch
        with (at least) the following in the commit message:

        This closes #417


        commit 630ffcae65b52b45bc225c39fc8ac013270083ec
        Author: Dongjoon Hyun <dongjoon@apache.org>
        Date: 2015-03-13T00:56:46Z

        TAJO-1393: Resolve findbug warnings on Tajo Cli Module


        Show
        githubbot ASF GitHub Bot added a comment - GitHub user dongjoon-hyun opened a pull request: https://github.com/apache/tajo/pull/417 TAJO-1393 : Resolve findbug warnings on Tajo Cli Module Pass the following two steps. cd tajo-cli; mvn compile findbugs:findbugs mvn clean install -Pdist -Dtar -Dhadoop.version2.6.0 You can merge this pull request into a Git repository by running: $ git pull https://github.com/dongjoon-hyun/tajo TAJO-1393 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/tajo/pull/417.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #417 commit 630ffcae65b52b45bc225c39fc8ac013270083ec Author: Dongjoon Hyun <dongjoon@apache.org> Date: 2015-03-13T00:56:46Z TAJO-1393 : Resolve findbug warnings on Tajo Cli Module

          People

          • Assignee:
            dongjoon Dongjoon Hyun
            Reporter:
            hyunsik Hyunsik Choi
          • Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development