GitHub user dongjoon-hyun opened a pull request:

https://github.com/apache/tajo/pull/447

TAJO-1437: Resolve findbug warnings on Tajo JDBC Module

• Performance: Replace 'new String("UDF")' into 'private static final String'.
• Bugfix: execute() saves the result set, now.
• Unused variable: warningChain is defined but always set to null.
• Standard compliance: raise SQLException on operation with a closed connection

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/dongjoon-hyun/tajo TAJO-1437

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/tajo/pull/447.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #447

commit 779591fd9d8ccc248429df293b9d2d9c2d545c82
Author: Dongjoon Hyun <dongjoon@apache.org>
Date: 2015-03-22T12:22:30Z

TAJO-1437: Resolve findbug warnings on Tajo JDBC Module

Github user dongjoon-hyun commented on the pull request:

https://github.com/apache/tajo/pull/447#issuecomment-84598836

It passed the following command.
```
mvn clean install -Pparallel-test,hcatalog-0.12.0 -DLOG_LEVEL=INFO -Dmaven.fork.count=2 > TAJO-1437.travis.log.INFO.txt
```
Result is here. https://app.box.com/s/07oenp32etnrhgwygoq6yz213lnubzpc (72MB)

-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12706383/TAJO-1437.patch
against master revision release-0.9.0-rc0-213-g3aaff38.

+1 @author. The patch does not contain any @author tags.

-1 tests included. The patch doesn't appear to include any new or modified tests.
Please justify why no new tests are needed for this patch.
Also please list what manual steps were performed to verify this patch.

+1 javac. The applied patch does not increase the total number of javac compiler warnings.

+1 javadoc. The applied patch does not increase the total number of javadoc warnings.

+1 checkstyle. The patch generated 0 code style errors.

+1 findbugs. The patch does not introduce any new Findbugs (version 2.0.3) warnings.

+1 release audit. The applied patch does not increase the total number of release audit warnings.

+1 core tests. The patch passed unit tests in tajo-jdbc.

Test results: https://builds.apache.org/job/PreCommit-TAJO-Build/634//testReport/
Console output: https://builds.apache.org/job/PreCommit-TAJO-Build/634//console

This message is automatically generated.

Github user dongjoon-hyun commented on the pull request:

https://github.com/apache/tajo/pull/447#issuecomment-85829082

Rebased.

Github user jihoonson commented on the pull request:

https://github.com/apache/tajo/pull/447#issuecomment-87404772

+1

Github user asfgit closed the pull request at:

https://github.com/apache/tajo/pull/447

Committed to the 0.10.1 and master branches.
Thanks for your contribution.

ABORTED: Integrated in Tajo-master-CODEGEN-build #274 (See https://builds.apache.org/job/Tajo-master-CODEGEN-build/274/)
TAJO-1437: Resolve findbug warnings on Tajo JDBC Module. (jihoonson: rev 7f7759331a9ac0e6513c5870ef9127218da1360f)

• CHANGES
• tajo-jdbc/src/main/java/org/apache/tajo/jdbc/TajoStatement.java
• tajo-jdbc/src/main/java/org/apache/tajo/jdbc/TajoDatabaseMetaData.java
• tajo-jdbc/src/main/java/org/apache/tajo/jdbc/TajoPreparedStatement.java

SUCCESS: Integrated in Tajo-master-build #637 (See https://builds.apache.org/job/Tajo-master-build/637/)
TAJO-1437: Resolve findbug warnings on Tajo JDBC Module. (jihoonson: rev 7f7759331a9ac0e6513c5870ef9127218da1360f)

• tajo-jdbc/src/main/java/org/apache/tajo/jdbc/TajoStatement.java
• CHANGES
• tajo-jdbc/src/main/java/org/apache/tajo/jdbc/TajoPreparedStatement.java
• tajo-jdbc/src/main/java/org/apache/tajo/jdbc/TajoDatabaseMetaData.java