Details

    • Type: Sub-task
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 0.11.0
    • Fix Version/s: 0.11.0
    • Component/s: None
    • Labels:
      None

      Description

      This subtask will clean up findbugs warnings on catalog common, catalog client, catalog drivers, and catalog server.

        Activity

        Hide
        githubbot ASF GitHub Bot added a comment -

        GitHub user ykrips opened a pull request:

        https://github.com/apache/tajo/pull/387

        TAJO-1357: Resolve findbugs warnings on Tajo Catalog Modules

        You can merge this pull request into a Git repository by running:

        $ git pull https://github.com/ykrips/tajo TAJO-1357

        Alternatively you can review and apply these changes as the patch at:

        https://github.com/apache/tajo/pull/387.patch

        To close this pull request, make a commit to your master/trunk branch
        with (at least) the following in the commit message:

        This closes #387


        commit e6337f324e1a84708de5bfa72ac77e13039b6d3e
        Author: Jihun Kang <jihun@apache.org>
        Date: 2015-02-23T13:31:42Z

        Removed findbugs warnings


        Show
        githubbot ASF GitHub Bot added a comment - GitHub user ykrips opened a pull request: https://github.com/apache/tajo/pull/387 TAJO-1357 : Resolve findbugs warnings on Tajo Catalog Modules You can merge this pull request into a Git repository by running: $ git pull https://github.com/ykrips/tajo TAJO-1357 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/tajo/pull/387.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #387 commit e6337f324e1a84708de5bfa72ac77e13039b6d3e Author: Jihun Kang <jihun@apache.org> Date: 2015-02-23T13:31:42Z Removed findbugs warnings
        Hide
        githubbot ASF GitHub Bot added a comment -

        Github user jinossy commented on the pull request:

        https://github.com/apache/tajo/pull/387#issuecomment-75685062

        Could you upload the patch to jira? Because TajoQA can execute findbug

        Show
        githubbot ASF GitHub Bot added a comment - Github user jinossy commented on the pull request: https://github.com/apache/tajo/pull/387#issuecomment-75685062 Could you upload the patch to jira? Because TajoQA can execute findbug
        Hide
        githubbot ASF GitHub Bot added a comment -

        Github user ykrips commented on the pull request:

        https://github.com/apache/tajo/pull/387#issuecomment-75686355

        Sure. No problems.

        Show
        githubbot ASF GitHub Bot added a comment - Github user ykrips commented on the pull request: https://github.com/apache/tajo/pull/387#issuecomment-75686355 Sure. No problems.
        Hide
        tajoqa Tajo QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12700313/TAJO-1357.patch
        against master revision release-0.9.0-rc0-177-gfa20b65.

        +1 @author. The patch does not contain any @author tags.

        -1 tests included. The patch doesn't appear to include any new or modified tests.
        Please justify why no new tests are needed for this patch.
        Also please list what manual steps were performed to verify this patch.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 javadoc. The applied patch does not increase the total number of javadoc warnings.

        +1 checkstyle. The patch generated 0 code style errors.

        +1 findbugs. The patch does not introduce any new Findbugs (version 2.0.3) warnings.

        -1 release audit. The applied patch generated 888 release audit warnings.

        +1 core tests. The patch passed unit tests in tajo-catalog/tajo-catalog-server.

        Test results: https://builds.apache.org/job/PreCommit-TAJO-Build/587//testReport/
        Release audit warnings: https://builds.apache.org/job/PreCommit-TAJO-Build/587//artifact/incubator-tajo/patchprocess/patchReleaseAuditProblems.txt
        Console output: https://builds.apache.org/job/PreCommit-TAJO-Build/587//console

        This message is automatically generated.

        Show
        tajoqa Tajo QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12700313/TAJO-1357.patch against master revision release-0.9.0-rc0-177-gfa20b65. +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 javadoc. The applied patch does not increase the total number of javadoc warnings. +1 checkstyle. The patch generated 0 code style errors. +1 findbugs. The patch does not introduce any new Findbugs (version 2.0.3) warnings. -1 release audit. The applied patch generated 888 release audit warnings. +1 core tests. The patch passed unit tests in tajo-catalog/tajo-catalog-server. Test results: https://builds.apache.org/job/PreCommit-TAJO-Build/587//testReport/ Release audit warnings: https://builds.apache.org/job/PreCommit-TAJO-Build/587//artifact/incubator-tajo/patchprocess/patchReleaseAuditProblems.txt Console output: https://builds.apache.org/job/PreCommit-TAJO-Build/587//console This message is automatically generated.
        Hide
        githubbot ASF GitHub Bot added a comment -

        Github user jinossy commented on the pull request:

        https://github.com/apache/tajo/pull/387#issuecomment-75696014

        +1
        LGTM!

        Show
        githubbot ASF GitHub Bot added a comment - Github user jinossy commented on the pull request: https://github.com/apache/tajo/pull/387#issuecomment-75696014 +1 LGTM!
        Hide
        githubbot ASF GitHub Bot added a comment -

        Github user ykrips commented on the pull request:

        https://github.com/apache/tajo/pull/387#issuecomment-75696395

        Thank you for quick review. This commit will upload into master branch.

        Show
        githubbot ASF GitHub Bot added a comment - Github user ykrips commented on the pull request: https://github.com/apache/tajo/pull/387#issuecomment-75696395 Thank you for quick review. This commit will upload into master branch.
        Hide
        githubbot ASF GitHub Bot added a comment -

        Github user asfgit closed the pull request at:

        https://github.com/apache/tajo/pull/387

        Show
        githubbot ASF GitHub Bot added a comment - Github user asfgit closed the pull request at: https://github.com/apache/tajo/pull/387
        Hide
        hudson Hudson added a comment -

        SUCCESS: Integrated in Tajo-master-build #590 (See https://builds.apache.org/job/Tajo-master-build/590/)
        TAJO-1357: Resolve findbugs warnings on Tajo Catalog Modules (jihun: rev d769d7872dddf16c9e7618ecb8f69c4299f5e3bd)

        • tajo-catalog/tajo-catalog-server/src/main/java/org/apache/tajo/catalog/store/MemStore.java
        • tajo-catalog/tajo-catalog-server/src/main/java/org/apache/tajo/catalog/store/DerbyStore.java
        • tajo-catalog/tajo-catalog-server/src/main/java/org/apache/tajo/catalog/store/XMLCatalogSchemaManager.java
        • CHANGES
        • tajo-catalog/tajo-catalog-server/src/main/java/org/apache/tajo/catalog/store/object/BaseSchema.java
        • tajo-catalog/tajo-catalog-server/src/main/java/org/apache/tajo/catalog/store/object/DatabaseObject.java
        • tajo-catalog/tajo-catalog-server/src/main/java/org/apache/tajo/catalog/store/object/SchemaPatch.java
        Show
        hudson Hudson added a comment - SUCCESS: Integrated in Tajo-master-build #590 (See https://builds.apache.org/job/Tajo-master-build/590/ ) TAJO-1357 : Resolve findbugs warnings on Tajo Catalog Modules (jihun: rev d769d7872dddf16c9e7618ecb8f69c4299f5e3bd) tajo-catalog/tajo-catalog-server/src/main/java/org/apache/tajo/catalog/store/MemStore.java tajo-catalog/tajo-catalog-server/src/main/java/org/apache/tajo/catalog/store/DerbyStore.java tajo-catalog/tajo-catalog-server/src/main/java/org/apache/tajo/catalog/store/XMLCatalogSchemaManager.java CHANGES tajo-catalog/tajo-catalog-server/src/main/java/org/apache/tajo/catalog/store/object/BaseSchema.java tajo-catalog/tajo-catalog-server/src/main/java/org/apache/tajo/catalog/store/object/DatabaseObject.java tajo-catalog/tajo-catalog-server/src/main/java/org/apache/tajo/catalog/store/object/SchemaPatch.java
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Tajo-master-CODEGEN-build #229 (See https://builds.apache.org/job/Tajo-master-CODEGEN-build/229/)
        TAJO-1357: Resolve findbugs warnings on Tajo Catalog Modules (jihun: rev d769d7872dddf16c9e7618ecb8f69c4299f5e3bd)

        • tajo-catalog/tajo-catalog-server/src/main/java/org/apache/tajo/catalog/store/object/SchemaPatch.java
        • tajo-catalog/tajo-catalog-server/src/main/java/org/apache/tajo/catalog/store/object/BaseSchema.java
        • tajo-catalog/tajo-catalog-server/src/main/java/org/apache/tajo/catalog/store/DerbyStore.java
        • CHANGES
        • tajo-catalog/tajo-catalog-server/src/main/java/org/apache/tajo/catalog/store/object/DatabaseObject.java
        • tajo-catalog/tajo-catalog-server/src/main/java/org/apache/tajo/catalog/store/XMLCatalogSchemaManager.java
        • tajo-catalog/tajo-catalog-server/src/main/java/org/apache/tajo/catalog/store/MemStore.java
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Tajo-master-CODEGEN-build #229 (See https://builds.apache.org/job/Tajo-master-CODEGEN-build/229/ ) TAJO-1357 : Resolve findbugs warnings on Tajo Catalog Modules (jihun: rev d769d7872dddf16c9e7618ecb8f69c4299f5e3bd) tajo-catalog/tajo-catalog-server/src/main/java/org/apache/tajo/catalog/store/object/SchemaPatch.java tajo-catalog/tajo-catalog-server/src/main/java/org/apache/tajo/catalog/store/object/BaseSchema.java tajo-catalog/tajo-catalog-server/src/main/java/org/apache/tajo/catalog/store/DerbyStore.java CHANGES tajo-catalog/tajo-catalog-server/src/main/java/org/apache/tajo/catalog/store/object/DatabaseObject.java tajo-catalog/tajo-catalog-server/src/main/java/org/apache/tajo/catalog/store/XMLCatalogSchemaManager.java tajo-catalog/tajo-catalog-server/src/main/java/org/apache/tajo/catalog/store/MemStore.java

          People

          • Assignee:
            ykrips Jihun Kang
            Reporter:
            ykrips Jihun Kang
          • Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development