Details

    • Type: Sub-task
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 0.10.0
    • Fix Version/s: 0.10.1
    • Component/s: Java Client
    • Labels:
      None
    1. TAJO-1438.patch
      0.6 kB
      Dongjoon Hyun

      Issue Links

        Activity

        Hide
        githubbot ASF GitHub Bot added a comment -

        GitHub user dongjoon-hyun opened a pull request:

        https://github.com/apache/tajo/pull/445

        TAJO-1438: Resolve findbug warnings on Tajo Client Module

        Tested only
        mvn clean install -Pdist -Dhadoop.version=2.6.0 -DskipTests
        cd tajo-client; mvn compile findbugs:findbugs

        It's trivial, but I will rebase and test again as soon as the master branch comes back from the build break.

        You can merge this pull request into a Git repository by running:

        $ git pull https://github.com/dongjoon-hyun/tajo TAJO-1438

        Alternatively you can review and apply these changes as the patch at:

        https://github.com/apache/tajo/pull/445.patch

        To close this pull request, make a commit to your master/trunk branch
        with (at least) the following in the commit message:

        This closes #445


        commit a3dbfca0fde5f68e179b6f91722ba746d212f048
        Author: Dongjoon Hyun <dongjoon@apache.org>
        Date: 2015-03-22T02:16:20Z

        TAJO-1438: Resolve findbug warnings on Tajo Client Module


        Show
        githubbot ASF GitHub Bot added a comment - GitHub user dongjoon-hyun opened a pull request: https://github.com/apache/tajo/pull/445 TAJO-1438 : Resolve findbug warnings on Tajo Client Module Tested only mvn clean install -Pdist -Dhadoop.version=2.6.0 -DskipTests cd tajo-client; mvn compile findbugs:findbugs It's trivial, but I will rebase and test again as soon as the master branch comes back from the build break. You can merge this pull request into a Git repository by running: $ git pull https://github.com/dongjoon-hyun/tajo TAJO-1438 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/tajo/pull/445.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #445 commit a3dbfca0fde5f68e179b6f91722ba746d212f048 Author: Dongjoon Hyun <dongjoon@apache.org> Date: 2015-03-22T02:16:20Z TAJO-1438 : Resolve findbug warnings on Tajo Client Module
        Hide
        tajoqa Tajo QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12706364/TAJO-1438.patch
        against master revision release-0.9.0-rc0-213-g3aaff38.

        +1 @author. The patch does not contain any @author tags.

        -1 tests included. The patch doesn't appear to include any new or modified tests.
        Please justify why no new tests are needed for this patch.
        Also please list what manual steps were performed to verify this patch.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 javadoc. The applied patch does not increase the total number of javadoc warnings.

        +1 checkstyle. The patch generated 0 code style errors.

        +1 findbugs. The patch does not introduce any new Findbugs (version 2.0.3) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 core tests. The patch passed unit tests in tajo-client.

        Test results: https://builds.apache.org/job/PreCommit-TAJO-Build/632//testReport/
        Console output: https://builds.apache.org/job/PreCommit-TAJO-Build/632//console

        This message is automatically generated.

        Show
        tajoqa Tajo QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12706364/TAJO-1438.patch against master revision release-0.9.0-rc0-213-g3aaff38. +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 javadoc. The applied patch does not increase the total number of javadoc warnings. +1 checkstyle. The patch generated 0 code style errors. +1 findbugs. The patch does not introduce any new Findbugs (version 2.0.3) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed unit tests in tajo-client. Test results: https://builds.apache.org/job/PreCommit-TAJO-Build/632//testReport/ Console output: https://builds.apache.org/job/PreCommit-TAJO-Build/632//console This message is automatically generated.
        Hide
        githubbot ASF GitHub Bot added a comment -

        Github user dongjoon-hyun commented on the pull request:

        https://github.com/apache/tajo/pull/445#issuecomment-84575414

        It passed. ( Please refer https://issues.apache.org/jira/browse/TAJO-1440 )
        ```
        mvn clean install -Pparallel-test,hcatalog-0.12.0 -DLOG_LEVEL=INFO -Dmaven.fork.count=2
        ```

        Show
        githubbot ASF GitHub Bot added a comment - Github user dongjoon-hyun commented on the pull request: https://github.com/apache/tajo/pull/445#issuecomment-84575414 It passed. ( Please refer https://issues.apache.org/jira/browse/TAJO-1440 ) ``` mvn clean install -Pparallel-test,hcatalog-0.12.0 -DLOG_LEVEL=INFO -Dmaven.fork.count=2 ```
        Hide
        githubbot ASF GitHub Bot added a comment -

        Github user dongjoon-hyun commented on the pull request:

        https://github.com/apache/tajo/pull/445#issuecomment-85829236

        Rebased.

        Show
        githubbot ASF GitHub Bot added a comment - Github user dongjoon-hyun commented on the pull request: https://github.com/apache/tajo/pull/445#issuecomment-85829236 Rebased.
        Hide
        githubbot ASF GitHub Bot added a comment -

        Github user jihoonson commented on the pull request:

        https://github.com/apache/tajo/pull/445#issuecomment-87404193

        +1

        Show
        githubbot ASF GitHub Bot added a comment - Github user jihoonson commented on the pull request: https://github.com/apache/tajo/pull/445#issuecomment-87404193 +1
        Hide
        githubbot ASF GitHub Bot added a comment -

        Github user asfgit closed the pull request at:

        https://github.com/apache/tajo/pull/445

        Show
        githubbot ASF GitHub Bot added a comment - Github user asfgit closed the pull request at: https://github.com/apache/tajo/pull/445
        Hide
        jihoonson Jihoon Son added a comment -

        Committed to the master branch.
        Thanks for your contribution.

        Show
        jihoonson Jihoon Son added a comment - Committed to the master branch. Thanks for your contribution.
        Hide
        hudson Hudson added a comment -

        ABORTED: Integrated in Tajo-master-CODEGEN-build #273 (See https://builds.apache.org/job/Tajo-master-CODEGEN-build/273/)
        TAJO-1438: Resolve findbug warnings on Tajo Client Module (jihoonson: rev 5c89130bac8229b0a51efcd6edb3dfe29682cec9)

        • CHANGES
        • tajo-client/src/main/java/org/apache/tajo/client/SessionConnection.java
        Show
        hudson Hudson added a comment - ABORTED: Integrated in Tajo-master-CODEGEN-build #273 (See https://builds.apache.org/job/Tajo-master-CODEGEN-build/273/ ) TAJO-1438 : Resolve findbug warnings on Tajo Client Module (jihoonson: rev 5c89130bac8229b0a51efcd6edb3dfe29682cec9) CHANGES tajo-client/src/main/java/org/apache/tajo/client/SessionConnection.java
        Hide
        hudson Hudson added a comment -

        SUCCESS: Integrated in Tajo-master-build #636 (See https://builds.apache.org/job/Tajo-master-build/636/)
        TAJO-1438: Resolve findbug warnings on Tajo Client Module (jihoonson: rev 5c89130bac8229b0a51efcd6edb3dfe29682cec9)

        • CHANGES
        • tajo-client/src/main/java/org/apache/tajo/client/SessionConnection.java
        Show
        hudson Hudson added a comment - SUCCESS: Integrated in Tajo-master-build #636 (See https://builds.apache.org/job/Tajo-master-build/636/ ) TAJO-1438 : Resolve findbug warnings on Tajo Client Module (jihoonson: rev 5c89130bac8229b0a51efcd6edb3dfe29682cec9) CHANGES tajo-client/src/main/java/org/apache/tajo/client/SessionConnection.java

          People

          • Assignee:
            dongjoon Dongjoon Hyun
            Reporter:
            dongjoon Dongjoon Hyun
          • Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development