Details

    • Type: Sub-task
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 0.11.0
    • Fix Version/s: 0.11.0
    • Component/s: Planner/Optimizer
    • Labels:
      None

      Description

      See the title.

      1. TAJO-1392.1.patch
        45 kB
        Jihun Kang
      2. TAJO-1392.patch
        45 kB
        Jihun Kang

        Activity

        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Tajo-master-CODEGEN-build #261 (See https://builds.apache.org/job/Tajo-master-CODEGEN-build/261/)
        TAJO-1392: Resolve findbug warnings on Tajo Plan Module (jihun: rev 154f5b9e1c619ce4327aa055fb3ef02d6030fc0d)

        • tajo-plan/src/main/java/org/apache/tajo/plan/verifier/PreLogicalPlanVerifier.java
        • tajo-plan/src/main/java/org/apache/tajo/plan/logical/SelectionNode.java
        • tajo-plan/src/main/java/org/apache/tajo/plan/logical/DistinctGroupbyNode.java
        • tajo-plan/src/main/java/org/apache/tajo/plan/expr/IsNullEval.java
        • tajo-plan/src/main/java/org/apache/tajo/plan/logical/ShuffleFileWriteNode.java
        • tajo-plan/src/main/java/org/apache/tajo/plan/logical/LimitNode.java
        • tajo-plan/src/main/java/org/apache/tajo/plan/ExprAnnotator.java
        • tajo-plan/src/main/java/org/apache/tajo/plan/expr/AlgebraicUtil.java
        • tajo-plan/src/main/java/org/apache/tajo/plan/expr/RegexPredicateEval.java
        • tajo-plan/src/main/java/org/apache/tajo/plan/visitor/BasicLogicalPlanVisitor.java
        • tajo-plan/src/main/java/org/apache/tajo/plan/nameresolver/NameResolver.java
        • CHANGES
        • tajo-plan/src/main/java/org/apache/tajo/plan/expr/AggregationFunctionCallEval.java
        • tajo-plan/src/main/java/org/apache/tajo/plan/logical/EvalExprNode.java
        • tajo-plan/src/main/java/org/apache/tajo/plan/logical/InsertNode.java
        • tajo-plan/src/main/java/org/apache/tajo/plan/expr/WindowFunctionEval.java
        • tajo-plan/src/main/java/org/apache/tajo/plan/logical/GroupbyNode.java
        • tajo-plan/src/main/java/org/apache/tajo/plan/logical/StoreTableNode.java
        • tajo-plan/src/main/java/org/apache/tajo/plan/logical/SortNode.java
        • tajo-plan/src/main/java/org/apache/tajo/plan/logical/LogicalNode.java
        • tajo-plan/src/main/java/org/apache/tajo/plan/logical/PersistentStoreNode.java
        • tajo-plan/src/main/java/org/apache/tajo/plan/expr/InEval.java
        • tajo-plan/src/main/java/org/apache/tajo/plan/expr/PartialBinaryExpr.java
        • tajo-plan/src/main/java/org/apache/tajo/plan/rewrite/rules/FilterPushDownRule.java
        • tajo-plan/src/main/java/org/apache/tajo/plan/expr/EvalTreeUtil.java
        • tajo-plan/src/main/java/org/apache/tajo/plan/expr/BetweenPredicateEval.java
        • tajo-plan/src/main/java/org/apache/tajo/plan/verifier/LogicalPlanVerifier.java
        • tajo-plan/src/main/java/org/apache/tajo/plan/joinorder/GreedyHeuristicJoinOrderAlgorithm.java
        • tajo-plan/src/main/java/org/apache/tajo/plan/logical/HavingNode.java
        • tajo-plan/src/main/java/org/apache/tajo/plan/expr/CaseWhenEval.java
        • tajo-plan/src/main/java/org/apache/tajo/plan/logical/IndexScanNode.java
        • tajo-plan/src/main/java/org/apache/tajo/plan/logical/ProjectionNode.java
        • tajo-plan/src/main/java/org/apache/tajo/plan/expr/RowConstantEval.java
        • tajo-plan/src/main/java/org/apache/tajo/plan/logical/JoinNode.java
        • tajo-plan/src/main/java/org/apache/tajo/plan/expr/CastEval.java
        • tajo-plan/src/main/java/org/apache/tajo/plan/logical/AlterTableNode.java
        • tajo-plan/src/main/java/org/apache/tajo/plan/serder/EvalNodeDeserializer.java
        • tajo-plan/src/main/java/org/apache/tajo/plan/LogicalPlan.java
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Tajo-master-CODEGEN-build #261 (See https://builds.apache.org/job/Tajo-master-CODEGEN-build/261/ ) TAJO-1392 : Resolve findbug warnings on Tajo Plan Module (jihun: rev 154f5b9e1c619ce4327aa055fb3ef02d6030fc0d) tajo-plan/src/main/java/org/apache/tajo/plan/verifier/PreLogicalPlanVerifier.java tajo-plan/src/main/java/org/apache/tajo/plan/logical/SelectionNode.java tajo-plan/src/main/java/org/apache/tajo/plan/logical/DistinctGroupbyNode.java tajo-plan/src/main/java/org/apache/tajo/plan/expr/IsNullEval.java tajo-plan/src/main/java/org/apache/tajo/plan/logical/ShuffleFileWriteNode.java tajo-plan/src/main/java/org/apache/tajo/plan/logical/LimitNode.java tajo-plan/src/main/java/org/apache/tajo/plan/ExprAnnotator.java tajo-plan/src/main/java/org/apache/tajo/plan/expr/AlgebraicUtil.java tajo-plan/src/main/java/org/apache/tajo/plan/expr/RegexPredicateEval.java tajo-plan/src/main/java/org/apache/tajo/plan/visitor/BasicLogicalPlanVisitor.java tajo-plan/src/main/java/org/apache/tajo/plan/nameresolver/NameResolver.java CHANGES tajo-plan/src/main/java/org/apache/tajo/plan/expr/AggregationFunctionCallEval.java tajo-plan/src/main/java/org/apache/tajo/plan/logical/EvalExprNode.java tajo-plan/src/main/java/org/apache/tajo/plan/logical/InsertNode.java tajo-plan/src/main/java/org/apache/tajo/plan/expr/WindowFunctionEval.java tajo-plan/src/main/java/org/apache/tajo/plan/logical/GroupbyNode.java tajo-plan/src/main/java/org/apache/tajo/plan/logical/StoreTableNode.java tajo-plan/src/main/java/org/apache/tajo/plan/logical/SortNode.java tajo-plan/src/main/java/org/apache/tajo/plan/logical/LogicalNode.java tajo-plan/src/main/java/org/apache/tajo/plan/logical/PersistentStoreNode.java tajo-plan/src/main/java/org/apache/tajo/plan/expr/InEval.java tajo-plan/src/main/java/org/apache/tajo/plan/expr/PartialBinaryExpr.java tajo-plan/src/main/java/org/apache/tajo/plan/rewrite/rules/FilterPushDownRule.java tajo-plan/src/main/java/org/apache/tajo/plan/expr/EvalTreeUtil.java tajo-plan/src/main/java/org/apache/tajo/plan/expr/BetweenPredicateEval.java tajo-plan/src/main/java/org/apache/tajo/plan/verifier/LogicalPlanVerifier.java tajo-plan/src/main/java/org/apache/tajo/plan/joinorder/GreedyHeuristicJoinOrderAlgorithm.java tajo-plan/src/main/java/org/apache/tajo/plan/logical/HavingNode.java tajo-plan/src/main/java/org/apache/tajo/plan/expr/CaseWhenEval.java tajo-plan/src/main/java/org/apache/tajo/plan/logical/IndexScanNode.java tajo-plan/src/main/java/org/apache/tajo/plan/logical/ProjectionNode.java tajo-plan/src/main/java/org/apache/tajo/plan/expr/RowConstantEval.java tajo-plan/src/main/java/org/apache/tajo/plan/logical/JoinNode.java tajo-plan/src/main/java/org/apache/tajo/plan/expr/CastEval.java tajo-plan/src/main/java/org/apache/tajo/plan/logical/AlterTableNode.java tajo-plan/src/main/java/org/apache/tajo/plan/serder/EvalNodeDeserializer.java tajo-plan/src/main/java/org/apache/tajo/plan/LogicalPlan.java
        Hide
        hudson Hudson added a comment -

        SUCCESS: Integrated in Tajo-master-build #623 (See https://builds.apache.org/job/Tajo-master-build/623/)
        TAJO-1392: Resolve findbug warnings on Tajo Plan Module (jihun: rev 154f5b9e1c619ce4327aa055fb3ef02d6030fc0d)

        • tajo-plan/src/main/java/org/apache/tajo/plan/logical/ProjectionNode.java
        • tajo-plan/src/main/java/org/apache/tajo/plan/logical/HavingNode.java
        • tajo-plan/src/main/java/org/apache/tajo/plan/expr/CaseWhenEval.java
        • tajo-plan/src/main/java/org/apache/tajo/plan/logical/StoreTableNode.java
        • tajo-plan/src/main/java/org/apache/tajo/plan/expr/RegexPredicateEval.java
        • tajo-plan/src/main/java/org/apache/tajo/plan/logical/LogicalNode.java
        • tajo-plan/src/main/java/org/apache/tajo/plan/logical/IndexScanNode.java
        • tajo-plan/src/main/java/org/apache/tajo/plan/verifier/PreLogicalPlanVerifier.java
        • tajo-plan/src/main/java/org/apache/tajo/plan/logical/JoinNode.java
        • tajo-plan/src/main/java/org/apache/tajo/plan/logical/PersistentStoreNode.java
        • tajo-plan/src/main/java/org/apache/tajo/plan/expr/AlgebraicUtil.java
        • tajo-plan/src/main/java/org/apache/tajo/plan/logical/DistinctGroupbyNode.java
        • tajo-plan/src/main/java/org/apache/tajo/plan/serder/EvalNodeDeserializer.java
        • tajo-plan/src/main/java/org/apache/tajo/plan/joinorder/GreedyHeuristicJoinOrderAlgorithm.java
        • tajo-plan/src/main/java/org/apache/tajo/plan/logical/ShuffleFileWriteNode.java
        • tajo-plan/src/main/java/org/apache/tajo/plan/logical/EvalExprNode.java
        • tajo-plan/src/main/java/org/apache/tajo/plan/logical/SortNode.java
        • tajo-plan/src/main/java/org/apache/tajo/plan/expr/RowConstantEval.java
        • tajo-plan/src/main/java/org/apache/tajo/plan/logical/AlterTableNode.java
        • tajo-plan/src/main/java/org/apache/tajo/plan/logical/InsertNode.java
        • tajo-plan/src/main/java/org/apache/tajo/plan/expr/PartialBinaryExpr.java
        • tajo-plan/src/main/java/org/apache/tajo/plan/expr/InEval.java
        • tajo-plan/src/main/java/org/apache/tajo/plan/expr/CastEval.java
        • tajo-plan/src/main/java/org/apache/tajo/plan/logical/SelectionNode.java
        • tajo-plan/src/main/java/org/apache/tajo/plan/rewrite/rules/FilterPushDownRule.java
        • tajo-plan/src/main/java/org/apache/tajo/plan/nameresolver/NameResolver.java
        • tajo-plan/src/main/java/org/apache/tajo/plan/logical/LimitNode.java
        • tajo-plan/src/main/java/org/apache/tajo/plan/expr/BetweenPredicateEval.java
        • tajo-plan/src/main/java/org/apache/tajo/plan/ExprAnnotator.java
        • tajo-plan/src/main/java/org/apache/tajo/plan/expr/WindowFunctionEval.java
        • tajo-plan/src/main/java/org/apache/tajo/plan/expr/IsNullEval.java
        • tajo-plan/src/main/java/org/apache/tajo/plan/verifier/LogicalPlanVerifier.java
        • tajo-plan/src/main/java/org/apache/tajo/plan/LogicalPlan.java
        • CHANGES
        • tajo-plan/src/main/java/org/apache/tajo/plan/expr/EvalTreeUtil.java
        • tajo-plan/src/main/java/org/apache/tajo/plan/visitor/BasicLogicalPlanVisitor.java
        • tajo-plan/src/main/java/org/apache/tajo/plan/expr/AggregationFunctionCallEval.java
        • tajo-plan/src/main/java/org/apache/tajo/plan/logical/GroupbyNode.java
        Show
        hudson Hudson added a comment - SUCCESS: Integrated in Tajo-master-build #623 (See https://builds.apache.org/job/Tajo-master-build/623/ ) TAJO-1392 : Resolve findbug warnings on Tajo Plan Module (jihun: rev 154f5b9e1c619ce4327aa055fb3ef02d6030fc0d) tajo-plan/src/main/java/org/apache/tajo/plan/logical/ProjectionNode.java tajo-plan/src/main/java/org/apache/tajo/plan/logical/HavingNode.java tajo-plan/src/main/java/org/apache/tajo/plan/expr/CaseWhenEval.java tajo-plan/src/main/java/org/apache/tajo/plan/logical/StoreTableNode.java tajo-plan/src/main/java/org/apache/tajo/plan/expr/RegexPredicateEval.java tajo-plan/src/main/java/org/apache/tajo/plan/logical/LogicalNode.java tajo-plan/src/main/java/org/apache/tajo/plan/logical/IndexScanNode.java tajo-plan/src/main/java/org/apache/tajo/plan/verifier/PreLogicalPlanVerifier.java tajo-plan/src/main/java/org/apache/tajo/plan/logical/JoinNode.java tajo-plan/src/main/java/org/apache/tajo/plan/logical/PersistentStoreNode.java tajo-plan/src/main/java/org/apache/tajo/plan/expr/AlgebraicUtil.java tajo-plan/src/main/java/org/apache/tajo/plan/logical/DistinctGroupbyNode.java tajo-plan/src/main/java/org/apache/tajo/plan/serder/EvalNodeDeserializer.java tajo-plan/src/main/java/org/apache/tajo/plan/joinorder/GreedyHeuristicJoinOrderAlgorithm.java tajo-plan/src/main/java/org/apache/tajo/plan/logical/ShuffleFileWriteNode.java tajo-plan/src/main/java/org/apache/tajo/plan/logical/EvalExprNode.java tajo-plan/src/main/java/org/apache/tajo/plan/logical/SortNode.java tajo-plan/src/main/java/org/apache/tajo/plan/expr/RowConstantEval.java tajo-plan/src/main/java/org/apache/tajo/plan/logical/AlterTableNode.java tajo-plan/src/main/java/org/apache/tajo/plan/logical/InsertNode.java tajo-plan/src/main/java/org/apache/tajo/plan/expr/PartialBinaryExpr.java tajo-plan/src/main/java/org/apache/tajo/plan/expr/InEval.java tajo-plan/src/main/java/org/apache/tajo/plan/expr/CastEval.java tajo-plan/src/main/java/org/apache/tajo/plan/logical/SelectionNode.java tajo-plan/src/main/java/org/apache/tajo/plan/rewrite/rules/FilterPushDownRule.java tajo-plan/src/main/java/org/apache/tajo/plan/nameresolver/NameResolver.java tajo-plan/src/main/java/org/apache/tajo/plan/logical/LimitNode.java tajo-plan/src/main/java/org/apache/tajo/plan/expr/BetweenPredicateEval.java tajo-plan/src/main/java/org/apache/tajo/plan/ExprAnnotator.java tajo-plan/src/main/java/org/apache/tajo/plan/expr/WindowFunctionEval.java tajo-plan/src/main/java/org/apache/tajo/plan/expr/IsNullEval.java tajo-plan/src/main/java/org/apache/tajo/plan/verifier/LogicalPlanVerifier.java tajo-plan/src/main/java/org/apache/tajo/plan/LogicalPlan.java CHANGES tajo-plan/src/main/java/org/apache/tajo/plan/expr/EvalTreeUtil.java tajo-plan/src/main/java/org/apache/tajo/plan/visitor/BasicLogicalPlanVisitor.java tajo-plan/src/main/java/org/apache/tajo/plan/expr/AggregationFunctionCallEval.java tajo-plan/src/main/java/org/apache/tajo/plan/logical/GroupbyNode.java
        Hide
        ykrips Jihun Kang added a comment -

        Committed.

        Show
        ykrips Jihun Kang added a comment - Committed.
        Hide
        githubbot ASF GitHub Bot added a comment -

        Github user asfgit closed the pull request at:

        https://github.com/apache/tajo/pull/424

        Show
        githubbot ASF GitHub Bot added a comment - Github user asfgit closed the pull request at: https://github.com/apache/tajo/pull/424
        Hide
        githubbot ASF GitHub Bot added a comment -

        Github user hyunsik commented on the pull request:

        https://github.com/apache/tajo/pull/424#issuecomment-83850303

        +1

        No findbug warnings, succeeded unit tests, and nice changes

        Ship it.

        Show
        githubbot ASF GitHub Bot added a comment - Github user hyunsik commented on the pull request: https://github.com/apache/tajo/pull/424#issuecomment-83850303 +1 No findbug warnings, succeeded unit tests, and nice changes Ship it.
        Hide
        tajoqa Tajo QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12705090/TAJO-1392.1.patch
        against master revision release-0.9.0-rc0-205-g286b956.

        +1 @author. The patch does not contain any @author tags.

        -1 tests included. The patch doesn't appear to include any new or modified tests.
        Please justify why no new tests are needed for this patch.
        Also please list what manual steps were performed to verify this patch.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 javadoc. The applied patch does not increase the total number of javadoc warnings.

        +1 checkstyle. The patch generated 0 code style errors.

        +1 findbugs. The patch does not introduce any new Findbugs (version 2.0.3) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 core tests. The patch passed unit tests in tajo-plan.

        Test results: https://builds.apache.org/job/PreCommit-TAJO-Build/616//testReport/
        Console output: https://builds.apache.org/job/PreCommit-TAJO-Build/616//console

        This message is automatically generated.

        Show
        tajoqa Tajo QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12705090/TAJO-1392.1.patch against master revision release-0.9.0-rc0-205-g286b956. +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 javadoc. The applied patch does not increase the total number of javadoc warnings. +1 checkstyle. The patch generated 0 code style errors. +1 findbugs. The patch does not introduce any new Findbugs (version 2.0.3) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed unit tests in tajo-plan. Test results: https://builds.apache.org/job/PreCommit-TAJO-Build/616//testReport/ Console output: https://builds.apache.org/job/PreCommit-TAJO-Build/616//console This message is automatically generated.
        Hide
        githubbot ASF GitHub Bot added a comment -

        Github user blrunner commented on the pull request:

        https://github.com/apache/tajo/pull/424#issuecomment-82117517

        Thank you for your contribution.
        I'll review the patch tomorrow.

        Show
        githubbot ASF GitHub Bot added a comment - Github user blrunner commented on the pull request: https://github.com/apache/tajo/pull/424#issuecomment-82117517 Thank you for your contribution. I'll review the patch tomorrow.
        Hide
        githubbot ASF GitHub Bot added a comment -

        GitHub user ykrips opened a pull request:

        https://github.com/apache/tajo/pull/424

        TAJO-1392: Resolve findbug warnings on Tajo Plan Module

        See this comment. This patch passed findbugs phase.
        https://issues.apache.org/jira/browse/TAJO-1392?focusedCommentId=14362816&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-14362816

        You can merge this pull request into a Git repository by running:

        $ git pull https://github.com/ykrips/tajo TAJO-1392

        Alternatively you can review and apply these changes as the patch at:

        https://github.com/apache/tajo/pull/424.patch

        To close this pull request, make a commit to your master/trunk branch
        with (at least) the following in the commit message:

        This closes #424


        commit 150330a9456bb1a66eef519f7cc20e524fc4535f
        Author: Jihun Kang <jihun@apache.org>
        Date: 2015-03-16T06:21:49Z

        Initial work


        Show
        githubbot ASF GitHub Bot added a comment - GitHub user ykrips opened a pull request: https://github.com/apache/tajo/pull/424 TAJO-1392 : Resolve findbug warnings on Tajo Plan Module See this comment. This patch passed findbugs phase. https://issues.apache.org/jira/browse/TAJO-1392?focusedCommentId=14362816&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-14362816 You can merge this pull request into a Git repository by running: $ git pull https://github.com/ykrips/tajo TAJO-1392 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/tajo/pull/424.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #424 commit 150330a9456bb1a66eef519f7cc20e524fc4535f Author: Jihun Kang <jihun@apache.org> Date: 2015-03-16T06:21:49Z Initial work
        Hide
        tajoqa Tajo QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12704722/TAJO-1392.patch
        against master revision release-0.9.0-rc0-204-g0dc7d68.

        +1 @author. The patch does not contain any @author tags.

        -1 tests included. The patch doesn't appear to include any new or modified tests.
        Please justify why no new tests are needed for this patch.
        Also please list what manual steps were performed to verify this patch.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 javadoc. The applied patch does not increase the total number of javadoc warnings.

        +1 checkstyle. The patch generated 0 code style errors.

        +1 findbugs. The patch does not introduce any new Findbugs (version 2.0.3) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 core tests. The patch passed unit tests in tajo-plan.

        Test results: https://builds.apache.org/job/PreCommit-TAJO-Build/614//testReport/
        Console output: https://builds.apache.org/job/PreCommit-TAJO-Build/614//console

        This message is automatically generated.

        Show
        tajoqa Tajo QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12704722/TAJO-1392.patch against master revision release-0.9.0-rc0-204-g0dc7d68. +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 javadoc. The applied patch does not increase the total number of javadoc warnings. +1 checkstyle. The patch generated 0 code style errors. +1 findbugs. The patch does not introduce any new Findbugs (version 2.0.3) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed unit tests in tajo-plan. Test results: https://builds.apache.org/job/PreCommit-TAJO-Build/614//testReport/ Console output: https://builds.apache.org/job/PreCommit-TAJO-Build/614//console This message is automatically generated.

          People

          • Assignee:
            ykrips Jihun Kang
            Reporter:
            hyunsik Hyunsik Choi
          • Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development