Details

    • Type: Sub-task
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 0.11.0
    • Fix Version/s: 0.11.0
    • Component/s: None
    • Labels:
      None

      Description

      This task will fix up findbugs issues on Tajo Common Project.

        Activity

        Hide
        githubbot ASF GitHub Bot added a comment -

        GitHub user ykrips opened a pull request:

        https://github.com/apache/tajo/pull/383

        TAJO-1351: Resolve findbug warnings on Tajo Common Module

        Removed findbugs warnings except 1 item, unread field on org.apache.tajo.util.datetime.DateTimeFormat.java.

        You can merge this pull request into a Git repository by running:

        $ git pull https://github.com/ykrips/tajo TAJO-1351

        Alternatively you can review and apply these changes as the patch at:

        https://github.com/apache/tajo/pull/383.patch

        To close this pull request, make a commit to your master/trunk branch
        with (at least) the following in the commit message:

        This closes #383


        commit 6e3459cfe7fc6440fedb943aeae19f7a39d96ed2
        Author: Jihun Kang <jihun@apache.org>
        Date: 2015-02-16T11:28:26Z

        Supressed findbugs warnings


        Show
        githubbot ASF GitHub Bot added a comment - GitHub user ykrips opened a pull request: https://github.com/apache/tajo/pull/383 TAJO-1351 : Resolve findbug warnings on Tajo Common Module Removed findbugs warnings except 1 item, unread field on org.apache.tajo.util.datetime.DateTimeFormat.java. You can merge this pull request into a Git repository by running: $ git pull https://github.com/ykrips/tajo TAJO-1351 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/tajo/pull/383.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #383 commit 6e3459cfe7fc6440fedb943aeae19f7a39d96ed2 Author: Jihun Kang <jihun@apache.org> Date: 2015-02-16T11:28:26Z Supressed findbugs warnings
        Hide
        githubbot ASF GitHub Bot added a comment -

        Github user hyunsik commented on the pull request:

        https://github.com/apache/tajo/pull/383#issuecomment-75350547

        +1
        The patch looks good to me. Even though there remains one warning, findbug rules occasionally is too strict. We also need to exclude some of them. It would be great if we remove most of warnings firstly and we handle few cumbersome ones later.

        Show
        githubbot ASF GitHub Bot added a comment - Github user hyunsik commented on the pull request: https://github.com/apache/tajo/pull/383#issuecomment-75350547 +1 The patch looks good to me. Even though there remains one warning, findbug rules occasionally is too strict. We also need to exclude some of them. It would be great if we remove most of warnings firstly and we handle few cumbersome ones later.
        Hide
        githubbot ASF GitHub Bot added a comment -

        Github user asfgit closed the pull request at:

        https://github.com/apache/tajo/pull/383

        Show
        githubbot ASF GitHub Bot added a comment - Github user asfgit closed the pull request at: https://github.com/apache/tajo/pull/383
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Tajo-master-CODEGEN-build #227 (See https://builds.apache.org/job/Tajo-master-CODEGEN-build/227/)
        TAJO-1351: Resolve findbug warnings on Tajo Common Module (jihun: rev 7ca1e73bce7102d7bf84557cd785182c0383e7ef)

        • CHANGES
        • tajo-common/src/main/java/org/apache/tajo/util/NumberUtil.java
        • tajo-common/src/main/java/org/apache/tajo/util/KeyValueSet.java
        • tajo-common/src/main/java/org/apache/tajo/validation/RangeValidator.java
        • tajo-common/src/main/java/org/apache/tajo/util/datetime/TimeMeta.java
        • tajo-common/src/main/java/org/apache/tajo/SessionVars.java
        • tajo-common/src/main/java/org/apache/tajo/OverridableConf.java
        • tajo-common/src/main/java/org/apache/tajo/datum/TextDatum.java
        • tajo-common/src/main/java/org/apache/tajo/util/MurmurHash.java
        • tajo-common/src/main/java/org/apache/tajo/util/datetime/DateTimeUtil.java
        • tajo-common/src/main/java/org/apache/tajo/validation/ConstraintViolationException.java
        • tajo-common/src/main/java/org/apache/tajo/storage/EmptyTuple.java
        • tajo-common/src/main/java/org/apache/tajo/util/datetime/DateTimeConstants.java
        • tajo-common/src/main/java/org/apache/tajo/rule/SelfDiagnosisRuleEngine.java
        • tajo-common/src/main/java/org/apache/tajo/rule/SelfDiagnosisRuleSession.java
        • tajo-common/src/main/java/org/apache/tajo/util/datetime/DateTimeFormat.java
        • tajo-common/src/main/java/org/apache/tajo/validation/Validator.java
        • tajo-common/src/main/java/org/apache/tajo/util/TUtil.java
        • tajo-common/src/main/java/org/apache/tajo/util/ClassUtil.java
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Tajo-master-CODEGEN-build #227 (See https://builds.apache.org/job/Tajo-master-CODEGEN-build/227/ ) TAJO-1351 : Resolve findbug warnings on Tajo Common Module (jihun: rev 7ca1e73bce7102d7bf84557cd785182c0383e7ef) CHANGES tajo-common/src/main/java/org/apache/tajo/util/NumberUtil.java tajo-common/src/main/java/org/apache/tajo/util/KeyValueSet.java tajo-common/src/main/java/org/apache/tajo/validation/RangeValidator.java tajo-common/src/main/java/org/apache/tajo/util/datetime/TimeMeta.java tajo-common/src/main/java/org/apache/tajo/SessionVars.java tajo-common/src/main/java/org/apache/tajo/OverridableConf.java tajo-common/src/main/java/org/apache/tajo/datum/TextDatum.java tajo-common/src/main/java/org/apache/tajo/util/MurmurHash.java tajo-common/src/main/java/org/apache/tajo/util/datetime/DateTimeUtil.java tajo-common/src/main/java/org/apache/tajo/validation/ConstraintViolationException.java tajo-common/src/main/java/org/apache/tajo/storage/EmptyTuple.java tajo-common/src/main/java/org/apache/tajo/util/datetime/DateTimeConstants.java tajo-common/src/main/java/org/apache/tajo/rule/SelfDiagnosisRuleEngine.java tajo-common/src/main/java/org/apache/tajo/rule/SelfDiagnosisRuleSession.java tajo-common/src/main/java/org/apache/tajo/util/datetime/DateTimeFormat.java tajo-common/src/main/java/org/apache/tajo/validation/Validator.java tajo-common/src/main/java/org/apache/tajo/util/TUtil.java tajo-common/src/main/java/org/apache/tajo/util/ClassUtil.java
        Hide
        hudson Hudson added a comment -

        SUCCESS: Integrated in Tajo-master-build #588 (See https://builds.apache.org/job/Tajo-master-build/588/)
        TAJO-1351: Resolve findbug warnings on Tajo Common Module (jihun: rev 7ca1e73bce7102d7bf84557cd785182c0383e7ef)

        • tajo-common/src/main/java/org/apache/tajo/util/datetime/DateTimeUtil.java
        • tajo-common/src/main/java/org/apache/tajo/datum/TextDatum.java
        • tajo-common/src/main/java/org/apache/tajo/util/TUtil.java
        • tajo-common/src/main/java/org/apache/tajo/rule/SelfDiagnosisRuleEngine.java
        • tajo-common/src/main/java/org/apache/tajo/util/KeyValueSet.java
        • tajo-common/src/main/java/org/apache/tajo/validation/Validator.java
        • tajo-common/src/main/java/org/apache/tajo/util/datetime/TimeMeta.java
        • tajo-common/src/main/java/org/apache/tajo/util/datetime/DateTimeConstants.java
        • tajo-common/src/main/java/org/apache/tajo/util/NumberUtil.java
        • tajo-common/src/main/java/org/apache/tajo/util/MurmurHash.java
        • tajo-common/src/main/java/org/apache/tajo/OverridableConf.java
        • tajo-common/src/main/java/org/apache/tajo/validation/RangeValidator.java
        • tajo-common/src/main/java/org/apache/tajo/util/datetime/DateTimeFormat.java
        • tajo-common/src/main/java/org/apache/tajo/validation/ConstraintViolationException.java
        • tajo-common/src/main/java/org/apache/tajo/SessionVars.java
        • tajo-common/src/main/java/org/apache/tajo/storage/EmptyTuple.java
        • tajo-common/src/main/java/org/apache/tajo/rule/SelfDiagnosisRuleSession.java
        • tajo-common/src/main/java/org/apache/tajo/util/ClassUtil.java
        • CHANGES
        Show
        hudson Hudson added a comment - SUCCESS: Integrated in Tajo-master-build #588 (See https://builds.apache.org/job/Tajo-master-build/588/ ) TAJO-1351 : Resolve findbug warnings on Tajo Common Module (jihun: rev 7ca1e73bce7102d7bf84557cd785182c0383e7ef) tajo-common/src/main/java/org/apache/tajo/util/datetime/DateTimeUtil.java tajo-common/src/main/java/org/apache/tajo/datum/TextDatum.java tajo-common/src/main/java/org/apache/tajo/util/TUtil.java tajo-common/src/main/java/org/apache/tajo/rule/SelfDiagnosisRuleEngine.java tajo-common/src/main/java/org/apache/tajo/util/KeyValueSet.java tajo-common/src/main/java/org/apache/tajo/validation/Validator.java tajo-common/src/main/java/org/apache/tajo/util/datetime/TimeMeta.java tajo-common/src/main/java/org/apache/tajo/util/datetime/DateTimeConstants.java tajo-common/src/main/java/org/apache/tajo/util/NumberUtil.java tajo-common/src/main/java/org/apache/tajo/util/MurmurHash.java tajo-common/src/main/java/org/apache/tajo/OverridableConf.java tajo-common/src/main/java/org/apache/tajo/validation/RangeValidator.java tajo-common/src/main/java/org/apache/tajo/util/datetime/DateTimeFormat.java tajo-common/src/main/java/org/apache/tajo/validation/ConstraintViolationException.java tajo-common/src/main/java/org/apache/tajo/SessionVars.java tajo-common/src/main/java/org/apache/tajo/storage/EmptyTuple.java tajo-common/src/main/java/org/apache/tajo/rule/SelfDiagnosisRuleSession.java tajo-common/src/main/java/org/apache/tajo/util/ClassUtil.java CHANGES
        Hide
        hyunsik Hyunsik Choi added a comment -

        I fix it as resolved. Thank you for your work.

        Show
        hyunsik Hyunsik Choi added a comment - I fix it as resolved. Thank you for your work.
        Hide
        ykrips Jihun Kang added a comment -

        Thank you for closing this issue.

        Show
        ykrips Jihun Kang added a comment - Thank you for closing this issue.

          People

          • Assignee:
            ykrips Jihun Kang
            Reporter:
            ykrips Jihun Kang
          • Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development