Uploaded image for project: 'OFBiz'
  1. OFBiz
  2. OFBIZ-7272

Enforce noninstantiability to all Utility classes

    XMLWordPrintableJSON

Details

    • Improvement
    • Status: Closed
    • Major
    • Resolution: Implemented
    • Trunk
    • 16.11.01
    • ALL COMPONENTS
    • None
    • Community Day 2 - 2016, OFBiz Community Day (May 2020)

    Description

      I have discusses this in past on mailing list, that Utility, helper, worker classes which contains only static methods should not be instantiable. Also we can restrict it by adding a private constructor.

      Currently OFBiz has many such classes which should have private constructor. Identify all the *Worker.java, *.Helper.java, and *Util.java which do not have any non static method/member are eligible for having a private constructor.

      Reference why we should do this : http://www.informit.com/articles/article.aspx?p=1216151&seqNum=4

      Attachments

        1. OFBIZ-7272.patch
          54 kB
          Chinmay Patidar

        Issue Links

          mentioned in

          Page Loading...

          1.
          		 Enforce noninstantiability to InvoiceWorker Class Sub-task Closed Arun Patidar
          2.
          		 Enforce noninstantiability to PaymentWorker class Sub-task Closed Arun Patidar
          3.
          		 Enforce noninstantiability to SagePayUtil class Sub-task Closed Arun Patidar
          4.
          		 Enforce noninstantiability to UtilAccounting Class Sub-task Closed Arun Patidar
          5.
          		 Enforce noninstantiability to ContentManagementWorker class Sub-task Closed Arun Patidar
          6.
          		 Enforce noninstantiability to LayoutWorker class Sub-task Closed Arun Patidar
          7.
          		 Enforce noninstantiability to OpenOfficeWorker class Sub-task Closed Arun Patidar
          8.
          		 Enforce noninstantiability to BOMHelper class Sub-task Closed Arun Patidar
          9.
          		 Enforce noninstantiability to ProductionRunHelper class Sub-task Closed Arun Patidar
          10.
          		 Enforce noninstantiability to SolrUtil Class Sub-task Closed Arun Patidar
          11.
          		 Enforce noninstantiability to ReportHelper class Sub-task Closed Arun Patidar
          12.
          		 Enforce noninstantiability to OrderChangeHelper class Sub-task Closed Arun Patidar
          13.
          		 Enforce noninstantiability to SearchWorker Class Sub-task Closed Arun Patidar
          14.
          		 Enforce noninstantiability to ProductDisplayWorker class Sub-task Closed Arun Patidar
          15.
          		 Enforce noninstantiability to BirtWorker Class Sub-task Closed Arun Patidar
          16.
          		 Enforce noninstantiability to UtilHelpText Class Sub-task Closed Arun Patidar
          17.
          		 Enforce noninstantiability to ProductPromoWorker class Sub-task Closed Arun Patidar
          18.
          		 Enforce noninstantiability to TaskWorker class Sub-task Closed Arun Patidar
          19.
          		 Enforce noninstantiability to PartyRelationshipHelper class Sub-task Closed Arun Patidar
          20.
          		 Enforce noninstantiability to WidgetPortalPageWorker Class Sub-task Closed Arun Patidar
          21.
          		 Enforce noninstantiability to WidgetDataResourceWorker Class Sub-task Closed Arun Patidar
          22.
          		 Enforce noninstantiability to PartyTypeHelper class Sub-task Closed Arun Patidar
          23.
          		 Enforce noninstantiability to SeoConfigUtil class Sub-task Closed Arun Patidar
          24.
          		 Enforce noninstantiability to WidgetContentWorker Class Sub-task Closed Arun Patidar
          25.
          		 Enforce noninstantiability to SeoUrlUtil class Sub-task Closed Arun Patidar
          26.
          		 Enforce noninstantiability to UtilCacheEvents Class Sub-task Closed Arun Patidar
          27.
          		 Enforce noninstantiability to ProductConfigWorker class Sub-task Closed Arun Patidar
          28.
          		 Enforce noninstantiability to WebSiteWorker Class Sub-task Closed Arun Patidar
          29.
          		 Enforce noninstantiability to ImageManagementHelper class Sub-task Closed Arun Patidar
          30.
          		 Enforce noninstantiability to InventoryWorker class Sub-task Closed Arun Patidar
          31.
          		 Enforce noninstantiability to ProductUtilServices class Sub-task Closed Arun Patidar
          32.
          		 Enforce noninstantiability to WebDavUtil Class Sub-task Closed Arun Patidar
          33.
          		 Enforce noninstantiability to ImportProductHelper class Sub-task Closed Arun Patidar
          34.
          		 Enforce noninstantiability to ApacheFopWorker Class Sub-task Closed Arun Patidar
          35.
          		 Enforce noninstantiability to ProductStoreWorker class Sub-task Closed Arun Patidar
          36.
          		 Enforce noninstantiability to ShipmentWorker class Sub-task Closed Arun Patidar
          37.
          		 Enforce noninstantiability to ProtectViewWorker Class Sub-task Closed Arun Patidar
          38.
          		 Enforce noninstantiability to WorkEffortWorker class Sub-task Closed Arun Patidar
          39.
          		 Enforce noninstantiability to ServiceMcaUtil Class Sub-task Closed Arun Patidar
          40.
          		 Enforce noninstantiability to BshUtil class Sub-task Closed Arun Patidar
          41.
          		 Enforce noninstantiability to FileUtil class Sub-task Closed Arun Patidar
          42.
          		 Enforce noninstantiability to KeyStoreUtil class Sub-task Closed Arun Patidar
          43.
          		 Enforce noninstantiability to SSLUtil class Sub-task Closed Arun Patidar
          44.
          		 Enforce noninstantiability to UtilDateTime class Sub-task Closed Arun Patidar
          45.
          		 Enforce noninstantiability to UtilFormatOut class Sub-task Closed Arun Patidar
          46.
          		 Enforce noninstantiability to UtilGenerics class Sub-task Closed Arun Patidar
          47.
          		 Enforce noninstantiability to UtilHttp class Sub-task Closed Arun Patidar
          48.
          		 Enforce noninstantiability to UtilIO class Sub-task Closed Arun Patidar
          49.
          		 Enforce noninstantiability to UtilJavaParse class Sub-task Closed Arun Patidar
          50.
          		 Enforce noninstantiability to UtilNumber class Sub-task Closed Arun Patidar
          51.
          		 Enforce noninstantiability to UtilPlist class Sub-task Closed Arun Patidar
          52.
          		 Enforce noninstantiability to UtilURL class Sub-task Closed Arun Patidar
          53.
          		 Enforce noninstantiability to ServiceEcaUtil class Sub-task Closed Arun Patidar
          54.
          		 Enforce noninstantiability to ServiceConfigUtil class Sub-task Closed Arun Patidar
          55.
          		 Enforce noninstantiability to RecurrenceUtil class Sub-task Closed Arun Patidar
          56.
          		 Enforce noninstantiability to EntityEcaUtil class Sub-task Closed Arun Patidar
          57.
          		 Enforce noninstantiability to KeywordSearchUtil class Sub-task Closed Arun Patidar
          58.
          		 Enforce noninstantiability to StatusWorker class Sub-task Closed Arun Patidar
          59.
          		 Enforce noninstantiability to PeriodWorker class Sub-task Closed Arun Patidar
          60.
          		 Enforce noninstantiability to PreferenceWorker class Sub-task Closed Arun Patidar
          61.
          		 Enforce noninstantiability to GeoWorker class Sub-task Closed Arun Patidar
          62.
          		 Enforce noninstantiability to AuthHelper class Sub-task Closed Arun Patidar
          63.
          		 Enforce noninstantiability to UrlServletHelper class Sub-task Closed Arun Patidar
          64.
          		 Enforce noninstantiability to EntityFinderUtil class Sub-task Closed Arun Patidar
          65.
          		 Enforce noninstantiability to SqlJdbcUtil class Sub-task Closed Arun Patidar
          66.
          		 Enforce noninstantiability to CommonWorkers class Sub-task Closed Arun Patidar
          67.
          		 Enforce noninstantiability to EntityTypeUtil class Sub-task Closed Arun Patidar
          68.
          		 Enforce noninstantiability to ModelUtil class Sub-task Closed Arun Patidar
          69.
          		 Enforce noninstantiability to EntityUtil class Sub-task Closed Arun Patidar
          70.
          		 Enforce noninstantiability to EntityUtilProperties class Sub-task Closed Arun Patidar
          71.
          		 Enforce noninstantiability to EntityGroupUtil class Sub-task Closed Arun Patidar
          72.
          		 Enforce noninstantiability to MiniLangUtil class Sub-task Closed Arun Patidar
          73.
          		 Enforce noninstantiability to CatalogWorker class Sub-task Closed Arun Patidar
          74.
          		 Enforce noninstantiability to CategoryWorker class Sub-task Closed Arun Patidar
          75.
          		 Enforce noninstantiability to ProductWorker class Sub-task Closed Arun Patidar
          76.
          		 Enforce noninstantiability to UtilMisc class Sub-task Closed Arun Patidar
          77.
          		 Enforce noninstantiability to UtilProperties class Sub-task Closed Arun Patidar
          78.
          		 Enforce noninstantiability to UtilValidate class Sub-task Closed Arun Patidar
          79.
          		 Enforce noninstantiability to UtilXml class Sub-task Closed Arun Patidar
          80.
          		 Enforce noninstantiability to UelUtil class Sub-task Closed Arun Patidar
          81.
          		 Enforce noninstantiability to FreeMarkerWorker class Sub-task Closed Arun Patidar
          82.
          		 Enforce noninstantiability to DatabaseUtil class Sub-task Closed Rishi Solanki
          83.
          		 Enforce noninstantiability to TransactionUtil class Sub-task Closed Arun Patidar
          84.
          		 Enforce noninstantiability to ServiceUtil class Sub-task Closed Arun Patidar
          85.
          		 Enforce noninstantiability to TemporalExpressionWorker class Sub-task Closed Arun Patidar
          86.
          		 Enforce noninstantiability to ProductUtil class Sub-task Closed Arun Patidar
          87.
          		 Enforce noninstantiability to CategoryUtil class Sub-task Closed Arun Patidar
          88.
          		 Enforce noninstantiability to ICalWorker class Sub-task Closed Arun Patidar
          89.
          		 Enforce noninstantiability to JNDIConfigUtil class Sub-task Closed Arun Patidar
          90.
          		 Enforce noninstantiability to BillingAccountWorker Class Sub-task Closed Suraj Khurana
          91.
          		 Enforce noninstantiability to FinAccountHelper Class Sub-task Closed Suraj Khurana
          92.
          		 Enforce noninstantiability to ConfigXMLReader Class Sub-task Closed Suraj Khurana
          93.
          		 Enforce noninstantiability to LoginWorker Class Sub-task Closed Suraj Khurana
          94.
          		 Enforce noninstantiability to ExpressionUiHelper Class Sub-task Closed Suraj Khurana
          95.
          		 Enforce noninstantiability to JobUtil Class Sub-task Closed Suraj Khurana
          96.
          		 Enforce noninstantiability to ServiceGroupReader Class Sub-task Closed Suraj Khurana
          97.
          		 Enforce noninstantiability to GroovyUtil Class Sub-task Closed Suraj Khurana

          Activity

            People

              surajk Suraj Khurana
              rishisolankii Rishi Solanki
              Votes:
              0 Vote for this issue
              Watchers:
              7 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: