Details

    • Type: Sub-task
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: Trunk
    • Fix Version/s: 16.11.01
    • Component/s: birt
    • Labels:
      None
    • Sprint:
      Community Day 2 - 2016

      Description

      • Make class as final.
      • Add a private constructor.
      • Make the following public static variables as private
            public final static String BIRT_PARAMETERS = "birtParameters";
            public final static String REPORT_ENGINE = "reportEngine";
            public final static String BIRT_LOCALE = "birtLocale";
            public final static String BIRT_IMAGE_DIRECTORY = "birtImageDirectory";
            public final static String BIRT_CONTENT_TYPE = "birtContentType";
            public final static String BIRT_OUTPUT_FILE_NAME = "birtOutputFileName";
        
      • Add get methods for above public variables that changed to private. Also replace the use public static variables with get methods.
        getBirtParameters()
        getBirtLocale()
        getBirtImageDirectory()
        getBirtContentType()
        getBirtOutputFileName()
        
      • Make the following private static variable as final.
            private static HTMLServerImageHandler imageHandler = new HTMLServerImageHandler();
        
      1. OFBIZ-7410.patch
        7 kB
        Pratik Kulshreshth

        Activity

        Hide
        pratik.kulshreshth Pratik Kulshreshth added a comment -

        Here is the patch for this issue.
        Removed REPORT_ENGINE variable as it was unused.

        Thanks Arun Patidar for the description and Rishi Solanki for guidance.

        Show
        pratik.kulshreshth Pratik Kulshreshth added a comment - Here is the patch for this issue. Removed REPORT_ENGINE variable as it was unused. Thanks Arun Patidar for the description and Rishi Solanki for guidance.
        Hide
        arunpati Arun Patidar added a comment -

        Committed changes in trunk at rev: 1750352.

        Thanks Pratik Kulshreshth for your contribution.

        Show
        arunpati Arun Patidar added a comment - Committed changes in trunk at rev: 1750352. Thanks Pratik Kulshreshth for your contribution.

          People

          • Assignee:
            arunpati Arun Patidar
            Reporter:
            arunpati Arun Patidar
          • Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development

                Agile