Details

    • Type: Sub-task
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: Trunk
    • Fix Version/s: 16.11.01
    • Component/s: framework
    • Labels:
      None
    • Sprint:
      Community Day 2 - 2016

      Description

      • Make class as final.
      • Private constructor already exists, by making it final we just matching the patterns from other utility classes.
      • Make following public static final variables as private;
            public static final BigDecimal ZERO_BD = BigDecimal.ZERO;
        
      • Nothing needs to be change for the private static class as it follows all patterns;
            // Private lazy-initializer class
            private static class LocaleHolder 
        
      1. OFBIZ-7803.patch
        0.7 kB
        Rohit Koushal

        Activity

        Hide
        rohit.koushal Rohit Koushal added a comment -

        Added the patch to fix this issue. Thanks, Rishi Solanki for the detailed description.

        Show
        rohit.koushal Rohit Koushal added a comment - Added the patch to fix this issue. Thanks, Rishi Solanki for the detailed description.
        Hide
        arunpati Arun Patidar added a comment -

        Committed changes in trunk at rev: 1754937.

        Thanks Rishi Solanki and Rohit Koushal for your contribution.

        Show
        arunpati Arun Patidar added a comment - Committed changes in trunk at rev: 1754937. Thanks Rishi Solanki and Rohit Koushal for your contribution.

          People

          • Assignee:
            arunpati Arun Patidar
            Reporter:
            rishisolankii Rishi Solanki
          • Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development

                Agile