Details

    • Type: Sub-task
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: Trunk
    • Fix Version/s: 16.11.01
    • Component/s: accounting
    • Labels:
      None
    • Sprint:
      Community Day 2 - 2016

      Description

      • Make InvoiceWorker class as final.
      • Add a private constructor.
      • Make the following private static variable as final.
            private static BigDecimal ZERO = BigDecimal.ZERO;
            private static int decimals = UtilNumber.getBigDecimalScale("invoice.decimals");
            private static int rounding = UtilNumber.getBigDecimalRoundingMode("invoice.rounding");
            private static int taxDecimals = UtilNumber.getBigDecimalScale("salestax.calc.decimals");
            private static int taxRounding = UtilNumber.getBigDecimalRoundingMode("salestax.rounding");
        
      1. OFBIZ-7378.patch
        2 kB
        Pratik Kulshreshth

        Activity

        Hide
        arunpati Arun Patidar added a comment -

        Committed changes in trunk at rev: 1749891.

        Thanks Rishi Solanki and Pratik Kulshreshth for your contribution.

        Show
        arunpati Arun Patidar added a comment - Committed changes in trunk at rev: 1749891. Thanks Rishi Solanki and Pratik Kulshreshth for your contribution.
        Hide
        pratik.kulshreshth Pratik Kulshreshth added a comment -

        Here is the patch for this issue. Thanks Rishi Solanki and Arun Patidar for guidance.

        Show
        pratik.kulshreshth Pratik Kulshreshth added a comment - Here is the patch for this issue. Thanks Rishi Solanki and Arun Patidar for guidance.
        Hide
        arunpati Arun Patidar added a comment -

        Also, make 'public static String module' variable as final.

        Show
        arunpati Arun Patidar added a comment - Also, make 'public static String module' variable as final.
        Hide
        rishisolankii Rishi Solanki added a comment -

        Thanks to [~arun.patidar] for discussion and finalize what to do with this class.

        Show
        rishisolankii Rishi Solanki added a comment - Thanks to [~arun.patidar] for discussion and finalize what to do with this class.

          People

          • Assignee:
            arunpati Arun Patidar
            Reporter:
            rishisolankii Rishi Solanki
          • Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development

                Agile