Details

    • Type: Sub-task
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: Trunk
    • Fix Version/s: 16.11.01
    • Component/s: order
    • Labels:
      None
    • Sprint:
      Community Day 2 - 2016

      Description

      • Make class as final.
      • Add a private constructor.
      • Make the following public static variables as private
            public static final String resource = "OrderUiLabels";
            public static final String resource_error = "OrderErrorUiLabels";
        
            public static final int decimals = UtilNumber.getBigDecimalScale("order.decimals");
            public static final int rounding = UtilNumber.getBigDecimalRoundingMode("order.rounding");
        
            public static final MathContext generalRounding = new MathContext(10);
        
        
      • Make following methods protected static methods as private
            protected static boolean hasOrderTotalCondition()
            protected static boolean runProductPromoRules()
            protected static void runProductPromos()
            protected static boolean checkCondition()
            protected static boolean checkConditionsForItem()
            protected static boolean checkConditionForItem()
            protected static ActionResultInfo performAction(
            protected static List<ShoppingCartItem> getCartItemsUsed()
            protected static BigDecimal getCartItemsUsedTotalAmount()
            protected static void distributeDiscountAmount()
            protected static Integer findPromoItem()
            protected static Integer findAdjustment()
            protected static boolean isProductOld()
            protected static void handleProductPromoCategories()
            protected static void getAllProductIds()
            protected static void handleProductPromoProducts()
        
      • Make protected class as private;
            protected static class UseLimitException extends Exception
        

        Activity

        Hide
        aman.mishra Aman Mishra added a comment -

        Thanks Rishi Solanki for the details. Provided the patch for the changes.

        Show
        aman.mishra Aman Mishra added a comment - Thanks Rishi Solanki for the details. Provided the patch for the changes.
        Hide
        arunpati Arun Patidar added a comment -

        Committed changes in trunk at rev: 1750354.

        Thanks Rishi Solanki and Aman Mishra for your contribution.

        Show
        arunpati Arun Patidar added a comment - Committed changes in trunk at rev: 1750354. Thanks Rishi Solanki and Aman Mishra for your contribution.

          People

          • Assignee:
            arunpati Arun Patidar
            Reporter:
            rishisolankii Rishi Solanki
          • Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development

                Agile