Details

    • Type: Sub-task
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: Trunk
    • Fix Version/s: 16.11.01
    • Component/s: workeffort
    • Labels:
      None
    • Sprint:
      Community Day 2 - 2016

      Description

      • Make class as final.
      • Add a private constructor.
      • Make following protected static methods as private;
            - protected static Map<String, Object> createConversionContext(HttpServletRequest request)
            - protected static Date getLastModifiedDate(HttpServletRequest request) throws GenericEntityException
            - protected static boolean isValidRequest(HttpServletRequest request, HttpServletResponse response) throws IOException 
            - protected static void logInUser(HttpServletRequest request, HttpServletResponse response) throws GenericServiceException, GenericEntityException
            - protected static void setupRequest(HttpServletRequest request, HttpServletResponse response)
            - protected static void writeResponse(ResponseProperties responseProps, HttpServletRequest request, HttpServletResponse response, ServletContext context) throws IOException
        
      1. OFBIZ-7982.patch
        4 kB
        Rohit Koushal

        Activity

        Hide
        rohit.koushal Rohit Koushal added a comment -

        Thanks Rishi Solanki for the details. Here is the patch for the issue.

        Show
        rohit.koushal Rohit Koushal added a comment - Thanks Rishi Solanki for the details. Here is the patch for the issue.
        Hide
        arunpati Arun Patidar added a comment -

        Committed changes in trunk at rev: 1757986.

        Thanks Rishi Solanki and Rohit Koushal for your contribution.

        Show
        arunpati Arun Patidar added a comment - Committed changes in trunk at rev: 1757986. Thanks Rishi Solanki and Rohit Koushal for your contribution.

          People

          • Assignee:
            arunpati Arun Patidar
            Reporter:
            rishisolankii Rishi Solanki
          • Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development

                Agile