[SOLR-10778] Address precommit WARNINGS

• Type: Improvement
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 4.6
• Fix Version/s: 8.6
• Component/s: clients - java
• Assignee: Erick Erickson
• Reporter: Andrew Musselman
• Created: 31/May/17 02:01
• Updated: 15/Jul/20 15:11
• Resolved: 25/Jun/20 21:20

Description

During precommit we are seeing lots of warnings. Im turning this into an umbrella issue about getting precommit warnings out of the code in general. Yes, this will take a while.

See SOLR-10809 for getting all warnings out of solr/core. I want to selectively have precommit fail when "some part" of the code is clean so we don't backslide, and solr/core was the finest granularity I could see how to change.

If you read more of the comments here, you can see that there are some serious code refactoring that could be done. I'm electing to simply SuppressWarnings rather than re-arrange code at this point whenever the code is tricky. If anyone goes back in and tries to clean the code up, then can remove the annotation(s).

Issue Links

• incorporates: SOLR-11973 Fail compilation on warnings
• is a child of: SOLR-10810 Examine precommit lint WARNINGs in non-test code
• is a child of: SOLR-10809 Get precommit lint warnings out of Solr core
• is related to: LUCENE-9394 Fix or suppress compile-time warnings
• is related to: SOLR-10779 JavaBinCodec should use close consistently rather than having marshal() and close() call finish() (which closes the underlying stream)
• is related to: LUCENE-7907 Ant precommit task WARNINGS about unclosed resources
• relates to: LUCENE-9143 Add more static analysis and clean up resulting warnings/errors

Sub-Tasks

• suppress 2 Resource Leak warnings in ExpandComponent: Resolved
• fix three Resource Leak warnings (JavaBinCodec not being closed): Closed
• fix-or-suppress 18 'Resource leak' warnings in StreamExpressionToExpessionTest.java: Resolved
• fix 2 javac warnings: [dep-ann] deprecated item is not annotated with @Deprecated: Closed
• Fix 7 Varargs methods should only override or be overridden by other varargs methods warnings: Closed
• Fix 20 Resource Leak warnings in apache/solr/common: Closed
• Fix or suppress 14 resource leak warnings in apache/solr/core: Closed
• Fix remaining auxilliary class warnings in Solr: Closed
• Fix or suppress warnings in solr/analysis: Resolved
• Fix or suppress warnings in solr/cloud/api: Closed
• Fix or suppress warnings in solr/search/facet: Closed
• Fix or suppress 11 resource leak warnings in apache/solr/cloud: Closed
• Fix or suppress warnings in solr/search/function: Closed
• Fix or suppress warnings in solr/cloud/autoscaling/: Closed
• fix or suppress warnings in apache/solr/core: Closed
• Fix or suppress warnings in solr/handler/admin: Closed
• Investigate cleaning up any remaining warnings in 8x: Resolved
• Fix or suppress warnings in apache/solr/handler/component, sql and loader: Closed
• Fix or suppress warnings in apache/solr/common: Closed
• Fix or suppress remaining warnings in apache/solr/handler: Closed
• Ensure classes that implement equals implement hashCode or suppress warnings: Closed
• Fix or suppress warnings in solr/handler/dataimport: Closed
• Fix or suppress warnings in apache/solr/search: Closed
• Fix or suppress warnings in solr/client/solrj/io/eval: Closed
• Fix or suppress warnings in apache/solr/update: Closed
• Fix or suppress warnings in solr/client/solrj/io/stream: Closed
• Address warning: static member should be qualified by type name: Closed
• Fix or suppress warnings in solr/test-framework: Closed
• Fix or suppress warnings in solrj/cloud/autoscaling: Closed
• Fix or suppress warnings in solr/core/src/java/org/apache/solr/util, response, cloud, security, schema, api: Closed
• Fix or suppress warnings in solr/contrib: Closed
• Fix or suppress remaining warnings in solr/core: Closed
• Fix or suppress warnings in solrj/impl and solrj/io/graph: Closed
• Fix or suppress remaining warnings in solrj: Closed
• Fix or suppress warnings in solrj/src/test: Closed
• Fix or suppress warnings in solr/core/src/test: Closed
• Move JoinQuery in JoinQParserPlugin to its own class: Resolved