Uploaded image for project: 'Solr'
  1. Solr
  2. SOLR-10779

JavaBinCodec should use close consistently rather than having marshal() and close() call finish() (which closes the underlying stream)

    XMLWordPrintableJSON

Details

    • Improvement
    • Status: Resolved
    • Major
    • Resolution: Fixed
    • None
    • 7.0
    • None
    • None

    Description

      Having the marshal() code call finish which in turn calls close() is trappy. The marshal code is not robust anyway since if there's an exception before the try loop, it will not close the resource.

      Sub task of SOLR-10778

      Attachments

        1. SOLR-10779.patch
          27 kB
          Erick Erickson
        2. SOLR-10779.patch
          27 kB
          Erick Erickson
        3. SOLR-10779.patch
          27 kB
          Erick Erickson

        Issue Links

          Activity

            People

              erickerickson Erick Erickson
              erickerickson Erick Erickson
              Votes:
              0 Vote for this issue
              Watchers:
              5 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: