Uploaded image for project: 'Solr'
  1. Solr
  2. SOLR-10778

Address precommit WARNINGS

    XMLWordPrintableJSON

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 4.6
    • Fix Version/s: 8.6
    • Component/s: clients - java
    • Labels:
      None

      Description

      During precommit we are seeing lots of warnings. Im turning this into an umbrella issue about getting precommit warnings out of the code in general. Yes, this will take a while.

      See SOLR-10809 for getting all warnings out of solr/core. I want to selectively have precommit fail when "some part" of the code is clean so we don't backslide, and solr/core was the finest granularity I could see how to change.

      If you read more of the comments here, you can see that there are some serious code refactoring that could be done. I'm electing to simply SuppressWarnings rather than re-arrange code at this point whenever the code is tricky. If anyone goes back in and tries to clean the code up, then can remove the annotation(s).

        Attachments

        1. notclosed.txt
          391 kB
          Erick Erickson
        2. dated-warnings.log
          52 kB
          Christine Poerschke
        3. dated-warnings
          0.7 kB
          Christine Poerschke

          Issue Links

          1.
          suppress 2 Resource Leak warnings in ExpandComponent Sub-task Resolved Christine Poerschke  
          2.
          fix three Resource Leak warnings (JavaBinCodec not being closed) Sub-task Closed Christine Poerschke  
          3.
          fix-or-suppress 18 'Resource leak' warnings in StreamExpressionToExpessionTest.java Sub-task Resolved Unassigned  
          4.
          fix 2 javac warnings: [dep-ann] deprecated item is not annotated with @Deprecated Sub-task Closed Christine Poerschke  
          5.
          Fix 7 Varargs methods should only override or be overridden by other varargs methods warnings Sub-task Closed Jason Gerlowski  
          6.
          Fix 20 Resource Leak warnings in apache/solr/common Sub-task Closed Tomas Eduardo Fernandez Lobbe  
          7.
          Fix or suppress 14 resource leak warnings in apache/solr/core Sub-task Closed Unassigned  
          8.
          Fix remaining auxilliary class warnings in Solr Sub-task Closed Erick Erickson

          100%

          Original Estimate - Not Specified Original Estimate - Not Specified
          Time Spent - 1h 50m
          9.
          Fix or suppress warnings in solr/analysis Sub-task Resolved Gus Heck  
          10.
          Fix or suppress warnings in solr/cloud/api Sub-task Closed Erick Erickson  
          11.
          Fix or suppress warnings in solr/search/facet Sub-task Closed Erick Erickson

          100%

          Original Estimate - Not Specified Original Estimate - Not Specified
          Time Spent - 1h 20m
          12.
          Fix or suppress 11 resource leak warnings in apache/solr/cloud Sub-task Closed Erick Erickson  
          13.
          Fix or suppress warnings in solr/search/function Sub-task Closed Erick Erickson

          100%

          Original Estimate - Not Specified Original Estimate - Not Specified
          Time Spent - 20m
          14.
          Fix or suppress warnings in solr/cloud/autoscaling/ Sub-task Closed Erick Erickson  
          15.
          fix or suppress warnings in apache/solr/core Sub-task Closed Erick Erickson  
          16.
          Fix or suppress warnings in solr/handler/admin Sub-task Closed Erick Erickson  
          17.
          Investigate cleaning up any remaining warnings in 8x Sub-task Resolved Erick Erickson  
          18.
          Fix or suppress warnings in apache/solr/handler/component, sql and loader Sub-task Closed Erick Erickson  
          19.
          Fix or suppress warnings in apache/solr/common Sub-task Closed Erick Erickson  
          20.
          Fix or suppress remaining warnings in apache/solr/handler Sub-task Closed Erick Erickson  
          21.
          Ensure classes that implement equals implement hashCode or suppress warnings Sub-task Closed Erick Erickson

          100%

          Original Estimate - Not Specified Original Estimate - Not Specified
          Time Spent - 5.5h
          22.
          Fix or suppress warnings in solr/handler/dataimport Sub-task Closed Erick Erickson  
          23.
          Fix or suppress warnings in apache/solr/search Sub-task Closed Erick Erickson  
          24.
          Fix or suppress warnings in solr/client/solrj/io/eval Sub-task Closed Erick Erickson  
          25.
          Fix or suppress warnings in apache/solr/update Sub-task Closed Erick Erickson  
          26.
          Fix or suppress warnings in solr/client/solrj/io/stream Sub-task Closed Erick Erickson  
          27.
          Address warning: static member should be qualified by type name Sub-task Closed Mike Drob

          100%

          Original Estimate - Not Specified Original Estimate - Not Specified
          Time Spent - 20m
          28.
          Fix or suppress warnings in solr/test-framework Sub-task Closed Erick Erickson  
          29.
          Fix or suppress warnings in solrj/cloud/autoscaling Sub-task Closed Erick Erickson  
          30.
          Fix or suppress warnings in solr/core/src/java/org/apache/solr/util, response, cloud, security, schema, api Sub-task Closed Erick Erickson  
          31.
          Fix or suppress warnings in solr/contrib Sub-task Closed Erick Erickson  
          32.
          Fix or suppress remaining warnings in solr/core Sub-task Closed Erick Erickson  
          33.
          Fix or suppress warnings in solrj/impl and solrj/io/graph Sub-task Closed Erick Erickson  
          34.
          Fix or suppress remaining warnings in solrj Sub-task Closed Erick Erickson  
          35.
          Fix or suppress warnings in solrj/src/test Sub-task Closed Erick Erickson  
          36.
          Fix or suppress warnings in solr/core/src/test Sub-task Closed Erick Erickson  
          37.
          Move JoinQuery in JoinQParserPlugin to its own class Sub-task Resolved Atri Sharma

          100%

          Original Estimate - Not Specified Original Estimate - Not Specified
          Time Spent - 40m

            Activity

              People

              • Assignee:
                erickerickson Erick Erickson
                Reporter:
                andrew.musselman Andrew Musselman
              • Votes:
                0 Vote for this issue
                Watchers:
                9 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:

                  Time Tracking

                  Estimated:
                  Original Estimate - Not Specified
                  Not Specified
                  Remaining:
                  Remaining Estimate - 0h
                  0h
                  Logged:
                  Time Spent - 10h
                  10h