Uploaded image for project: 'Solr'
  1. Solr
  2. SOLR-10778

Address precommit WARNINGS

    XMLWordPrintableJSON

    Details

    • Type: Improvement
    • Status: Open
    • Priority: Minor
    • Resolution: Unresolved
    • Affects Version/s: 4.6
    • Fix Version/s: None
    • Component/s: clients - java
    • Labels:
      None

      Description

      During precommit we are seeing lots of warnings. Im turning this into an umbrella issue about getting precommit warnings out of the code in general. Yes, this will take a while.

      See SOLR-10809 for getting all warnings out of solr/core. I want to selectively have precommit fail when "some part" of the code is clean so we don't backslide, and solr/core was the finest granularity I could see how to change.

      If you read more of the comments here, you can see that there are some serious code refactoring that could be done. I'm electing to simply SuppressWarnings rather than re-arrange code at this point whenever the code is tricky. If anyone goes back in and tries to clean the code up, then can remove the annotation(s).

        Attachments

        1. notclosed.txt
          391 kB
          Erick Erickson
        2. dated-warnings
          0.7 kB
          Christine Poerschke
        3. dated-warnings.log
          52 kB
          Christine Poerschke

          Issue Links

            Activity

              People

              • Assignee:
                erickerickson Erick Erickson
                Reporter:
                andrew.musselman Andrew Musselman
              • Votes:
                0 Vote for this issue
                Watchers:
                9 Start watching this issue

                Dates

                • Created:
                  Updated: