[SOLR-14266] Fix or suppress 14 resource leak warnings in apache/solr/core

• Type: Sub-task
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Fix Version/s: 8.6
• Assignee: Unassigned
• Reporter: Andras Salamon
• Created: 18/Feb/20 13:33
• Updated: 15/Jul/20 15:10
• Resolved: 12/May/20 02:05

Description

There are 14 resource leak warnings in apache/solr/common:

[ecj-lint] 10. WARNING in /Users/andrassalamon/src/lucene-solr-upstream/solr/core/src/java/org/apache/solr/core/CoreContainer.java (at line 745)
 [ecj-lint]     SolrFieldCacheBean fieldCacheBean = new SolrFieldCacheBean();
 [ecj-lint]                        ^^^^^^^^^^^^^^
 [ecj-lint] Resource leak: 'fieldCacheBean' is never closed
--
 [ecj-lint] 5. WARNING in /Users/andrassalamon/src/lucene-solr-upstream/solr/core/src/test/org/apache/solr/core/ResourceLoaderTest.java (at line 215)
 [ecj-lint]     SolrResourceLoader loader = new SolrResourceLoader();
 [ecj-lint]                        ^^^^^^
 [ecj-lint] Resource leak: 'loader' is never closed
--
 [ecj-lint] 6. WARNING in /Users/andrassalamon/src/lucene-solr-upstream/solr/core/src/test/org/apache/solr/core/TestLazyCores.java (at line 244)
 [ecj-lint]     MetricsHandler handler = new MetricsHandler(h.getCoreContainer());
 [ecj-lint]                    ^^^^^^^
 [ecj-lint] Resource leak: 'handler' is never closed
--
 [ecj-lint] 7. WARNING in /Users/andrassalamon/src/lucene-solr-upstream/solr/core/src/test/org/apache/solr/core/TestLazyCores.java (at line 364)
 [ecj-lint]     final CoreAdminHandler admin = new CoreAdminHandler(cc);
 [ecj-lint]                            ^^^^^
 [ecj-lint] Resource leak: 'admin' is never closed
--
 [ecj-lint] 8. WARNING in /Users/andrassalamon/src/lucene-solr-upstream/solr/core/src/test/org/apache/solr/core/TestLazyCores.java (at line 378)
 [ecj-lint]     final CoreAdminHandler admin = new CoreAdminHandler(cc);
 [ecj-lint]                            ^^^^^
 [ecj-lint] Resource leak: 'admin' is never closed
--
 [ecj-lint] 9. WARNING in /Users/andrassalamon/src/lucene-solr-upstream/solr/core/src/test/org/apache/solr/core/TestLazyCores.java (at line 638)
 [ecj-lint]     final CoreAdminHandler admin = new CoreAdminHandler(cc);
 [ecj-lint]                            ^^^^^
 [ecj-lint] Resource leak: 'admin' is never closed
--
 [ecj-lint] 10. WARNING in /Users/andrassalamon/src/lucene-solr-upstream/solr/core/src/test/org/apache/solr/core/backup/repository/HdfsBackupRepositoryTest.java (at line 32)
 [ecj-lint]     HdfsBackupRepository hdfsBackupRepository = new HdfsBackupRepository();
 [ecj-lint]                          ^^^^^^^^^^^^^^^^^^^^
 [ecj-lint] Resource leak: 'hdfsBackupRepository' is never closed
--
 [ecj-lint] 11. WARNING in /Users/andrassalamon/src/lucene-solr-upstream/solr/core/src/test/org/apache/solr/core/backup/repository/HdfsBackupRepositoryTest.java (at line 39)
 [ecj-lint]     HdfsBackupRepository hdfsBackupRepository = new HdfsBackupRepository();
 [ecj-lint]                          ^^^^^^^^^^^^^^^^^^^^
 [ecj-lint] Resource leak: 'hdfsBackupRepository' is never closed
--
 [ecj-lint] 12. WARNING in /Users/andrassalamon/src/lucene-solr-upstream/solr/core/src/test/org/apache/solr/core/backup/repository/HdfsBackupRepositoryTest.java (at line 47)
 [ecj-lint]     HdfsBackupRepository hdfsBackupRepository = new HdfsBackupRepository();
 [ecj-lint]                          ^^^^^^^^^^^^^^^^^^^^
 [ecj-lint] Resource leak: 'hdfsBackupRepository' is never closed
--
 [ecj-lint] 13. WARNING in /Users/andrassalamon/src/lucene-solr-upstream/solr/core/src/test/org/apache/solr/core/backup/repository/HdfsBackupRepositoryTest.java (at line 55)
 [ecj-lint]     HdfsBackupRepository hdfsBackupRepository = new HdfsBackupRepository();
 [ecj-lint]                          ^^^^^^^^^^^^^^^^^^^^
 [ecj-lint] Resource leak: 'hdfsBackupRepository' is never closed
--
 [ecj-lint] 14. WARNING in /Users/andrassalamon/src/lucene-solr-upstream/solr/core/src/test/org/apache/solr/core/backup/repository/HdfsBackupRepositoryTest.java (at line 63)
 [ecj-lint]     HdfsBackupRepository hdfsBackupRepository = new HdfsBackupRepository();
 [ecj-lint]                          ^^^^^^^^^^^^^^^^^^^^
 [ecj-lint] Resource leak: 'hdfsBackupRepository' is never closed
--
 [ecj-lint] 15. WARNING in /Users/andrassalamon/src/lucene-solr-upstream/solr/core/src/test/org/apache/solr/core/backup/repository/HdfsBackupRepositoryTest.java (at line 71)
 [ecj-lint]     HdfsBackupRepository hdfsBackupRepository = new HdfsBackupRepository();
 [ecj-lint]                          ^^^^^^^^^^^^^^^^^^^^
 [ecj-lint] Resource leak: 'hdfsBackupRepository' is never closed
--
 [ecj-lint] 16. WARNING in /Users/andrassalamon/src/lucene-solr-upstream/solr/core/src/test/org/apache/solr/core/backup/repository/HdfsBackupRepositoryTest.java (at line 79)
 [ecj-lint]     HdfsBackupRepository hdfsBackupRepository = new HdfsBackupRepository();
 [ecj-lint]                          ^^^^^^^^^^^^^^^^^^^^
 [ecj-lint] Resource leak: 'hdfsBackupRepository' is never closed
--
 [ecj-lint] 17. WARNING in /Users/andrassalamon/src/lucene-solr-upstream/solr/core/src/test/org/apache/solr/core/backup/repository/HdfsBackupRepositoryTest.java (at line 89)
 [ecj-lint]     HdfsBackupRepository hdfsBackupRepository = new HdfsBackupRepository();
 [ecj-lint]                          ^^^^^^^^^^^^^^^^^^^^
 [ecj-lint] Resource leak: 'hdfsBackupRepository' is never closed