Uploaded image for project: 'Solr'
  1. Solr
  2. SOLR-10778 Address precommit WARNINGS
  3. SOLR-14042

Fix 7 Varargs methods should only override or be overridden by other varargs methods warnings

    XMLWordPrintableJSON

    Details

    • Type: Sub-task
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: master (9.0), 8.5
    • Component/s: None
    • Labels:
      None

      Description

      Precommit lists 7 quite similar varargs related warnings:

      [ecj-lint] 1. WARNING in /Users/andrassalamon/src/lucene-solr-upstream/solr/solrj/src/java/org/apache/solr/client/solrj/io/eval/ConcatEvaluator.java (at line 46)
       [ecj-lint]     public Object doWork(Object values[]) throws IOException {
       [ecj-lint]                   ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
       [ecj-lint] Varargs methods should only override or be overridden by other varargs methods unlike ConcatEvaluator.doWork(Object[]) and ManyValueWorker.doWork(Object...)
      --
       [ecj-lint] 2. WARNING in /Users/andrassalamon/src/lucene-solr-upstream/solr/solrj/src/java/org/apache/solr/client/solrj/io/eval/DateEvaluator.java (at line 44)
       [ecj-lint]     public Object doWork(Object values[]) throws IOException {
       [ecj-lint]                   ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
       [ecj-lint] Varargs methods should only override or be overridden by other varargs methods unlike DateEvaluator.doWork(Object[]) and ManyValueWorker.doWork(Object...)
      --
       [ecj-lint] 3. WARNING in /Users/andrassalamon/src/lucene-solr-upstream/solr/solrj/src/java/org/apache/solr/client/solrj/io/eval/DbscanEvaluator.java (at line 44)
       [ecj-lint]     public Object doWork(Object values[]) throws IOException {
       [ecj-lint]                   ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
       [ecj-lint] Varargs methods should only override or be overridden by other varargs methods unlike DbscanEvaluator.doWork(Object[]) and ManyValueWorker.doWork(Object...)
      --
       [ecj-lint] 4. WARNING in /Users/andrassalamon/src/lucene-solr-upstream/solr/solrj/src/java/org/apache/solr/client/solrj/io/eval/EmpiricalDistributionEvaluator.java (at line 41)
       [ecj-lint]     public Object doWork(Object[] values) throws IOException {
       [ecj-lint]                   ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
       [ecj-lint] Varargs methods should only override or be overridden by other varargs methods unlike EmpiricalDistributionEvaluator.doWork(Object[]) and ManyValueWorker.doWork(Object...)
      --
       [ecj-lint] 5. WARNING in /Users/andrassalamon/src/lucene-solr-upstream/solr/solrj/src/java/org/apache/solr/client/solrj/io/eval/MatchesEvaluator.java (at line 39)
       [ecj-lint]     public Object doWork(Object[] values) throws IOException {
       [ecj-lint]                   ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
       [ecj-lint] Varargs methods should only override or be overridden by other varargs methods unlike MatchesEvaluator.doWork(Object[]) and ManyValueWorker.doWork(Object...)
      --
       [ecj-lint] 6. WARNING in /Users/andrassalamon/src/lucene-solr-upstream/solr/solrj/src/java/org/apache/solr/client/solrj/io/eval/MatchesEvaluator.java (at line 39)
       [ecj-lint]     public Object doWork(Object[] values) throws IOException {
       [ecj-lint]                   ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
       [ecj-lint] Varargs methods should only override or be overridden by other varargs methods unlike MatchesEvaluator.doWork(Object[]) and RecursiveBooleanEvaluator.doWork(Object...)
      --
       [ecj-lint] 7. WARNING in /Users/andrassalamon/src/lucene-solr-upstream/solr/solrj/src/java/org/apache/solr/client/solrj/io/eval/PivotEvaluator.java (at line 45)
       [ecj-lint]     public Object doWork(Object[] values) throws IOException {
       [ecj-lint]                   ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
       [ecj-lint] Varargs methods should only override or be overridden by other varargs methods unlike PivotEvaluator.doWork(Object[]) and ManyValueWorker.doWork(Object...) 

        Attachments

        1. SOLR-14042-01.patch
          4 kB
          Andras Salamon

          Activity

            People

            • Assignee:
              gerlowskija Jason Gerlowski
              Reporter:
              asalamon74 Andras Salamon
            • Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: