[FINERACT-712] Fineract codebase should pass PMD, Findbugs and Checkstyle analysis

• Type: Improvement
• Status: Closed
• Priority: Major
• Resolution: Auto Closed
• Labels: Cleanup2022 gsoc2019
• Assignee: Unassigned
• Reporter: Vishwas Babu A J
• Created: 01/Mar/19 08:49
• Updated: 07/Nov/22 18:11
• Resolved: 07/Nov/22 18:11

Description

The fineract codebase has findbugs (now spotbugs) and PMD gradle plugins, however, the ignoreFailures option is enabled on the gradle file. Disabling the same and fixing current errors is crucial for the long term maintainability of the Fineract project.

Another good to have would be checkstyle analysis.

Issue Links

• Blocked: FINERACT-865 Strengthen/Harden Fineract 1.x to LTS Version by Upgrading Java & Improving Code Coverage of Tests
• is blocked by: FINERACT-989 SpotBugs problems (no longer) show up in build failures
• is blocked by: FINERACT-981 Enable Codacy on Fineract
• is blocked by: FINERACT-821 Enable and enforce (!) Checkstyle in Fineract
• is blocked by: FINERACT-822 Enable and enforce (!) Google's Error Prone quality check tool in Fineract
• is blocked by: FINERACT-823 Use Modernizer Java API quality checker tool
• is blocked by: FINERACT-942 Make Checkstyle detect bad logging anti-patterns (and fix problems found)
• is blocked by: FINERACT-947 Upgrade Spotbugs plugin from 2.0.1 to latest 4.0.8
• is blocked by: FINERACT-959 Tighten javac compilerArgs, turn more warnings into errors (and fix related problems)
• is required by: FINERACT-696 use SpotBugs and findbugs-slf4j to detect bad logging anti-patterns
• is required by: FINERACT-702 Integrate SpotBugs and fail build if equals but not hashCode is implemented
• relates to: FINERACT-853 Use find-sec-bugs SpotBugs plugin to detect SQL injection issues (and other security related problems)

Sub-Tasks

• Enable and Enforce PMD on Fineract: Open