Uploaded image for project: 'Apache Fineract'
  1. Apache Fineract
  2. FINERACT-942

Make Checkstyle detect bad logging anti-patterns (and fix problems found)

    XMLWordPrintableJSON

Details

    • Improvement
    • Status: Resolved
    • Major
    • Resolution: Fixed
    • None
    • 1.4.0
    • None
    • None

    Description

      A particularly useful part of FINERACT-821, helping to detect real errors in Fineract and not just formating, would be to enable the following in fineract-provider/config/checkstyle/checkstyle.xml, and fix any problems that this finds:

      1. RegexpSinglelineJava / printStackTrace

      2. IllegalCatch, IllegalThrows, MutableException, AvoidHidingCauseExceptionCheck

      3. EmptyCatchBlock

      Nota bene that we already have FINERACT-696, but this is complementary to that.

      One thing this should detect is e.g. the bad wrong emtpy catch(MessagingException e) in EmailMessageJobEmailServiceImpl.

      It may lead to more of FINERACT-932, which would be a Good Thing.

      Attachments

        Issue Links

          blocks

          Improvement - An improvement or enhancement to an existing feature or task. FINERACT-712 Fineract codebase should pass PMD, Findbugs and Checkstyle analysis

          • Major - Major loss of function.
          • Closed
          is part of

          Improvement - An improvement or enhancement to an existing feature or task. FINERACT-821 Enable and enforce (!) Checkstyle in Fineract

          • Major - Major loss of function.
          • Resolved
          is related to

          Improvement - An improvement or enhancement to an existing feature or task. FINERACT-1131 Add Checkstyle IllegalCatch

          • Minor - Minor loss of function, or other problem where easy workaround is present.
          • Open

          Improvement - An improvement or enhancement to an existing feature or task. FINERACT-696 use SpotBugs and findbugs-slf4j to detect bad logging anti-patterns

          • Major - Major loss of function.
          • Resolved
          is required by

          Improvement - An improvement or enhancement to an existing feature or task. FINERACT-932 Parent Issue for Error Logs seeing during "normal" usage (e.g. on fineract.dev)

          • Blocker - Blocks development and/or testing work, production could not run
          • Open
          links to

          Web Link GitHub Pull Request #891

          Web Link GitHub Pull Request #906

          Web Link GitHub Pull Request #912

          Web Link GitHub Pull Request #916

          Web Link GitHub Pull Request #1037

          Web Link GitHub Pull Request #1079

          Web Link GitHub Pull Request #1087

          Web Link GitHub Pull Request #1107

          Activity

            People

              manthan Manthan Surkar
              vorburger Michael Vorburger
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: