Details
-
Improvement
-
Status: Resolved
-
Major
-
Resolution: Fixed
-
None
-
None
-
None
Description
As tracked in overall FINERACT-712, similarly to SpotBugs (FINERACT-702), PMD and Checkstyle (FINERACT-821), I would suggest that we also enable and enforce Error Prone quality check tool in Fineract to catch any obvious programming error bugs.
Error Prone is extensively used inside Google private code base, has been open sourced, and is meanwhile popular in many open source projects as well (see other Apache projects' use). More information is available on https://errorprone.info and https://github.com/google/error-prone.
I have spent a fair amount of time in a past life on a project (which I'm currently no longer actively invoved in) to refine a what I believe to be "good" Error Prone rule set, we could reuse this for Fineract (it's EPL licensed, so copy/pasting it is perfectly fine), see https://github.com/opendaylight/infrautils/blob/master/common/parent/pom.xml
Attachments
Issue Links
- blocks
-
FINERACT-712 Fineract codebase should pass PMD, Findbugs and Checkstyle analysis
- Closed
- is related to
-
FINERACT-1130 Add ErrorProne's TypeParameterUnusedInFormals
- Open
- is required by
-
FINERACT-1014 From/To Amount Range and Period Validatation broken
- Resolved
- relates to
-
FINERACT-1075 Error Prone: Enable JdkObsolete Check
- Resolved
-
FINERACT-1076 Error Prone: Enable Var Check
- Closed
- requires
-
FINERACT-937 Use Java 11 instead of 12 use on Travis
- Resolved
- links to