[FINERACT-696] use SpotBugs and findbugs-slf4j to detect bad logging anti-patterns

• Type: Improvement
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 1.4.0
• Component/s: Build
• Labels: beginner starter
• Assignee: Yemdjih Kaze Nasser
• Reporter: Michael Vorburger
• Created: 05/Feb/19 12:47
• Updated: 08/May/20 13:25
• Resolved: 28/Mar/20 16:46

Description

 While code reviewing https://github.com/apache/fineract/pull/464, I came accross a catch & printStackTrace, which is of course wrong (it should instead be, correctly, logged, instead).

In an ideal world, it would not take human code review to catch this, but just an automated build failure. This is possible using SpotBugs (not FindBugs anymore; SpotBugs is the new FindBugs, it's a fully compatible successor)  and https://github.com/KengoTODA/findbugs-slf4j/ (for this particular case https://github.com/KengoTODA/findbugs-slf4j/issues/70, but using findbugs-slf4j for Fineract would have value even before that's implemented).

myrle you mentioned at FOSDEMO that you had hordes of volunteers just waiting to have issues to working on (I'm joking) - so I was wondering if perhaps you knew of anyone who would be willing to work on this one?

Issue Links

• relates to: FINERACT-942 Make Checkstyle detect bad logging anti-patterns (and fix problems found)
• requires: FINERACT-697 github.com/apache/fineract has no CI to validate PRs
• requires: FINERACT-702 Integrate SpotBugs and fail build if equals but not hashCode is implemented
• requires: FINERACT-712 Fineract codebase should pass PMD, Findbugs and Checkstyle analysis
• links to: GitHub Pull Request #716