[FINERACT-702] Integrate SpotBugs and fail build if equals but not hashCode is implemented

• Type: Improvement
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 1.4.0
• Labels: starter
• Assignee: Awasum Yannick
• Reporter: Michael Vorburger
• Created: 15/Feb/19 22:54
• Updated: 14/Jan/20 07:49
• Resolved: 14/Jan/20 07:49

Description

This project should activate SpotBugs (the successor to FindBugs) and make it fail the build for any violations to a at least a subset of rules which are almost always guaranteed to be bugs.

For example, https://spotbugs.readthedocs.io/en/stable/bugDescriptions.html#he-class-defines-equals-and-uses-object-hashcode-he-equals-use-hashcode which would have caught what I manually spotted (but shouldn't have to) in https://github.com/apache/fineract/pull/524.

FINERACT-402 has some history, but it's clearly not activated to enforce.

FINERACT-696 could then be built on top of this.

myrle perhaps you know of any volunteer interested in doing this?

Issue Links

• is blocked by: FINERACT-700 Upgrade ancient version of Gradle
• is related to: FINERACT-827 ShareAccountCharge is missing hashCode() & equals() but adding it fails ShareAccountIntegrationTests
• is required by: FINERACT-696 use SpotBugs and findbugs-slf4j to detect bad logging anti-patterns
• requires: FINERACT-712 Fineract codebase should pass PMD, Findbugs and Checkstyle analysis
• links to: GitHub Pull Request #670
• links to: GitHub Pull Request #673
• links to: GitHub Pull Request #682
• links to: GitHub Pull Request #684
• links to: GitHub Pull Request #685