[CASSANDRA-18255] Drop JDK8 Support

• Type: Task
• Status: Resolved
• Priority: High
• Resolution: Fixed
• Fix Version/s: 5.0-alpha1, 5.0
• Component/s: Build
• Epic Link: Support Java 17
• Change Category: Operability
• Complexity: Normal
• Platform: All

Source Control Link

https://github.com/apache/cassandra/commit/3755934e5224a6e9f826a0a594d415c36465d449 https://github.com/apache/cassandra/commit/02f6353e1fe0d63f186be6fda5e01e641459d180 https://github.com/apache/cassandra/commit/5722191a38132c3bc8e1ece6e9a6fa2b5bdbd9db

Test and Documentation Plan

1) Cassandra builds - https://github.com/ekaterinadimitrova2/cassandra-builds/commit/643c664b2da194bd80131423f27aa7bb38c13499

2) Cassandra - https://github.com/apache/cassandra/compare/trunk...ekaterinadimitrova2:cassandra:18255-trunk

TODO: add JVM args for NetBeans and eclipse tasks (those tasks were working only with JDK8); 

3) CCM - https://github.com/ekaterinadimitrova2/ccm/commit/20a3f6221d950832ebf8a4fe935084d52e6851c4

CircleCI run #2424 looks good - https://app.circleci.com/pipelines/github/ekaterinadimitrova2/cassandra?branch=18255-trunk

I will have to spin also local Jenkins and test. I suspect there should be more places to apply changes to in Cassandra-builds

 

Eclipse and NetBeans JVM args for JDK 11 and 17 will be handled in a separate ticket.

• Assignee: Ekaterina Dimitrova
• Reporter: Michael Semb Wever

Authors

Ekaterina Dimitrova

Reviewers

Berenguer Blasi, Jacek Lewandowski, Jeremiah Jordan, Michael Semb Wever

• Created: 10/Feb/23 07:00
• Updated: 12/Sep/23 13:03
• Resolved: 25/Jul/23 01:40

Description

• update Jenkins builds scripts (Cassandra-builds) for trunk to build and run tests only with JDK 11 and JDK 17 - both Jenkins-dev and post-commit
• the JDK11+17 config files and script in cassandra/.circleci should replace the default J8+J11 test config files and script
• Cassandra trunk build.xml and conf files should be updated - JDK8 removed everywhere
• Any tickets blocked on this one and ready to commit should be committed
• Revert this change in CCM - https://github.com/riptano/ccm/commit/6e71061146f7ae67b84ccd2b1d90d7319b640e4c#diff-0999a90fd83b66b6840af0bbd8afd1ebd9648e135b0665692fa0f523325a1058L984
• Docs will be updated later in CASSANDRA-18233

NOTE: Python Upgrade tests were already switched to 11 in this change, so I think there is no other change pending in cassandra-dtest repo

Issue Links

• blocks: CASSANDRA-17909 Clean SyncUtil from dead code and update it for new JDK versions
• blocks: CASSANDRA-18180 bulkLoaderSuccessfullyStreamsOverSsl fails with ClassCastException on JDK17
• blocks: CASSANDRA-18640 Add vector similarity functions
• blocks: CASSANDRA-18190 ECJ upgrade
• causes: CASSANDRA-18817 RPM install does not work with jdk17
• is blocked by: CASSANDRA-18423 Test failure: org.apache.cassandra.io.sstable.indexsummary.IndexSummaryTest.testLargeIndexSummary
• is blocked by: CASSANDRA-16304 [jamm] Consider implementing ClusteringComparator without a lambda
• is blocked by: CASSANDRA-17869 Add JDK17 option to cassandra-builds (build-scripts and jenkins dsl) and on jenkins agents
• is blocked by: CASSANDRA-18179 Update build.xml for experimental JDK17 use
• is blocked by: CASSANDRA-18190 ECJ upgrade
• is blocked by: CASSANDRA-18247 Add CircleCI config files for J11+J17
• is blocked by: CASSANDRA-18252 Remove Scripted UDFs from trunk to enable easier JDK17 testing on current trunk
• is blocked by: CASSANDRA-18262 Switch checkstyle running only with JDK8 to be run with JDK11
• is blocked by: CASSANDRA-18285 [CircleCI] Add JDK 11 Java and Python upgrade tests in trunk
• is blocked by: CASSANDRA-18329 Upgrade jamm; fix eclipse problems
• relates to: CASSANDRA-18233 Modify docs for JDK17 implementation
• relates to: CASSANDRA-18687 Add jvmargs for Netbeans and Eclipse for JDK11 and 17
• relates to: CASSANDRA-18688 Limit Java runtime in 5.1 to JDK 11 and 17 in scripts; add a flag to opt out of that
• Testing discovered: CASSANDRA-18685 Test failure: StandaloneSplitterWithCQLTesterTest/testSplittingMultipleSSTables_cdc_jdk17