[CASSANDRA-16304] [jamm] Consider implementing ClusteringComparator without a lambda

• Type: Task
• Status: Resolved
• Priority: Normal
• Resolution: Duplicate
• Fix Version/s: 5.0-alpha1, 5.0
• Component/s: Jamm
• Epic Link: Support Java 17
• Change Category: Operability
• Complexity: Normal
• Platform: All
• Assignee: Unassigned
• Reporter: Adrian Cole
• Created: 27/Nov/20 02:30
• Updated: 12/Sep/23 13:02
• Resolved: 26/Jul/23 18:29

Description

Using lambdas forces jamm to do things that can easily break. It might be safer to implement things like ClusteringComparator directly as classes or as an enum

Unexpected exception during request (org.apache.cassandra.transport.messages.ErrorMessage)
java.lang.UnsupportedOperationException: can't get field offset on a hidden class: private final org.apache.cassandra.db.ClusteringComparator org.apache.cassandra.db.ClusteringComparator$$Lambda$165/0x000000010028ab60.arg$1
	at jdk.unsupported/sun.misc.Unsafe.objectFieldOffset(Unknown Source)
	at org.github.jamm.MemoryLayoutSpecification.sizeOfInstanceWithUnsafe(MemoryLayoutSpecification.java:108)
	at org.github.jamm.MemoryLayoutSpecification.sizeOfWithUnsafe(MemoryLayoutSpecification.java:89)
	at org.github.jamm.MemoryMeter.measure(MemoryMeter.java:217)
	at org.github.jamm.MemoryMeter.measureDeep(MemoryMeter.java:259)
	at org.apache.cassandra.utils.ObjectSizes.measureDeep(ObjectSizes.java:155)
	at org.apache.cassandra.cql3.QueryProcessor.storePreparedStatement(QueryProcessor.java:454)
	at org.apache.cassandra.cql3.QueryProcessor.prepare(QueryProcessor.java:424)
	at org.apache.cassandra.cql3.QueryProcessor.prepare(QueryProcessor.java:408)
	at org.apache.cassandra.transport.messages.PrepareMessage.execute(PrepareMessage.java:114)
	at org.apache.cassandra.transport.Message$Request.execute(Message.java:253)
	at org.apache.cassandra.transport.Message$Dispatcher.processRequest(Message.java:725)
	at org.apache.cassandra.transport.Message$Dispatcher.lambda$channelRead0$0(Message.java:630)
	at java.base/java.util.concurrent.Executors$RunnableAdapter.call(Unknown Source)
	at org.apache.cassandra.concurrent.AbstractLocalAwareExecutorService$FutureTask.run(AbstractLocalAwareExecutorService.java:162)
	at org.apache.cassandra.concurrent.SEPWorker.run(SEPWorker.java:119)
	at io.netty.util.concurrent.FastThreadLocalRunnable.run(FastThreadLocalRunnable.java:30)
	at java.base/java.lang.Thread.run(Unknown Source)

Issue Links

• blocks: CASSANDRA-18255 Drop JDK8 Support
• is related to: CASSANDRA-18329 Upgrade jamm; fix eclipse problems