[CASSANDRA-18252] Remove Scripted UDFs from trunk to enable easier JDK17 testing on current trunk

• Type: Task
• Status: Resolved
• Priority: Normal
• Resolution: Fixed
• Fix Version/s: 5.0-alpha1, 5.0
• Component/s: Feature/UDF
• Epic Link: Support Java 17
• Change Category: Semantic
• Complexity: Normal
• Platform: All

Source Control Link

Links in comments

Test and Documentation Plan

Cassandra patch - https://github.com/apache/cassandra/pull/2154

Cassandra-dtest repo patch - https://github.com/ekaterinadimitrova2/cassandra-dtest/commit/61c52cbe9d9883791c2d99fead08ab95437e320a

CircleCI run (everything but Python Dtests and CQLSHLIB, there was issue with the Python DTests repo and collecting test names) - https://app.circleci.com/pipelines/github/ekaterinadimitrova2/cassandra?branch=18252-trunk-2

CQLSHLIB tests fixed and successful run here - https://app.circleci.com/pipelines/github/ekaterinadimitrova2/cassandra/2282/workflows/a577f61a-4d2a-46ea-8024-42d5043f316d

Python DTests still running here, I will check back later, hopefully there are no surprises - https://app.circleci.com/pipelines/github/ekaterinadimitrova2/cassandra/2285/workflows/eb1cccf3-b552-457e-a47c-9aa184d44720

So far I am running only one of the JDKs as the changes here are deterministic and a lot of removal

Some tests were reworked to test for Java UDFs instead of JavaScript ones like the auth Python Dtests for example.

• Assignee: Ekaterina Dimitrova
• Reporter: Ekaterina Dimitrova

Authors

Ekaterina Dimitrova

Reviewers

Michael Semb Wever

• Created: 09/Feb/23 15:55
• Updated: 12/Sep/23 13:02
• Resolved: 12/Feb/23 15:40

Description

CASSANDRA-17281 was created to do the work around removing Scripted UDFs 

Seems like adding hooks with the current Sandbox might be non-trivial, considering that it was the reason for removing the hooks for other scripted languages.

Also, Security Manager is deprecated already in Java 17, the current sandbox had also some performance implications. With all that said, this ticket is meant to blindly remove the scripted UDFs and any related tests and CASSANDRA-17281 will be used for any UDF refactoring and addition of scripted UDFs hooks. This will help us to speed up the incremental addition of JDK17 builds and enable people to test directly on trunk instead of having their own modified branches. Feature branch was considered but considering all moving parts that we have to maintain a few different branches in different repos and states it is too time-consuming to maintain.

Supportive ML thread where I will also post the result of this ticket for final confirmation:

https://lists.apache.org/thread/c39yrbdszgz9s34vr17wpjdhv6h2oo61

WARNING: The API for UDFs might change as part of CASSANDRA-17281 where hooks will be introduced for JavaScript UDFs and some additional refactoring is going to happen. This ticket primary goal is to clean the internals and enable people to easily test with JDK17

Issue Links

• blocks: CASSANDRA-18255 Drop JDK8 Support
• blocks: CASSANDRA-17973 Change trunk 4.2 to 5.0
• causes: CASSANDRA-18752 Deal with commented assertion in UFTest#testSchemaChange
• relates to: CASSANDRA-17281 Add hooks for the Javascript UDF to enable people to plugin their own implementations of scripted UDFs