Uploaded image for project: 'Cassandra'
  1. Cassandra
  2. CASSANDRA-17909

Clean SyncUtil from dead code and update it for new JDK versions

    XMLWordPrintableJSON

Details

    • Bug
    • Status: Resolved
    • Normal
    • Resolution: Fixed
    • 5.0-alpha1, 5.0
    • Local/Other
    • None
    • Correctness
    • Normal
    • Normal
    • User Report
    • All
    • None
    • Hide

      Notable changes:

      • old Java 7 and 8 code was removed. This effectively makes this patch commit blocked on CASSANDRA-18255
      • We should not be throwing any more UnsupportedOperationException here. This comment is not applicable anymore since this fix fix in JDK11.

      trunk PR, CI
      I can see only the known failures from the table in CASSANDRA-16895 in CI.

      Show
      Notable changes: old Java 7 and 8 code was removed. This effectively makes this patch commit blocked on CASSANDRA-18255 We should not be throwing any more UnsupportedOperationException here . This comment is not applicable anymore since this fix fix in JDK11. trunk PR , CI I can see only the known failures from the table in CASSANDRA-16895 in CI.

    Description

      During code inspection I noticed dead code (JDK 7) in SyncUtil.

      From a very quick skim I think the Java 8 section is applicable in JDK 11, not sure for JDK 17 but it seems it should stay at least until we have JDK11. To be revisited. 

      Attachments

        Issue Links

          Activity

            People

              e.dimitrova Ekaterina Dimitrova
              e.dimitrova Ekaterina Dimitrova
              Ekaterina Dimitrova
              Jacek Lewandowski
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: