[CASSANDRA-18190] ECJ upgrade

• Type: Task
• Status: Resolved
• Priority: Normal
• Resolution: Fixed
• Fix Version/s: 5.0-alpha1, 5.0
• Component/s: Feature/UDF
• Epic Link: Support Java 17
• Change Category: Operability
• Complexity: Normal
• Platform: All

Source Control Link

https://github.com/apache/cassandra/commit/b61bd93e574503aff8c29f0efefbe9879d3b32eb

Test and Documentation Plan

Replacement of ant eclipse-warnings by a new task using the CheckerFramework is happening as part of CASSANDRA-18239.

Thus, I upgraded ecj to the latest possible version that supports both JDK11 and 17 for the Java UDFs and removed ant eclipse-warnings (including eclipse_compiler.properties). I do not entirely remove the ant target from build.xml. I left a fake empty task to confuse Jenkins as there are ongoing changes for trunk and cassandra-builds, so I decided to make changes there when the concurrent changes related to moving in-tree the build scripts for trunk are done. Though I removed the task from CircleCI as that was quick and easy. I will open a follow-up task for Jenkins. 

I did not find a changelog so I looked into the ECJ changes here - https://github.com/eclipse-jdt/eclipse.jdt.core/compare/R4_6_maintenance...R4_27_maintenance
We will be able to commit the patch to trunk when we drop JDK8 as the new version is JDK11+.
All tests pass. I did minor changes:

• added the new methods of ICompilationUnit to our implementation - ECJCompilationUnit. At this point I think keeping the unnamed module Is fine for us.
• Bumped the version of CompilerOptions to 11
  The compiler has added enablePreviewFeatures, enableJdtDebugCompileMode, ignoreUnnamedModuleForSplit which are false by default. I keep this as I do not believe we want to enable those. I also kept the ReportDeprecations untouched - it is enabled by default.

CI looks good and fixes the two tests that were reported broken with JDK17 as our ECJ version was not supporting JDK17. (org.apache.cassandra.cql3.validation.entities.UFJavaTest, org.apache.cassandra.cql3.validation.entities.UFSecurityTest)
CircleCI run #2380

CI: https://app.circleci.com/pipelines/github/ekaterinadimitrova2/cassandra?branch=18190-udf

PR: https://github.com/apache/cassandra/pull/2429 

I also tested locally the fake task that it completes successfully without running anything.

• Assignee: Ekaterina Dimitrova
• Reporter: Ekaterina Dimitrova

Authors

Ekaterina Dimitrova

Reviewers

Andres de la Peña, Berenguer Blasi

• Created: 23/Jan/23 22:03
• Updated: 12/Sep/23 13:02
• Resolved: 25/Jul/23 01:55

Description

During testing it was identified that we will need to update ECJ for the Java UDF functions in order to bring Java 17 in.

It seems the compiler artifacts are moved from here to here and there is change of license from EPL1.0 to EPL2.0 too. But if I read correctly here that should not affect us

Further testing and review of all changes between artifacts to be done.
ECJ is used for the eclipse-warnings and Java UDFs

As agreed on the dev mailing list we will replace eclipse-warnings in trunk with CheckerFramework equivalent one but better.

So as part of this ticket we are removing ant eclipse-warnings task and upgrading ecj for Java UDFs.

Issue Links

• blocks: CASSANDRA-18255 Drop JDK8 Support
• is blocked by: CASSANDRA-18255 Drop JDK8 Support
• is blocked by: CASSANDRA-18247 Add CircleCI config files for J11+J17
• relates to: CASSANDRA-18239 Replace eclipse warnings based static code analysis with something better (CheckerFramework)