[ZOOKEEPER-835] Refactoring Zookeeper Client Code

• Type: Improvement
• Status: Open
• Priority: Major
• Resolution: Unresolved
• Affects Version/s: 3.3.1
• Component/s: java client
• Tags: Zookeeper client code, refactoring, improvement, client, code
• Assignee: Thomas Koch
• Reporter: Patrick Datko
• Created: 11/Aug/10 14:41
• Updated: 28/Dec/10 04:53

Description

Thomas Koch asked me to fill individual issues for the points raised in his mail to zookeeper-dev:
Mail of Thomas Koch

He published several issues, which are present in the current zookeeper client, so a refactoring of the code would be an facility for other developers working with zookeeper.

Issue Links

• incorporates: ZOOKEEPER-22 Automatic request retries on connect failover
• is blocked by: ZOOKEEPER-277 Define PATH_SEPARATOR
• relates to: ZOOKEEPER-666 Unsafe publication in client API
• relates to: ZOOKEEPER-794 Callbacks are not invoked when the client is closed
• relates to: ZOOKEEPER-823 update ZooKeeper java client to optionally use Netty for connections

Sub-Tasks

• hostlist as string: Resolved
• cyclic dependency ClientCnxn, ZooKeeper: Closed
• Chroot is an attribute of ClientCnxn: Open
• deleteRecursive does not belong to the other methods: Closed
• massive code duplication in zookeeper class: Open
• stat is returned by parameter: Open
• stat calls static method on org.apache.zookeeper.server.DataTree: Open
• Session class?: Open
• Provide Path class: Open
• Cleanups from ZOOKEEPER-823 patch: Open
• finishPacket and conLossPacket should be methods of Packet: Open
• outgoingQueue should be a class: Open
• add Package o.a.zookeeper.client: Open
• Remove code duplication and inconsistent naming in ClientCnxn.Packet creation: Closed
• Use SelectionKey.isXYZ() methods instead of complicated binary logic: Patch Available
• stat parameter in asynchronous getACL() method is superfluous: Open
• Review and refactor Java client close logic: Open