[ZOOKEEPER-910] Use SelectionKey.isXYZ() methods instead of complicated binary logic

• Type: Sub-task
• Status: Resolved
• Priority: Minor
• Resolution: Fixed
• Fix Version/s: 3.10.0, 3.7.3, 3.8.4, 3.9.2
• Component/s: server
• Labels: pull-request-available
• Assignee: Zili Chen
• Reporter: Thomas Koch
• Created: 21/Oct/10 13:43
• Updated: 30/Nov/23 16:34
• Resolved: 30/Nov/23 16:33

Description

The SelectionKey class provides methods to replace something like this

(k.readyOps() & (SelectionKey.OP_READ | SelectionKey.OP_WRITE)) != 0

with

selectionKey.isReadable() || selectionKey.isWritable()

It may be possible, that the first version saves a CPU cycle or two, but the later version saves developer brain cycles which are much more expensive.

I suppose that there are many more places in the server code where this replacement could be done. I propose that whoever touches a code line like this should make the replacement.

Issue Links

• links to: GitHub Pull Request #2063