Details

    • Type: Sub-task Sub-task
    • Status: Patch Available
    • Priority: Minor Minor
    • Resolution: Unresolved
    • Affects Version/s: None
    • Fix Version/s: 3.5.2, 3.6.0
    • Component/s: server
    • Labels:
      None

      Description

      The SelectionKey class provides methods to replace something like this

      (k.readyOps() & (SelectionKey.OP_READ | SelectionKey.OP_WRITE)) != 0

      with

      selectionKey.isReadable() || selectionKey.isWritable()

      It may be possible, that the first version saves a CPU cycle or two, but the later version saves developer brain cycles which are much more expensive.

      I suppose that there are many more places in the server code where this replacement could be done. I propose that whoever touches a code line like this should make the replacement.

      1. ZOOKEEPER-910.patch
        1.0 kB
        Michi Mutsuzaki

        Activity

        Thomas Koch created issue -
        Patrick Hunt made changes -
        Field Original Value New Value
        Assignee Thomas Koch [ thkoch ]
        Component/s server [ 12312382 ]
        Mahadev konar made changes -
        Fix Version/s 3.5.0 [ 12316644 ]
        Fix Version/s 3.4.0 [ 12314469 ]
        Michi Mutsuzaki made changes -
        Assignee Thomas Koch [ thkoch ] Michi Mutsuzaki [ michim ]
        Michi Mutsuzaki made changes -
        Attachment ZOOKEEPER-910.patch [ 12642014 ]
        Michi Mutsuzaki made changes -
        Status Open [ 1 ] Patch Available [ 10002 ]
        Michi Mutsuzaki made changes -
        Priority Major [ 3 ] Minor [ 4 ]
        Patrick Hunt made changes -
        Fix Version/s 3.5.1 [ 12326786 ]
        Fix Version/s 3.5.0 [ 12316644 ]
        Michi Mutsuzaki made changes -
        Fix Version/s 3.5.2 [ 12331981 ]
        Fix Version/s 3.6.0 [ 12326518 ]
        Fix Version/s 3.5.1 [ 12326786 ]

          People

          • Assignee:
            Michi Mutsuzaki
            Reporter:
            Thomas Koch
          • Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:

              Development