Details

      Description

      We should define a constant for PATH_SEPARATOR = "/" and use that throughout the code rather than the hardcoded "/". Users can be told to use this constant to be safe in case of future changes.

        Issue Links

          Activity

          Nitay Joffe created issue -
          Hide
          Patrick Hunt added a comment -

          +1 - sounds fine to me.

          Note for implementor: name the constant something like ZNODE_PATH_SEPARATOR to ensure that ppl understand that this is znode sep (although that's pretty long).

          Also, if this is done it should be done for both java as well as c client binding. Update docs and tests.

          Show
          Patrick Hunt added a comment - +1 - sounds fine to me. Note for implementor: name the constant something like ZNODE_PATH_SEPARATOR to ensure that ppl understand that this is znode sep (although that's pretty long). Also, if this is done it should be done for both java as well as c client binding. Update docs and tests.
          Patrick Hunt made changes -
          Field Original Value New Value
          Component/s java client [ 12312381 ]
          Component/s server [ 12312382 ]
          Component/s tests [ 12312427 ]
          Component/s c client [ 12312380 ]
          Component/s documentation [ 12312422 ]
          Hide
          Nitay Joffe added a comment -

          Should also add some constant, say ZNODE_ANY_VERSION, for accepting any version, that is -1.

          Show
          Nitay Joffe added a comment - Should also add some constant, say ZNODE_ANY_VERSION, for accepting any version, that is -1.
          Mahadev konar made changes -
          Fix Version/s 3.3.0 [ 12313976 ]
          Patrick Hunt made changes -
          Fix Version/s 3.4.0 [ 12314469 ]
          Fix Version/s 3.3.0 [ 12313976 ]
          Thomas Koch made changes -
          Link This issue blocks ZOOKEEPER-835 [ ZOOKEEPER-835 ]
          Hide
          Mahadev konar added a comment -

          not a blocker. Moving it out of 3.4 release.

          Show
          Mahadev konar added a comment - not a blocker. Moving it out of 3.4 release.
          Mahadev konar made changes -
          Fix Version/s 3.5.0 [ 12316644 ]
          Fix Version/s 3.4.0 [ 12314469 ]
          Michi Mutsuzaki made changes -
          Fix Version/s 3.6.0 [ 12326518 ]
          Fix Version/s 3.5.0 [ 12316644 ]

            People

            • Assignee:
              Unassigned
              Reporter:
              Nitay Joffe
            • Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:

                Development