[ZOOKEEPER-908] Remove code duplication and inconsistent naming in ClientCnxn.Packet creation

• Type: Sub-task
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Fix Version/s: 3.4.0
• Component/s: server
• Hadoop Flags: Reviewed
• Assignee: Thomas Koch
• Reporter: Thomas Koch
• Created: 21/Oct/10 10:02
• Updated: 23/Nov/11 19:22
• Resolved: 11/Nov/10 17:14

Description

rename record -> request (since their is a counterpart record named "response")
rename header -> requestHeader (to distinguish from responseHeader)

remove ByteBuffer creation code from primeConnection() method and use the duplicate code in the Packet constructor. Therefor the Bytebuffer bb parameter could also be removed from the constructor's parameters.