[THRIFT-1805] Thrift should not swallow ALL exceptions

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 0.9
• Fix Version/s: 0.11.0
• Component/s: Java - Compiler, Java - Library
• Assignee: Christopher Tubbs
• Reporter: Diwaker Gupta
• Created: 24/Dec/12 18:19
• Updated: 01/Mar/19 01:12
• Resolved: 28/Feb/17 04:41

Description

In Thrift 0.8.0, Thrift generated Java code did not swallow application exceptions. As a result of THRIFT-1658, this behavior changed in 0.9.0 and now the generated code swallows ALL application exceptions (via ProcessFunction). Apparently this was the behavior in Thrift 0.6.0 and while I see the rationale, it is breaking our applications.

Our code relies on the fact that exceptions can propagate outside of Thrift for certain things (e.g., to aggressively drop connections for clients that send invalid/malformed requests). ProcessFunction makes it near impossible to do this – not only does it swallow the exception, it also loses all information about the original exception and just writes out a generic TApplicationException.

IMO ProcessFunction should only catch TException. If the application code wants to use other exceptions for some reason (in particular, Errors and RuntimeExceptions), Thrift shouldn't prevent that.

Issue Links

• blocks: THRIFT-3607 Unify exception handling policy of TProcessor
• breaks: THRIFT-3686 Java processor should report internal error on uncaught exception
• breaks: ACCUMULO-2935 Tests consistently hanging after Thrift 0.9.1
• is related to: ACCUMULO-2950 Fix handling of server-side exceptions
• is related to: THRIFT-3680 Java async processor fails to notify errors to clients
• is related to: THRIFT-4556 Optional rethrow of unhandled exceptions in java processor
• is related to: THRIFT-3607 Unify exception handling policy of TProcessor
• relates to: THRIFT-1658 Java thrift server is not throwing TApplicationException
• links to: GitHub Pull Request #1186