Uploaded image for project: 'Thrift'
  1. Thrift
  2. THRIFT-3607

Unify exception handling policy of TProcessor

    XMLWordPrintableJSON

    Details

    • Type: Improvement
    • Status: Open
    • Priority: Major
    • Resolution: Unresolved
    • Affects Version/s: None
    • Fix Version/s: None
    • Component/s: Wish List
    • Labels:
      None

      Description

      A discussion in THRIFT-1805 uncovered inconsistent error handling behaviors of TProcessors across languages and releases.
      Most outstanding are Java sync and async processors as described there, but others are also subtly different in details.

      I propose unifying the TProcessor behavior by specifying mappings from "uncaught server handler exceptions" to "observable server behaviors" as follows:

      • TApplicationException -> send TApplicationException with the message and the type as thrown
      • TTransportException -> the connection is either already broken or newly broken
      • other exceptions -> send opaque TApplicationException(INTERNAL_ERROR)

      That way users can still arbitrarily disconnect the client by throwing TTransportException.
      (IMO ideally this should have been done by exposing "client context" object to the handler instead)

      The first one can be a bit controversial as it can be regarded as information leak.

      Also some may prefer unifying the TProcessor behavior to catch-all, so that servers never die on handler exceptions.

        Attachments

          Issue Links

            Activity

              People

              • Assignee:
                Unassigned
                Reporter:
                nsuke Nobuaki Sukegawa
              • Votes:
                1 Vote for this issue
                Watchers:
                4 Start watching this issue

                Dates

                • Created:
                  Updated: