Uploaded image for project: 'Tajo'
  1. Tajo
  2. TAJO-1576

Sometimes DefaultTajoCliOutputFormatter.parseErrorMessage() eliminates an important kind of information.

    Details

    • Type: Improvement
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 0.10.0
    • Fix Version/s: 0.11.0, 0.10.1
    • Component/s: SQL Shell
    • Labels:
      None

      Description

      It is related to TAJO-734.

      Currently parseErrorMessage() works in a way which eliminates extra lines except first line.
      But sometimes it may destroy core error information such as error line number.

      1. TAJO-1576_add_test.patch
        2 kB
        Jihoon Son
      2. TAJO-1576.patch
        2 kB
        Jongyoung Park

        Issue Links

          Activity

          Hide
          hudson Hudson added a comment -

          SUCCESS: Integrated in Tajo-master-build #696 (See https://builds.apache.org/job/Tajo-master-build/696/)
          TAJO-1576: Sometimes DefaultTajoCliOutputFormatter.parseErrorMessage() eliminates an important kind of information. (jihoonson: rev e6e1860c8e83f9db6c4c094fe703b21d45d86529)

          • tajo-core/src/test/java/org/apache/tajo/cli/tsql/TestDefaultCliOutputFormatter.java
          • CHANGES
          • tajo-cli/src/main/java/org/apache/tajo/cli/tsql/DefaultTajoCliOutputFormatter.java
          Show
          hudson Hudson added a comment - SUCCESS: Integrated in Tajo-master-build #696 (See https://builds.apache.org/job/Tajo-master-build/696/ ) TAJO-1576 : Sometimes DefaultTajoCliOutputFormatter.parseErrorMessage() eliminates an important kind of information. (jihoonson: rev e6e1860c8e83f9db6c4c094fe703b21d45d86529) tajo-core/src/test/java/org/apache/tajo/cli/tsql/TestDefaultCliOutputFormatter.java CHANGES tajo-cli/src/main/java/org/apache/tajo/cli/tsql/DefaultTajoCliOutputFormatter.java
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Tajo-master-CODEGEN-build #337 (See https://builds.apache.org/job/Tajo-master-CODEGEN-build/337/)
          TAJO-1576: Sometimes DefaultTajoCliOutputFormatter.parseErrorMessage() eliminates an important kind of information. (jihoonson: rev e6e1860c8e83f9db6c4c094fe703b21d45d86529)

          • tajo-cli/src/main/java/org/apache/tajo/cli/tsql/DefaultTajoCliOutputFormatter.java
          • CHANGES
          • tajo-core/src/test/java/org/apache/tajo/cli/tsql/TestDefaultCliOutputFormatter.java
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Tajo-master-CODEGEN-build #337 (See https://builds.apache.org/job/Tajo-master-CODEGEN-build/337/ ) TAJO-1576 : Sometimes DefaultTajoCliOutputFormatter.parseErrorMessage() eliminates an important kind of information. (jihoonson: rev e6e1860c8e83f9db6c4c094fe703b21d45d86529) tajo-cli/src/main/java/org/apache/tajo/cli/tsql/DefaultTajoCliOutputFormatter.java CHANGES tajo-core/src/test/java/org/apache/tajo/cli/tsql/TestDefaultCliOutputFormatter.java
          Hide
          jihoonson Jihoon Son added a comment -

          Committed to master and 0.10.1 branches.
          Thanks Jongyoung Park!

          Show
          jihoonson Jihoon Son added a comment - Committed to master and 0.10.1 branches. Thanks Jongyoung Park !
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user asfgit closed the pull request at:

          https://github.com/apache/tajo/pull/561

          Show
          githubbot ASF GitHub Bot added a comment - Github user asfgit closed the pull request at: https://github.com/apache/tajo/pull/561
          Hide
          jhkim Jinho Kim added a comment -

          +1 ship it

          Show
          jhkim Jinho Kim added a comment - +1 ship it
          Hide
          tajoqa Tajo QA added a comment -

          +1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12730776/TAJO-1576_add_test.patch
          against master revision release-0.9.0-rc0-281-gb6b9d46.

          +1 @author. The patch does not contain any @author tags.

          +1 tests included. The patch appears to include 1 new or modified test files.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 javadoc. The applied patch does not increase the total number of javadoc warnings.

          +1 checkstyle. The patch generated 0 code style errors.

          +1 findbugs. The patch does not introduce any new Findbugs (version 2.0.3) warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          +1 core tests. The patch passed unit tests in tajo-cli tajo-core.

          Test results: https://builds.apache.org/job/PreCommit-TAJO-Build/771//testReport/
          Console output: https://builds.apache.org/job/PreCommit-TAJO-Build/771//console

          This message is automatically generated.

          Show
          tajoqa Tajo QA added a comment - +1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12730776/TAJO-1576_add_test.patch against master revision release-0.9.0-rc0-281-gb6b9d46. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 1 new or modified test files. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 javadoc. The applied patch does not increase the total number of javadoc warnings. +1 checkstyle. The patch generated 0 code style errors. +1 findbugs. The patch does not introduce any new Findbugs (version 2.0.3) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed unit tests in tajo-cli tajo-core. Test results: https://builds.apache.org/job/PreCommit-TAJO-Build/771//testReport/ Console output: https://builds.apache.org/job/PreCommit-TAJO-Build/771//console This message is automatically generated.
          Hide
          jihoonson Jihoon Son added a comment -

          Hi Jongyoung Park, your patch looks good, but would be nice if you add a test to verify whether the error message contains the line number.
          Since you look quite busy, I've added a simple test.
          Please check it.

          Show
          jihoonson Jihoon Son added a comment - Hi Jongyoung Park , your patch looks good, but would be nice if you add a test to verify whether the error message contains the line number. Since you look quite busy, I've added a simple test. Please check it.
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user eminency commented on the pull request:

          https://github.com/apache/tajo/pull/561#issuecomment-97686772

          I closed previous PR by my mistake.
          It couldn't be re-opened, thus re-created again.

          Show
          githubbot ASF GitHub Bot added a comment - Github user eminency commented on the pull request: https://github.com/apache/tajo/pull/561#issuecomment-97686772 I closed previous PR by my mistake. It couldn't be re-opened, thus re-created again.
          Hide
          githubbot ASF GitHub Bot added a comment -

          GitHub user eminency opened a pull request:

          https://github.com/apache/tajo/pull/561

          TAJO-1576: Sometimes DefaultTajoCliOutputFormatter.parseErrorMessage() eliminates an important kind of information

          After the patch is merged, some syntax error message is displayed like the following.

          Before the patch :
          ```
          ERROR: syntax error at or near '('
          ```
          After the patch:
          ```
          ERROR: syntax error at or near '('
          LINE 31:4 (select *
          ^
          ```

          You can merge this pull request into a Git repository by running:

          $ git pull https://github.com/eminency/tajo TAJO-1576

          Alternatively you can review and apply these changes as the patch at:

          https://github.com/apache/tajo/pull/561.patch

          To close this pull request, make a commit to your master/trunk branch
          with (at least) the following in the commit message:

          This closes #561


          commit 66888f24c82730c84a322fe8ff0c757b8f4eb798
          Author: Jongyoung Park <eminency@gmail.com>
          Date: 2015-04-21T17:22:58Z

          parseErrorMesssage() should not remove extra lines


          Show
          githubbot ASF GitHub Bot added a comment - GitHub user eminency opened a pull request: https://github.com/apache/tajo/pull/561 TAJO-1576 : Sometimes DefaultTajoCliOutputFormatter.parseErrorMessage() eliminates an important kind of information After the patch is merged, some syntax error message is displayed like the following. Before the patch : ``` ERROR: syntax error at or near '(' ``` After the patch: ``` ERROR: syntax error at or near '(' LINE 31:4 (select * ^ ``` You can merge this pull request into a Git repository by running: $ git pull https://github.com/eminency/tajo TAJO-1576 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/tajo/pull/561.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #561 commit 66888f24c82730c84a322fe8ff0c757b8f4eb798 Author: Jongyoung Park <eminency@gmail.com> Date: 2015-04-21T17:22:58Z parseErrorMesssage() should not remove extra lines
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user eminency closed the pull request at:

          https://github.com/apache/tajo/pull/550

          Show
          githubbot ASF GitHub Bot added a comment - Github user eminency closed the pull request at: https://github.com/apache/tajo/pull/550
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user eminency commented on the pull request:

          https://github.com/apache/tajo/pull/550#issuecomment-95386222

          Now there is no test for error line number.
          It will be added while I work on TAJO-1580.

          Please consider it.

          Show
          githubbot ASF GitHub Bot added a comment - Github user eminency commented on the pull request: https://github.com/apache/tajo/pull/550#issuecomment-95386222 Now there is no test for error line number. It will be added while I work on TAJO-1580 . Please consider it.
          Hide
          jihoonson Jihoon Son added a comment -

          It will be nice if this patch is also applied on 0.10.1.
          I'll change the fix version.

          Show
          jihoonson Jihoon Son added a comment - It will be nice if this patch is also applied on 0.10.1. I'll change the fix version.
          Hide
          tajoqa Tajo QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12726923/TAJO-1576.patch
          against master revision release-0.9.0-rc0-270-g2a5d912.

          +1 @author. The patch does not contain any @author tags.

          +1 tests included. The patch appears to include 1 new or modified test files.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 javadoc. The applied patch does not increase the total number of javadoc warnings.

          +1 checkstyle. The patch generated 0 code style errors.

          -1 findbugs. The patch appears to introduce 18 new Findbugs (version 2.0.3) warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          +1 core tests. The patch passed unit tests in tajo-cli tajo-core.

          Test results: https://builds.apache.org/job/PreCommit-TAJO-Build/755//testReport/
          Findbugs warnings: https://builds.apache.org/job/PreCommit-TAJO-Build/755//artifact/incubator-tajo/patchprocess/newPatchFindbugsWarningstajo-core.html
          Console output: https://builds.apache.org/job/PreCommit-TAJO-Build/755//console

          This message is automatically generated.

          Show
          tajoqa Tajo QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12726923/TAJO-1576.patch against master revision release-0.9.0-rc0-270-g2a5d912. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 1 new or modified test files. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 javadoc. The applied patch does not increase the total number of javadoc warnings. +1 checkstyle. The patch generated 0 code style errors. -1 findbugs. The patch appears to introduce 18 new Findbugs (version 2.0.3) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed unit tests in tajo-cli tajo-core. Test results: https://builds.apache.org/job/PreCommit-TAJO-Build/755//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-TAJO-Build/755//artifact/incubator-tajo/patchprocess/newPatchFindbugsWarningstajo-core.html Console output: https://builds.apache.org/job/PreCommit-TAJO-Build/755//console This message is automatically generated.
          Hide
          githubbot ASF GitHub Bot added a comment -

          GitHub user eminency opened a pull request:

          https://github.com/apache/tajo/pull/550

          TAJO-1576: Sometimes DefaultTajoCliOutputFormatter.parseErrorMessage() eliminates a important kind of information

          parseErrorMesssage() should not remove extra lines

          You can merge this pull request into a Git repository by running:

          $ git pull https://github.com/eminency/tajo TAJO-1576

          Alternatively you can review and apply these changes as the patch at:

          https://github.com/apache/tajo/pull/550.patch

          To close this pull request, make a commit to your master/trunk branch
          with (at least) the following in the commit message:

          This closes #550


          commit 95740979439eee5c6104ca6c189e2982a4c861fe
          Author: Jongyoung Park <eminency@gmail.com>
          Date: 2015-04-21T17:22:58Z

          parseErrorMesssage() should not remove extra lines


          Show
          githubbot ASF GitHub Bot added a comment - GitHub user eminency opened a pull request: https://github.com/apache/tajo/pull/550 TAJO-1576 : Sometimes DefaultTajoCliOutputFormatter.parseErrorMessage() eliminates a important kind of information parseErrorMesssage() should not remove extra lines You can merge this pull request into a Git repository by running: $ git pull https://github.com/eminency/tajo TAJO-1576 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/tajo/pull/550.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #550 commit 95740979439eee5c6104ca6c189e2982a4c861fe Author: Jongyoung Park <eminency@gmail.com> Date: 2015-04-21T17:22:58Z parseErrorMesssage() should not remove extra lines

            People

            • Assignee:
              eminency Jongyoung Park
              Reporter:
              eminency Jongyoung Park
            • Votes:
              0 Vote for this issue
              Watchers:
              5 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development