Details

    • Type: Bug
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 0.10.0
    • Fix Version/s: 0.11.0, 0.10.1
    • Component/s: SQL Parser
    • Labels:
      None

      Description

      For next sql as an example,

      SELECT d_date_sk ss_sold_date_sk,
        t_time_sk ss_sold_time_sk,
        i_item_sk ss_item_sk,
        c_customer_sk ss_customer_sk,
        c_current_cdemo_sk ss_cdemo_sk,
        c_current_hdemo_sk ss_hdemo_sk,
        c_current_addr_sk ss_addr_sk,
        s_store_sk ss_store_sk,
        p_promo_sk ss_promo_sk,
        purc_purchase_id ss_ticket_number,
        plin_quantity ss_quantity,
        i_wholesale_cost ss_wholesale_cost,
        i_current_price ss_list_price,
        plin_sale_price ss_sales_price, (i_current_price-plin_sale_price)*plin_quantity ss_ext_discount_amt, plin_sale_price * plin_quantity ss_ext_sales_price,
        i_wholesale_cost * plin_quantity ss_ext_wholesale_cost, i_current_price * plin_quantity ss_ext_list_price, i_current_price * s_tax_precentage ss_ext_tax, plin_coupon_amt ss_coupon_amt,
        (plin_sale_price * plin_quantity)-plin_coupon_amt ss_net_paid,
        ((plin_sale_price * plin_quantity)-plin_coupon_amt)*(1+s_tax_precentage) ss_net_paid_inc_tax, ((plin_sale_price * plin_quantity)-plin_coupon_amt)-(plin_quantity*i_wholesale_cost)
        ss_net_profit
      FROM s_purchase
        LEFTT OUTER JOIN customer ON (purc_customer_id = c_customer_id)
        LEFT OUTER JOIN store ON (purc_store_id = s_store_id)
        LEFT OUTER JOIN date_dim ON (cast(purc_purchase_date as date) = d_date) 
        LEFT OUTER JOIN time_dim ON (PURC_PURCHASE_TIME = t_time)
        JOIN s_purchase_lineitem ON (purc_purchase_id = plin_purchase_id)
        LEFT OUTER JOIN promotion ON plin_promotion_id = p_promo_id
        LEFT OUTER JOIN item ON plin_item_id = i_item_id
      WHERE purc_purchase_id = plin_purchase_id
        AND i_rec_end_date is NULL 
        AND s_rec_end_date is NULL;
      

      error message is like this :

      ERROR: mismatched input 'OUTER' expecting

      Unknown macro: {<EOF>, EXCEPT, GROUP, HAVING, INTERSECT, LIMIT, ORDER, UNION, WHERE, WINDOW, ';', ','}

      LINE 39:8 LEFTT OUTER JOIN customer ON (purc_customer_id = c_customer_id)

      But the error line is 20, not 39.

      1. TAJO-1580.patch
        5 kB
        Jongyoung Park

        Issue Links

          Activity

          Hide
          eminency Jongyoung Park added a comment -

          The error line number will be displayed after applying TAJO-1576.

          Show
          eminency Jongyoung Park added a comment - The error line number will be displayed after applying TAJO-1576 .
          Hide
          githubbot ASF GitHub Bot added a comment -

          GitHub user eminency opened a pull request:

          https://github.com/apache/tajo/pull/552

          TAJO-1580: Error line number is incorrect

          Modified to avoid adding useless new line characters

          You can merge this pull request into a Git repository by running:

          $ git pull https://github.com/eminency/tajo TAJO-1580

          Alternatively you can review and apply these changes as the patch at:

          https://github.com/apache/tajo/pull/552.patch

          To close this pull request, make a commit to your master/trunk branch
          with (at least) the following in the commit message:

          This closes #552


          commit ddac430e49b6546586613f3e5ae259d299e2e8a3
          Author: Jongyoung Park <eminency@gmail.com>
          Date: 2015-04-24T08:37:36Z

          Modified to avoid adding useless new line characters


          Show
          githubbot ASF GitHub Bot added a comment - GitHub user eminency opened a pull request: https://github.com/apache/tajo/pull/552 TAJO-1580 : Error line number is incorrect Modified to avoid adding useless new line characters You can merge this pull request into a Git repository by running: $ git pull https://github.com/eminency/tajo TAJO-1580 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/tajo/pull/552.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #552 commit ddac430e49b6546586613f3e5ae259d299e2e8a3 Author: Jongyoung Park <eminency@gmail.com> Date: 2015-04-24T08:37:36Z Modified to avoid adding useless new line characters
          Hide
          tajoqa Tajo QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12727850/TAJO-1580.patch
          against master revision release-0.9.0-rc0-272-g1434072.

          +1 @author. The patch does not contain any @author tags.

          +1 tests included. The patch appears to include 2 new or modified test files.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 javadoc. The applied patch does not increase the total number of javadoc warnings.

          +1 checkstyle. The patch generated 0 code style errors.

          -1 findbugs. The patch appears to introduce 18 new Findbugs (version 2.0.3) warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          +1 core tests. The patch passed unit tests in tajo-cli tajo-core.

          Test results: https://builds.apache.org/job/PreCommit-TAJO-Build/756//testReport/
          Findbugs warnings: https://builds.apache.org/job/PreCommit-TAJO-Build/756//artifact/incubator-tajo/patchprocess/newPatchFindbugsWarningstajo-core.html
          Console output: https://builds.apache.org/job/PreCommit-TAJO-Build/756//console

          This message is automatically generated.

          Show
          tajoqa Tajo QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12727850/TAJO-1580.patch against master revision release-0.9.0-rc0-272-g1434072. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 2 new or modified test files. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 javadoc. The applied patch does not increase the total number of javadoc warnings. +1 checkstyle. The patch generated 0 code style errors. -1 findbugs. The patch appears to introduce 18 new Findbugs (version 2.0.3) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed unit tests in tajo-cli tajo-core. Test results: https://builds.apache.org/job/PreCommit-TAJO-Build/756//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-TAJO-Build/756//artifact/incubator-tajo/patchprocess/newPatchFindbugsWarningstajo-core.html Console output: https://builds.apache.org/job/PreCommit-TAJO-Build/756//console This message is automatically generated.
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user blrunner commented on the pull request:

          https://github.com/apache/tajo/pull/552#issuecomment-96484224

          +1

          Thanks for your contribution.
          I found that this had printed right line at TajoMaster log file.

          Show
          githubbot ASF GitHub Bot added a comment - Github user blrunner commented on the pull request: https://github.com/apache/tajo/pull/552#issuecomment-96484224 +1 Thanks for your contribution. I found that this had printed right line at TajoMaster log file.
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user asfgit closed the pull request at:

          https://github.com/apache/tajo/pull/552

          Show
          githubbot ASF GitHub Bot added a comment - Github user asfgit closed the pull request at: https://github.com/apache/tajo/pull/552
          Hide
          hudson Hudson added a comment -

          ABORTED: Integrated in Tajo-master-CODEGEN-build #324 (See https://builds.apache.org/job/Tajo-master-CODEGEN-build/324/)
          TAJO-1580: Error line number is incorrect. (blrunner: rev 50ac828a95beb7d09a4a0f9ae46ad182b2c269ff)

          • CHANGES
          • tajo-cli/src/main/java/org/apache/tajo/cli/tsql/SimpleParser.java
          • tajo-core/src/test/java/org/apache/tajo/cli/tsql/TestSimpleParser.java
          Show
          hudson Hudson added a comment - ABORTED: Integrated in Tajo-master-CODEGEN-build #324 (See https://builds.apache.org/job/Tajo-master-CODEGEN-build/324/ ) TAJO-1580 : Error line number is incorrect. (blrunner: rev 50ac828a95beb7d09a4a0f9ae46ad182b2c269ff) CHANGES tajo-cli/src/main/java/org/apache/tajo/cli/tsql/SimpleParser.java tajo-core/src/test/java/org/apache/tajo/cli/tsql/TestSimpleParser.java
          Hide
          hudson Hudson added a comment -

          SUCCESS: Integrated in Tajo-master-build #686 (See https://builds.apache.org/job/Tajo-master-build/686/)
          TAJO-1580: Error line number is incorrect. (blrunner: rev 50ac828a95beb7d09a4a0f9ae46ad182b2c269ff)

          • tajo-core/src/test/java/org/apache/tajo/cli/tsql/TestSimpleParser.java
          • CHANGES
          • tajo-cli/src/main/java/org/apache/tajo/cli/tsql/SimpleParser.java
          Show
          hudson Hudson added a comment - SUCCESS: Integrated in Tajo-master-build #686 (See https://builds.apache.org/job/Tajo-master-build/686/ ) TAJO-1580 : Error line number is incorrect. (blrunner: rev 50ac828a95beb7d09a4a0f9ae46ad182b2c269ff) tajo-core/src/test/java/org/apache/tajo/cli/tsql/TestSimpleParser.java CHANGES tajo-cli/src/main/java/org/apache/tajo/cli/tsql/SimpleParser.java
          Hide
          blrunner Jaehwa Jung added a comment -

          I've just committed this to the master branch and the 0.10.1 branch.

          Show
          blrunner Jaehwa Jung added a comment - I've just committed this to the master branch and the 0.10.1 branch.

            People

            • Assignee:
              eminency Jongyoung Park
              Reporter:
              eminency Jongyoung Park
            • Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development