Details

    • Type: Improvement
    • Status: Resolved
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.9.0
    • Component/s: None
    • Labels:
      None

      Description

      See title. TajoCli prints information and error message with various format. These message must be arranged because ETL program uses TajoCli's information or error message.

      1. TAJO-734.patch
        65 kB
        Hyoungjun Kim
      2. TAJO-734_2.patch
        61 kB
        Jinho Kim
      3. TAJO_734_3.patch
        61 kB
        Jihoon Son
      4. TAJO_734_findbugs.patch
        1 kB
        Jinho Kim
      5. TAJO-734-4.patch
        62 kB
        Jihoon Son
      6. TAJO-734-5.patch
        60 kB
        Hyoungjun Kim

        Issue Links

          Activity

          Hide
          hudson Hudson added a comment -

          SUCCESS: Integrated in Tajo-master-build #198 (See https://builds.apache.org/job/Tajo-master-build/198/)
          TAJO-734: Arrange TajoCli output message. (hyoungjunkim via jihoon) (jihoonson: rev bc1a3235176fd5d09b0093bc5b1ff03cdca63dab)

          • tajo-rpc/src/main/java/org/apache/tajo/rpc/TajoServiceException.java
          • tajo-core/src/main/java/org/apache/tajo/master/querymaster/SubQuery.java
          • tajo-rpc/src/main/java/org/apache/tajo/rpc/NettyClientBase.java
          • tajo-client/src/main/java/org/apache/tajo/client/QueryStatus.java
          • tajo-core/src/main/java/org/apache/tajo/master/querymaster/Query.java
          • tajo-rpc/src/main/proto/RpcProtos.proto
          • tajo-client/src/main/java/org/apache/tajo/client/TajoClient.java
          • tajo-core/src/main/java/org/apache/tajo/master/querymaster/QueryMasterTask.java
          • tajo-rpc/src/main/java/org/apache/tajo/rpc/BlockingRpcClient.java
          • tajo-core/src/main/java/org/apache/tajo/master/TajoMasterClientService.java
          • tajo-core/src/main/java/org/apache/tajo/worker/TajoWorkerClientService.java
          • tajo-common/src/main/java/org/apache/tajo/conf/TajoConf.java
          • tajo-core/src/main/java/org/apache/tajo/master/querymaster/QueryUnit.java
          • tajo-client/src/main/java/org/apache/tajo/cli/DefaultTajoCliOutputFormatter.java
          • tajo-client/src/main/java/org/apache/tajo/cli/TajoCli.java
          • tajo-rpc/src/test/java/org/apache/tajo/rpc/TestBlockingRpc.java
          • CHANGES
          • tajo-core/src/main/java/org/apache/tajo/master/GlobalEngine.java
          • tajo-core/src/main/java/org/apache/tajo/worker/Task.java
          • tajo-client/src/main/proto/ClientProtos.proto
          • tajo-core/src/main/proto/TajoWorkerProtocol.proto
          • tajo-rpc/src/main/java/org/apache/tajo/rpc/RemoteCallException.java
          • tajo-core/src/main/java/org/apache/tajo/master/querymaster/QueryMasterManagerService.java
          • tajo-core/src/main/java/org/apache/tajo/master/querymaster/QueryUnitAttempt.java
          • tajo-rpc/src/main/java/org/apache/tajo/rpc/BlockingRpcServer.java
          • tajo-client/src/main/java/org/apache/tajo/cli/TajoCliOutputFormatter.java
          • tajo-core/src/main/java/org/apache/tajo/master/querymaster/QueryInfo.java
          • tajo-rpc/src/main/java/org/apache/tajo/rpc/RpcChannelFactory.java
          • tajo-core/src/test/java/org/apache/tajo/cli/TestDefaultCliOutputFormatter.java
          Show
          hudson Hudson added a comment - SUCCESS: Integrated in Tajo-master-build #198 (See https://builds.apache.org/job/Tajo-master-build/198/ ) TAJO-734 : Arrange TajoCli output message. (hyoungjunkim via jihoon) (jihoonson: rev bc1a3235176fd5d09b0093bc5b1ff03cdca63dab) tajo-rpc/src/main/java/org/apache/tajo/rpc/TajoServiceException.java tajo-core/src/main/java/org/apache/tajo/master/querymaster/SubQuery.java tajo-rpc/src/main/java/org/apache/tajo/rpc/NettyClientBase.java tajo-client/src/main/java/org/apache/tajo/client/QueryStatus.java tajo-core/src/main/java/org/apache/tajo/master/querymaster/Query.java tajo-rpc/src/main/proto/RpcProtos.proto tajo-client/src/main/java/org/apache/tajo/client/TajoClient.java tajo-core/src/main/java/org/apache/tajo/master/querymaster/QueryMasterTask.java tajo-rpc/src/main/java/org/apache/tajo/rpc/BlockingRpcClient.java tajo-core/src/main/java/org/apache/tajo/master/TajoMasterClientService.java tajo-core/src/main/java/org/apache/tajo/worker/TajoWorkerClientService.java tajo-common/src/main/java/org/apache/tajo/conf/TajoConf.java tajo-core/src/main/java/org/apache/tajo/master/querymaster/QueryUnit.java tajo-client/src/main/java/org/apache/tajo/cli/DefaultTajoCliOutputFormatter.java tajo-client/src/main/java/org/apache/tajo/cli/TajoCli.java tajo-rpc/src/test/java/org/apache/tajo/rpc/TestBlockingRpc.java CHANGES tajo-core/src/main/java/org/apache/tajo/master/GlobalEngine.java tajo-core/src/main/java/org/apache/tajo/worker/Task.java tajo-client/src/main/proto/ClientProtos.proto tajo-core/src/main/proto/TajoWorkerProtocol.proto tajo-rpc/src/main/java/org/apache/tajo/rpc/RemoteCallException.java tajo-core/src/main/java/org/apache/tajo/master/querymaster/QueryMasterManagerService.java tajo-core/src/main/java/org/apache/tajo/master/querymaster/QueryUnitAttempt.java tajo-rpc/src/main/java/org/apache/tajo/rpc/BlockingRpcServer.java tajo-client/src/main/java/org/apache/tajo/cli/TajoCliOutputFormatter.java tajo-core/src/main/java/org/apache/tajo/master/querymaster/QueryInfo.java tajo-rpc/src/main/java/org/apache/tajo/rpc/RpcChannelFactory.java tajo-core/src/test/java/org/apache/tajo/cli/TestDefaultCliOutputFormatter.java
          Hide
          jihoonson Jihoon Son added a comment -

          I committed the patch.
          Thanks Hyoungjun!

          Show
          jihoonson Jihoon Son added a comment - I committed the patch. Thanks Hyoungjun!
          Hide
          jihoonson Jihoon Son added a comment -

          Since the latest patch got +1 from RB, I'll commit it.

          Show
          jihoonson Jihoon Son added a comment - Since the latest patch got +1 from RB, I'll commit it.
          Hide
          tajoqa Tajo QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12641402/TAJO-734-5.patch
          against master revision 89e8fa3.

          +1 @author. The patch does not contain any @author tags.

          +1 tests included. The patch appears to include 2 new or modified test files.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 javadoc. The applied patch does not increase the total number of javadoc warnings.

          +1 checkstyle. The patch generated 0 code style errors.

          -1 findbugs. The patch appears to introduce 191 new Findbugs (version 1.3.9) warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          +1 core tests. The patch passed unit tests in tajo-client tajo-common tajo-core tajo-rpc.

          Test results: https://builds.apache.org/job/PreCommit-TAJO-Build/377//testReport/
          Findbugs warnings: https://builds.apache.org/job/PreCommit-TAJO-Build/377//artifact/incubator-tajo/patchprocess/newPatchFindbugsWarningstajo-core.html
          Console output: https://builds.apache.org/job/PreCommit-TAJO-Build/377//console

          This message is automatically generated.

          Show
          tajoqa Tajo QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12641402/TAJO-734-5.patch against master revision 89e8fa3. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 2 new or modified test files. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 javadoc. The applied patch does not increase the total number of javadoc warnings. +1 checkstyle. The patch generated 0 code style errors. -1 findbugs. The patch appears to introduce 191 new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed unit tests in tajo-client tajo-common tajo-core tajo-rpc. Test results: https://builds.apache.org/job/PreCommit-TAJO-Build/377//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-TAJO-Build/377//artifact/incubator-tajo/patchprocess/newPatchFindbugsWarningstajo-core.html Console output: https://builds.apache.org/job/PreCommit-TAJO-Build/377//console This message is automatically generated.
          Hide
          hjkim Hyoungjun Kim added a comment -

          Jihoon Son I rebased last patch and update RB. Please reivew last patch. Thanks

          Show
          hjkim Hyoungjun Kim added a comment - Jihoon Son I rebased last patch and update RB. Please reivew last patch. Thanks
          Hide
          hjkim Hyoungjun Kim added a comment -

          Rebased

          Show
          hjkim Hyoungjun Kim added a comment - Rebased
          Hide
          tajoqa Tajo QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12640780/TAJO-734-4.patch
          against master revision 508ebed.

          +1 @author. The patch does not contain any @author tags.

          +1 tests included. The patch appears to include 2 new or modified test files.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 javadoc. The applied patch does not increase the total number of javadoc warnings.

          +1 checkstyle. The patch generated 0 code style errors.

          -1 findbugs. The patch appears to introduce 196 new Findbugs (version 1.3.9) warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          +1 core tests. The patch passed unit tests in tajo-client tajo-common tajo-core/tajo-core-backend tajo-rpc.

          Test results: https://builds.apache.org/job/PreCommit-TAJO-Build/354//testReport/
          Findbugs warnings: https://builds.apache.org/job/PreCommit-TAJO-Build/354//artifact/incubator-tajo/patchprocess/newPatchFindbugsWarningstajo-core-backend.html
          Console output: https://builds.apache.org/job/PreCommit-TAJO-Build/354//console

          This message is automatically generated.

          Show
          tajoqa Tajo QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12640780/TAJO-734-4.patch against master revision 508ebed. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 2 new or modified test files. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 javadoc. The applied patch does not increase the total number of javadoc warnings. +1 checkstyle. The patch generated 0 code style errors. -1 findbugs. The patch appears to introduce 196 new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed unit tests in tajo-client tajo-common tajo-core/tajo-core-backend tajo-rpc. Test results: https://builds.apache.org/job/PreCommit-TAJO-Build/354//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-TAJO-Build/354//artifact/incubator-tajo/patchprocess/newPatchFindbugsWarningstajo-core-backend.html Console output: https://builds.apache.org/job/PreCommit-TAJO-Build/354//console This message is automatically generated.
          Hide
          jihoonson Jihoon Son added a comment -

          This is a merged patch which reflects the Jinho's comment.

          Hyoungjun Kim, I cannot update the diff on the RB that you opened.
          Would you mind updating it?
          Thanks,
          Jihoon

          Show
          jihoonson Jihoon Son added a comment - This is a merged patch which reflects the Jinho's comment. Hyoungjun Kim , I cannot update the diff on the RB that you opened. Would you mind updating it? Thanks, Jihoon
          Hide
          tajoqa Tajo QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12640779/TAJO_734_findbugs.patch
          against master revision 508ebed.

          -1 patch. The patch command could not apply the patch.

          +1 @author. The patch does not contain any @author tags.

          -1 tests included. The patch doesn't appear to include any new or modified tests.
          Please justify why no new tests are needed for this patch.
          Also please list what manual steps were performed to verify this patch.

          -1 patch. The patch command could not apply the patch.

          Console output: https://builds.apache.org/job/PreCommit-TAJO-Build/353//console

          This message is automatically generated.

          Show
          tajoqa Tajo QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12640779/TAJO_734_findbugs.patch against master revision 508ebed. -1 patch. The patch command could not apply the patch. +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. -1 patch. The patch command could not apply the patch. Console output: https://builds.apache.org/job/PreCommit-TAJO-Build/353//console This message is automatically generated.
          Hide
          jihoonson Jihoon Son added a comment -

          Jinho Kim, thanks!
          I'll merge and put it on RB.

          Show
          jihoonson Jihoon Son added a comment - Jinho Kim , thanks! I'll merge and put it on RB.
          Hide
          jhkim Jinho Kim added a comment -

          Jihoon Son
          I uploaded the patch for fix the findbugs warning. Could you move the merged patch to the reviewboard?

          Show
          jhkim Jinho Kim added a comment - Jihoon Son I uploaded the patch for fix the findbugs warning. Could you move the merged patch to the reviewboard?
          Hide
          tajoqa Tajo QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12640771/TAJO_734_3.patch
          against master revision 508ebed.

          +1 @author. The patch does not contain any @author tags.

          +1 tests included. The patch appears to include 2 new or modified test files.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 javadoc. The applied patch does not increase the total number of javadoc warnings.

          +1 checkstyle. The patch generated 0 code style errors.

          -1 findbugs. The patch appears to introduce 197 new Findbugs (version 1.3.9) warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          +1 core tests. The patch passed unit tests in tajo-client tajo-common tajo-core/tajo-core-backend tajo-rpc.

          Test results: https://builds.apache.org/job/PreCommit-TAJO-Build/352//testReport/
          Findbugs warnings: https://builds.apache.org/job/PreCommit-TAJO-Build/352//artifact/incubator-tajo/patchprocess/newPatchFindbugsWarningstajo-rpc.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-TAJO-Build/352//artifact/incubator-tajo/patchprocess/newPatchFindbugsWarningstajo-core-backend.html
          Console output: https://builds.apache.org/job/PreCommit-TAJO-Build/352//console

          This message is automatically generated.

          Show
          tajoqa Tajo QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12640771/TAJO_734_3.patch against master revision 508ebed. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 2 new or modified test files. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 javadoc. The applied patch does not increase the total number of javadoc warnings. +1 checkstyle. The patch generated 0 code style errors. -1 findbugs. The patch appears to introduce 197 new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed unit tests in tajo-client tajo-common tajo-core/tajo-core-backend tajo-rpc. Test results: https://builds.apache.org/job/PreCommit-TAJO-Build/352//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-TAJO-Build/352//artifact/incubator-tajo/patchprocess/newPatchFindbugsWarningstajo-rpc.html Findbugs warnings: https://builds.apache.org/job/PreCommit-TAJO-Build/352//artifact/incubator-tajo/patchprocess/newPatchFindbugsWarningstajo-core-backend.html Console output: https://builds.apache.org/job/PreCommit-TAJO-Build/352//console This message is automatically generated.
          Hide
          jihoonson Jihoon Son added a comment -

          Thanks Jinho Kim.
          I attached a new patch.
          Please review this patch.
          Thanks!

          Show
          jihoonson Jihoon Son added a comment - Thanks Jinho Kim . I attached a new patch. Please review this patch. Thanks!
          Hide
          jhkim Jinho Kim added a comment -

          Jihoon Son
          Please fix findbug warning in RPC before you commit.

          Show
          jhkim Jinho Kim added a comment - Jihoon Son Please fix findbug warning in RPC before you commit.
          Hide
          jihoonson Jihoon Son added a comment -

          Sorry hyoungjun.
          I'll commit the latest patch.
          Thanks!

          Show
          jihoonson Jihoon Son added a comment - Sorry hyoungjun. I'll commit the latest patch. Thanks!
          Hide
          jihoonson Jihoon Son added a comment -

          +1. Thanks for your contribution!
          This patch looks good to me.
          I have just one comment. Please remove commented out codes in Query.java before you commit.

          Show
          jihoonson Jihoon Son added a comment - +1. Thanks for your contribution! This patch looks good to me. I have just one comment. Please remove commented out codes in Query.java before you commit.
          Hide
          tajoqa Tajo QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12640585/TAJO-734_2.patch
          against master revision 68f9dee.

          +1 @author. The patch does not contain any @author tags.

          +1 tests included. The patch appears to include 2 new or modified test files.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 javadoc. The applied patch does not increase the total number of javadoc warnings.

          +1 checkstyle. The patch generated 0 code style errors.

          -1 findbugs. The patch appears to introduce 197 new Findbugs (version 1.3.9) warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          +1 core tests. The patch passed unit tests in tajo-client tajo-common tajo-core/tajo-core-backend tajo-rpc.

          Test results: https://builds.apache.org/job/PreCommit-TAJO-Build/347//testReport/
          Findbugs warnings: https://builds.apache.org/job/PreCommit-TAJO-Build/347//artifact/incubator-tajo/patchprocess/newPatchFindbugsWarningstajo-rpc.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-TAJO-Build/347//artifact/incubator-tajo/patchprocess/newPatchFindbugsWarningstajo-core-backend.html
          Console output: https://builds.apache.org/job/PreCommit-TAJO-Build/347//console

          This message is automatically generated.

          Show
          tajoqa Tajo QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12640585/TAJO-734_2.patch against master revision 68f9dee. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 2 new or modified test files. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 javadoc. The applied patch does not increase the total number of javadoc warnings. +1 checkstyle. The patch generated 0 code style errors. -1 findbugs. The patch appears to introduce 197 new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed unit tests in tajo-client tajo-common tajo-core/tajo-core-backend tajo-rpc. Test results: https://builds.apache.org/job/PreCommit-TAJO-Build/347//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-TAJO-Build/347//artifact/incubator-tajo/patchprocess/newPatchFindbugsWarningstajo-rpc.html Findbugs warnings: https://builds.apache.org/job/PreCommit-TAJO-Build/347//artifact/incubator-tajo/patchprocess/newPatchFindbugsWarningstajo-core-backend.html Console output: https://builds.apache.org/job/PreCommit-TAJO-Build/347//console This message is automatically generated.
          Hide
          jhkim Jinho Kim added a comment -

          I've just rebase the patch without log4j.

          Show
          jhkim Jinho Kim added a comment - I've just rebase the patch without log4j.
          Hide
          jhkim Jinho Kim added a comment -

          Thank you!

          Show
          jhkim Jinho Kim added a comment - Thank you!
          Hide
          hjkim Hyoungjun Kim added a comment -

          Sure.

          Show
          hjkim Hyoungjun Kim added a comment - Sure.
          Hide
          jhkim Jinho Kim added a comment -

          Hyoungjun Kim
          Thank you for your contribution
          Would you mind if I seperate the log4j issue ?

          Show
          jhkim Jinho Kim added a comment - Hyoungjun Kim Thank you for your contribution Would you mind if I seperate the log4j issue ?
          Hide
          tajoqa Tajo QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12639590/TAJO-734.patch
          against master revision 838b522.

          +1 @author. The patch does not contain any @author tags.

          +1 tests included. The patch appears to include 2 new or modified test files.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 javadoc. The applied patch does not increase the total number of javadoc warnings.

          +1 checkstyle. The patch generated 0 code style errors.

          -1 findbugs. The patch appears to introduce 206 new Findbugs (version 1.3.9) warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          +1 core tests. The patch passed unit tests in tajo-client tajo-common tajo-core/tajo-core-backend tajo-dist tajo-rpc.

          Test results: https://builds.apache.org/job/PreCommit-TAJO-Build/324//testReport/
          Findbugs warnings: https://builds.apache.org/job/PreCommit-TAJO-Build/324//artifact/incubator-tajo/patchprocess/newPatchFindbugsWarningstajo-common.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-TAJO-Build/324//artifact/incubator-tajo/patchprocess/newPatchFindbugsWarningstajo-rpc.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-TAJO-Build/324//artifact/incubator-tajo/patchprocess/newPatchFindbugsWarningstajo-core-backend.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-TAJO-Build/324//artifact/incubator-tajo/patchprocess/newPatchFindbugsWarningstajo-client.html
          Console output: https://builds.apache.org/job/PreCommit-TAJO-Build/324//console

          This message is automatically generated.

          Show
          tajoqa Tajo QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12639590/TAJO-734.patch against master revision 838b522. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 2 new or modified test files. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 javadoc. The applied patch does not increase the total number of javadoc warnings. +1 checkstyle. The patch generated 0 code style errors. -1 findbugs. The patch appears to introduce 206 new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed unit tests in tajo-client tajo-common tajo-core/tajo-core-backend tajo-dist tajo-rpc. Test results: https://builds.apache.org/job/PreCommit-TAJO-Build/324//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-TAJO-Build/324//artifact/incubator-tajo/patchprocess/newPatchFindbugsWarningstajo-common.html Findbugs warnings: https://builds.apache.org/job/PreCommit-TAJO-Build/324//artifact/incubator-tajo/patchprocess/newPatchFindbugsWarningstajo-rpc.html Findbugs warnings: https://builds.apache.org/job/PreCommit-TAJO-Build/324//artifact/incubator-tajo/patchprocess/newPatchFindbugsWarningstajo-core-backend.html Findbugs warnings: https://builds.apache.org/job/PreCommit-TAJO-Build/324//artifact/incubator-tajo/patchprocess/newPatchFindbugsWarningstajo-client.html Console output: https://builds.apache.org/job/PreCommit-TAJO-Build/324//console This message is automatically generated.
          Hide
          hjkim Hyoungjun Kim added a comment - - edited

          Created a review request against branch master in reviewboard
          https://reviews.apache.org/r/20217/

          Show
          hjkim Hyoungjun Kim added a comment - - edited Created a review request against branch master in reviewboard https://reviews.apache.org/r/20217/
          Hide
          jihoonson Jihoon Son added a comment -

          Thanks for your kind reply and suggestion.
          Your idea looks great to me!

          Show
          jihoonson Jihoon Son added a comment - Thanks for your kind reply and suggestion. Your idea looks great to me!
          Hide
          hjkim Hyoungjun Kim added a comment -

          Jihoon, Thanks for your comment. I also totally agree your comment. But most database shell includes Hive prints out after data. So a shell based ETL program uses last line for getting query result information. This is the reason why I want to move.
          What do you think about adding property for position of the message?

          Show
          hjkim Hyoungjun Kim added a comment - Jihoon, Thanks for your comment. I also totally agree your comment. But most database shell includes Hive prints out after data. So a shell based ETL program uses last line for getting query result information. This is the reason why I want to move. What do you think about adding property for position of the message?
          Hide
          jihoonson Jihoon Son added a comment -

          Hi, hyoungjun.
          I think that the number of rows is important information to users, and it would be better to appear before the query results.
          Do you have any reasons to move it to the bottom?

          Show
          jihoonson Jihoon Son added a comment - Hi, hyoungjun. I think that the number of rows is important information to users, and it would be better to appear before the query results. Do you have any reasons to move it to the bottom?
          Hide
          hjkim Hyoungjun Kim added a comment -

          Currently TajoCli prints out like bellow

          tpch100> select n_nationkey, n_name from nation;
          Progress: 0%, response time: 0.403 sec
          Progress: 100%, response time: 0.472 sec
          final state: QUERY_SUCCEEDED, response time: 0.472 sec
          result: hdfs://gruter102:6020/tmp/tajo-tajo/staging/q_1396598246335_0012/RESULT, 25 rows (267 B)
          n_nationkey,  n_name
          -------------------------------
          0,  ALGERIA
          1,  ARGENTINA
          ...
          21,  VIETNAM
          22,  RUSSIA
          23,  UNITED KINGDOM
          continue... ('q' is quit)
          24,  UNITED STATES
          

          I have plan to change like bellow. Removed "final state" line and moved number of rows to bottom.

          tpch100> select n_nationkey, n_name from nation;
          Progress: 0%, response time: 0.403 sec
          Progress: 100%, response time: 0.472 sec
          
          n_nationkey,  n_name
          -------------------------------
          0,  ALGERIA
          1,  ARGENTINA
          ...
          21,  VIETNAM
          22,  RUSSIA
          23,  UNITED KINGDOM
          continue... ('q' is quit)
          24,  UNITED STATES
          
          (25 rows, 3.609 sec, 2.1KiB)
          

          Header can be on or off via setting property "tajo.cli.print.header".
          Error message format:

           ERROR: [message] or
           ERROR: [message]
           [multi-line message trace]
          


          Please tell your opinion about position of number of rows and running time.

          If the position is bottom, It is difficult to know how many rows selected because TajoCli pauses after PRINT_LIMIT(25). Also I will changed that PRINT_LIMIT can be set or removed. In this case that line is scroll out.

          Show
          hjkim Hyoungjun Kim added a comment - Currently TajoCli prints out like bellow tpch100> select n_nationkey, n_name from nation; Progress: 0%, response time: 0.403 sec Progress: 100%, response time: 0.472 sec final state: QUERY_SUCCEEDED, response time: 0.472 sec result: hdfs://gruter102:6020/tmp/tajo-tajo/staging/q_1396598246335_0012/RESULT, 25 rows (267 B) n_nationkey, n_name ------------------------------- 0, ALGERIA 1, ARGENTINA ... 21, VIETNAM 22, RUSSIA 23, UNITED KINGDOM continue... ('q' is quit) 24, UNITED STATES I have plan to change like bellow. Removed "final state" line and moved number of rows to bottom. tpch100> select n_nationkey, n_name from nation; Progress: 0%, response time: 0.403 sec Progress: 100%, response time: 0.472 sec n_nationkey, n_name ------------------------------- 0, ALGERIA 1, ARGENTINA ... 21, VIETNAM 22, RUSSIA 23, UNITED KINGDOM continue... ('q' is quit) 24, UNITED STATES (25 rows, 3.609 sec, 2.1KiB) Header can be on or off via setting property "tajo.cli.print.header". Error message format: ERROR: [message] or ERROR: [message] [multi-line message trace] Please tell your opinion about position of number of rows and running time. If the position is bottom, It is difficult to know how many rows selected because TajoCli pauses after PRINT_LIMIT(25). Also I will changed that PRINT_LIMIT can be set or removed. In this case that line is scroll out.

            People

            • Assignee:
              hjkim Hyoungjun Kim
              Reporter:
              hjkim Hyoungjun Kim
            • Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development