Uploaded image for project: 'Solr'
  1. Solr
  2. SOLR-4051

DIH Delta updates do not work for all locales

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 4.0
    • Fix Version/s: None
    • Labels:
      None

      Description

      DIH Writes the last modified date to a Properties file using the default locale. This gets sent in plaintext to the database at the next delta update. DIH does not use prepared statements but just puts the date in an SQL Statement in yyyy-mm-dd hh:mm:ss format. It would probably be best to always format this date in JDBC escape syntax (http://docs.oracle.com/javase/1.4.2/docs/guide/jdbc/getstart/statement.html#999472) and java.sql.Timestamp#toString(). To do this, we'd need to parse the user's query and remove the single quotes likely there (and now the quotes would be optional and undesired).

      It might just be simpler to change the SimpleDateFormat to use the root locale as this appears to be the original intent here anyhow. Affected locales include ja_JP_JP , hi_IN , th_TH

        Attachments

        1. SOLR-4051.patch
          103 kB
          James Dyer
        2. SOLR-4051.patch
          30 kB
          James Dyer

          Issue Links

            Activity

              People

              • Assignee:
                jdyer James Dyer
                Reporter:
                jdyer James Dyer
              • Votes:
                0 Vote for this issue
                Watchers:
                1 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: